Add Xcode environment support #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang and
saurabhst
saurabhst
approved these changes
Oct 19, 2020
|
@rwalker-apple Are the temperature-measurement bits here on purpose? |
rwalker-apple
force-pushed
the
Add-Xcode-environment-support
branch
from
be4882e to
c18a9d8
Compare
no, I think I have a borken master ;) fixed now |
rwalker-apple
force-pushed
the
Add-Xcode-environment-support
branch
from
c18a9d8 to
0fa41b6
Compare
rwalker-apple
force-pushed
the
Add-Xcode-environment-support
branch
4 times, most recently
from
6b8a6f2 to
898dbe6
Compare
rwalker-apple
force-pushed
the
Add-Xcode-environment-support
branch
from
898dbe6 to
fb33d35
Compare
bzbarsky-apple
approved these changes
Oct 20, 2020
mspang
approved these changes
Oct 20, 2020
rwalker-apple
force-pushed
the
Add-Xcode-environment-support
branch
from
c3bd6c4 to
0848d36
Compare
* run activate in an external env from the Xcode connector * fix pip install nits * fix mismerge, set CHIP_ROOT unconditionally * use better names than updirs, lookinfer
rwalker-apple
force-pushed
the
Add-Xcode-environment-support
branch
from
0848d36 to
3b93b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is necessary to set arbitrary environment variables for Xcode builds in some environments, but chip_xcode_build_connector.sh only supports one or two.
Summary of Changes