-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated unit tests in src/protocols/bdx/tests/ to use PW instead of NL. #33084
Updated unit tests in src/protocols/bdx/tests/ to use PW instead of NL. #33084
Conversation
PR #33084: Size comparison from b4650b9 to bafa47a Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
….txt to test_components.txt.
PR #33084: Size comparison from 8dd2de7 to 82d29b9 Decreases (1 build for efr32)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor tests and correctly use ASSERT_*
in paces where test should be stopped immediately.
…factored to get rid of else branches that did nothing but ASSERT_TRUE(false).
PR #33084: Size comparison from 03bf252 to 55c8dee Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
….com/feasel0/connectedhomeip into feature/unittest-protocols-bdx-tests
PR #33084: Size comparison from 742e65b to 4d5fa40 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33084: Size comparison from be15c9b to 3a621b7 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
These changes are replacing nl-unit tests with the pigweed-unit tests, continuing the efforts from #29342 and others. I updated the tests in src/protocols/bdx/tests/ No changes were made to the logic of the tests.