-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::optional for chip::Nullable #33080
Merged
mergify
merged 25 commits into
project-chip:master
from
andy31415:nullable_is_std_optional
Apr 29, 2024
Merged
Use std::optional for chip::Nullable #33080
mergify
merged 25 commits into
project-chip:master
from
andy31415:nullable_is_std_optional
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
April 19, 2024 18:49
This comment was marked as outdated.
This comment was marked as outdated.
Damian-Nordic
approved these changes
Apr 23, 2024
This comment was marked as outdated.
This comment was marked as outdated.
andy31415
force-pushed
the
nullable_is_std_optional
branch
from
April 23, 2024 14:59
843e33e
to
569f7ca
Compare
This comment was marked as outdated.
This comment was marked as outdated.
…like using has_value in equality operators
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PR #33080: Size comparison from 700e6d2 to 4796bf6 Increases above 0.2%:
Increases (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (32 builds for cc13x4_26x4, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33080: Size comparison from 8b21ecf to e846720 Increases above 0.2%:
Increases (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, telink)
Decreases (32 builds for cc13x4_26x4, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Apr 26, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
PR #33080: Size comparison from 7bd2409 to 25055dd Increases above 0.2%:
Increases (55 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (34 builds for cc13x4_26x4, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes chip::Nullable use std::optional instead of chip::Optional.
Api is compatible, however move destructor calling is slightly different. Tests pass, however move constructor/assignment tests were updated.