Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some MTRInteractionErrorCode enum names. #33076

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

All the names need to start with MTRInteractionErrorCode.

All the names need to start with MTRInteractionErrorCode.
@woody-apple woody-apple merged commit 8823bd9 into project-chip:master Apr 19, 2024
62 of 63 checks passed
Copy link

github-actions bot commented Apr 19, 2024

PR #33076: Size comparison from 27a05ca to 388381a

Decreases (2 builds for efr32)
platform target config section 27a05ca 388381a change % change
efr32 lighting-app BRD4187C (read/write) 1069608 1069600 -8 -0.0
.text 886236 886228 -8 -0.0
window-app BRD4187C (read/write) 1135932 1135924 -8 -0.0
.text 968056 968048 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 27a05ca 388381a change % change
bl602 lighting-app bl602 (read/write) 1442810 1442810 0 0.0
.bss 85448 85448 0 0.0
.data 9512 9512 0 0.0
.rodata 159068 159068 0 0.0
.text 1108122 1108122 0 0.0
bl602+mfd (read/write) 1457226 1457226 0 0.0
.bss 85616 85616 0 0.0
.data 9488 9488 0 0.0
.rodata 158028 158028 0 0.0
.text 1123440 1123440 0 0.0
bl602+rpc (read/write) 1490202 1490202 0 0.0
.bss 93488 93488 0 0.0
.data 9888 9888 0 0.0
.rodata 166644 166644 0 0.0
.text 1139512 1139512 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209239 1209239 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108768 108768 0 0.0
.text 978634 978634 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220059 1220059 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107708 107708 0 0.0
.text 990388 990388 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1300727 1300727 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124140 124140 0 0.0
.text 1053342 1053342 0 0.0
bl706-eth (read/write) 1024945 1024945 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101756 101756 0 0.0
.text 768138 768138 0 0.0
bl706-wifi (read/write) 1259618 1259618 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122756 122756 0 0.0
.text 1000042 1000042 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1178560 1178560 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102772 102772 0 0.0
.text 971488 971488 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1189976 1189976 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101712 101712 0 0.0
.text 983810 983810 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 783644 783644 0 0.0
(read/write) 171660 171660 0 0.0
.bss 93604 93604 0 0.0
.data 3588 3588 0 0.0
.rodata 82932 82932 0 0.0
.text 700448 700448 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799500 799500 0 0.0
(read/write) 182148 182148 0 0.0
.bss 104092 104092 0 0.0
.data 3588 3588 0 0.0
.rodata 76916 76916 0 0.0
.text 722316 722316 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788396 788396 0 0.0
(read/write) 176268 176268 0 0.0
.bss 98212 98212 0 0.0
.data 3588 3588 0 0.0
.rodata 103836 103836 0 0.0
.text 684296 684296 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 740716 740716 0 0.0
(read/write) 170636 170636 0 0.0
.bss 92344 92344 0 0.0
.data 3580 3580 0 0.0
.rodata 78596 78596 0 0.0
.text 661856 661856 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726340 726340 0 0.0
(read/write) 170844 170844 0 0.0
.bss 92568 92568 0 0.0
.data 3572 3572 0 0.0
.rodata 74372 74372 0 0.0
.text 651704 651704 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586790 586790 0 0.0
(read/write) 208100 208100 0 0.0
.bss 201324 201324 0 0.0
.data 1652 1652 0 0.0
.rodata 87502 87502 0 0.0
.text 497164 497164 0 0.0
lock CC3235SF_LAUNCHXL (read only) 632974 632974 0 0.0
(read/write) 208364 208364 0 0.0
.bss 201728 201728 0 0.0
.data 1516 1516 0 0.0
.rodata 108190 108190 0 0.0
.text 522664 522664 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570375 570375 0 0.0
.app_xip_area 460285 460285 0 0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552591 552591 0 0.0
.app_xip_area 437829 437829 0 0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573143 573143 0 0.0
.app_xip_area 464549 464549 0 0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565647 565647 0 0.0
.app_xip_area 453869 453869 0 0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069608 1069600 -8 -0.0
.bss 179920 179920 0 0.0
.data 3432 3432 0 0.0
.text 886236 886228 -8 -0.0
lock-app BRD4338a (read/write) 961908 961908 0 0.0
.bss 210236 210236 0 0.0
.data 30288 30288 0 0.0
.text 702016 702016 0 0.0
window-app BRD4187C (read/write) 1135932 1135924 -8 -0.0
.bss 164520 164520 0 0.0
.data 3336 3336 0 0.0
.text 968056 968048 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214174 1214174 0 0.0
(read/write) 1750752 1750752 0 0.0
.dram0.bss 74328 74328 0 0.0
.dram0.data 13636 13636 0 0.0
.flash.rodata 253248 253248 0 0.0
.flash.text 1214174 1214174 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1256975 1256975 0 0.0
(read/write) 537116 537116 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284952 284952 0 0.0
.flash.text 1250811 1250811 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2647845 2647845 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46728 46728 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 185392 185392 0 0.0
.text 2283461 2283461 0 0.0
all-clusters-app debug (read only) 5962441 5962441 0 0.0
(read/write) 481672 481672 0 0.0
.bss 135040 135040 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334632 334632 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 352208 352208 0 0.0
.text 5175091 5175091 0 0.0
all-clusters-minimal-app debug (read only) 5242417 5242417 0 0.0
(read/write) 237624 237624 0 0.0
.bss 127872 127872 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98216 98216 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290858 290858 0 0.0
.text 4715075 4715075 0 0.0
bridge-app debug (read only) 4634281 4634281 0 0.0
(read/write) 218536 218536 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87168 87168 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 231242 231242 0 0.0
.text 4180979 4180979 0 0.0
chip-tool debug (read only) 12085105 12085105 0 0.0
(read/write) 523104 523104 0 0.0
.bss 94744 94744 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451449 451449 0 0.0
.text 10925299 10925299 0 0.0
chip-tool-ipv6only arm64 (read only) 11404116 11404116 0 0.0
(read/write) 587088 587088 0 0.0
.bss 103720 103720 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356260 356260 0 0.0
.text 10166168 10166168 0 0.0
lighting-app debug+rpc+ui (read only) 5558281 5558281 0 0.0
(read/write) 227304 227304 0 0.0
.bss 119344 119344 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95536 95536 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 355124 355124 0 0.0
.text 4954707 4954707 0 0.0
lock-app debug (read only) 4700145 4700145 0 0.0
(read/write) 205760 205760 0 0.0
.bss 113704 113704 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81160 81160 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 257034 257034 0 0.0
.text 4230115 4230115 0 0.0
ota-provider-app debug (read only) 4310433 4310433 0 0.0
(read/write) 194200 194200 0 0.0
.bss 113440 113440 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209642 209642 0 0.0
.text 3906307 3906307 0 0.0
ota-requestor-app debug (read only) 4441265 4441265 0 0.0
(read/write) 198568 198568 0 0.0
.bss 114336 114336 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215914 215914 0 0.0
.text 4026323 4026323 0 0.0
shell debug (read only) 2930537 2930537 0 0.0
(read/write) 157040 157040 0 0.0
.bss 62512 62512 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87312 87312 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 188576 188576 0 0.0
.text 2566850 2566850 0 0.0
thermostat-no-ble arm64 (read only) 4433740 4433740 0 0.0
(read/write) 245760 245760 0 0.0
.bss 121976 121976 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104424 104424 0 0.0
.dynamic 512 512 0 0.0
.got 8728 8728 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160388 160388 0 0.0
.text 3936504 3936504 0 0.0
tv-app debug (read only) 5773865 5773865 0 0.0
(read/write) 353496 353496 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95320 95320 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295466 295466 0 0.0
.text 5234643 5234643 0 0.0
tv-casting-app debug (read only) 9899065 9899065 0 0.0
(read/write) 342720 342720 0 0.0
.bss 157976 157976 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174848 174848 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384760 384760 0 0.0
.text 9047427 9047427 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535632 2535632 0 0.0
.bss 220488 220488 0 0.0
.data 5216 5216 0 0.0
.text 1498316 1498316 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1065920 1065920 0 0.0
bss 133119 133119 0 0.0
rodata 103400 103400 0 0.0
text 782180 782180 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1226392 1226392 0 0.0
bss 127175 127175 0 0.0
rodata 151368 151368 0 0.0
text 797824 797824 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1013520 1013520 0 0.0
bss 131977 131977 0 0.0
rodata 90664 90664 0 0.0
text 743548 743548 0 0.0
nxp contact k32w0+release (read only) 575676 575676 0 0.0
(read/write) 83140 83140 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575140 575140 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 702948 702948 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589504 589504 0 0.0
light k32w0+release (read only) 609696 609696 0 0.0
(read/write) 82592 82592 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609160 609160 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 794888 794888 0 0.0
.bss 80744 80744 0 0.0
.data 2064 2064 0 0.0
.text 672712 672712 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832272 832272 0 0.0
(read/write) 1804636 1804636 0 0.0
.bss 198380 198380 0 0.0
.data 2688 2688 0 0.0
.text 1595180 1595180 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835424 835424 0 0.0
(read/write) 1726524 1726524 0 0.0
.bss 195260 195260 0 0.0
.data 2656 2656 0 0.0
.text 1520220 1520220 0 0.0
light cy8ckit_062s2_43012 (read only) 842144 842144 0 0.0
(read/write) 1645260 1645260 0 0.0
.bss 188724 188724 0 0.0
.data 2472 2472 0 0.0
.text 1445676 1445676 0 0.0
lock cy8ckit_062s2_43012 (read only) 815072 815072 0 0.0
(read/write) 1673948 1673948 0 0.0
.bss 215804 215804 0 0.0
.data 2464 2464 0 0.0
.text 1447292 1447292 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133244 1133244 0 0.0
.bss 102588 102588 0 0.0
.data 856 856 0 0.0
.text 645624 645624 0 0.0
lock-app qpg6105+debug (read/write) 1093236 1093236 0 0.0
.bss 97260 97260 0 0.0
.data 860 860 0 0.0
.text 605620 605620 0 0.0
stm32 light STM32WB5MM-DK (read/write) 604841 604841 0 0.0
.bss 128444 128444 0 0.0
.data 688 688 0 0.0
.rodata 80516 80516 0 0.0
.text 385448 385448 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833974 833974 0 0.0
bss 49856 49856 0 0.0
text 624660 624660 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1097196 1097196 0 0.0
bss 101540 101540 0 0.0
text 798206 798206 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058660 1058660 0 0.0
bss 109988 109988 0 0.0
text 772568 772568 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914044 914044 0 0.0
bss 92744 92744 0 0.0
text 655914 655914 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836002 836002 0 0.0
bss 49900 49900 0 0.0
text 626766 626766 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 936796 936796 0 0.0
bss 77512 77512 0 0.0
text 703432 703432 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090556 1090556 0 0.0
bss 99836 99836 0 0.0
text 794022 794022 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911248 911248 0 0.0
bss 69180 69180 0 0.0
text 660298 660298 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932896 932896 0 0.0
bss 92448 92448 0 0.0
text 674956 674956 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833656 833656 0 0.0
bss 58144 58144 0 0.0
text 623862 623862 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799776 799776 0 0.0
bss 56072 56072 0 0.0
text 598768 598768 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676128 676128 0 0.0
bss 73424 73424 0 0.0
text 461864 461864 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843742 843742 0 0.0
bss 51528 51528 0 0.0
text 633308 633308 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858561 858561 0 0.0
bss 59696 59696 0 0.0
text 642252 642252 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825324 825324 0 0.0
bss 56404 56404 0 0.0
text 618324 618324 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838448 838448 0 0.0
bss 58360 58360 0 0.0
text 626232 626232 0 0.0

@bzbarsky-apple bzbarsky-apple deleted the fix-error-code-names branch April 19, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants