-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility to get user default values for configurable parameters fo… #33056
Merged
mergify
merged 13 commits into
project-chip:master
from
nivi-apple:make_srp_timer_configurable
Apr 20, 2024
Merged
Add utility to get user default values for configurable parameters fo… #33056
mergify
merged 13 commits into
project-chip:master
from
nivi-apple:make_srp_timer_configurable
Apr 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r darwin - Add support for getting a user default value for the SRP resolve timeout for DNS-SD. If user default value exists, ovveride the timeout. - Update the SRP resolve timeout to 3 secs The default can be set by using `defaults write org.csa-iot.matter.darwindefaults SRPTimeoutOverride <timeoutinMsecs>`
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
April 18, 2024 23:13
PR #33056: Size comparison from fbe1835 to 58cbfc8 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jtung-apple
reviewed
Apr 18, 2024
andy31415
reviewed
Apr 18, 2024
andy31415
reviewed
Apr 18, 2024
andy31415
reviewed
Apr 18, 2024
andy31415
reviewed
Apr 18, 2024
PR #33056: Size comparison from fbe1835 to f671387 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
Apr 19, 2024
jtung-apple
approved these changes
Apr 19, 2024
jtung-apple
reviewed
Apr 19, 2024
yunhanw-google
approved these changes
Apr 19, 2024
PR #33056: Size comparison from fbe1835 to 96b68fe Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #33056: Size comparison from fbe1835 to 1a3027e Increases above 0.2%:
Increases (18 builds for esp32, linux, nxp)
Decreases (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Apr 19, 2024
PR #33056: Size comparison from fbe1835 to 466241d Increases above 0.2%:
Increases (11 builds for cc13x4_26x4, esp32, linux, nxp)
Decreases (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #33056: Size comparison from fbe1835 to 7caa86d Increases above 0.2%:
Increases (23 builds for cc13x4_26x4, esp32, linux, nxp)
Decreases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r darwin
Add support for getting a user default value for the SRP resolve timeout for DNS-SD. If user default value exists, ovveride the timeout.
Update the SRP resolve timeout to 3 secs
The default can be set by using
defaults write org.csa-iot.matter.darwin SRPTimeoutInMSecsOverride <timeoutinMsecs>
Fixes: #33055