Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some usages of chip::Optional with std::optional #33050

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Replace some usages of chip::Optional with std::optional #33050

merged 4 commits into from
Apr 19, 2024

Conversation

andy31415
Copy link
Contributor

Trying to use the standard library as much as possible instead of writing our own (especially since our own seems to have some bugs regarding assignment: chip::Optional supports = even if the underlying type does not support it).

Looking to see the impact on code size from making a change.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

PR #33050: Size comparison from 8a4dffc to e6df82a

Increases (14 builds for linux)
platform target config section 8a4dffc5 e6df82a change % change
linux air-purifier-app debug (read only) 2647317 2647845 528 0.0
.text 2282933 2283461 528 0.0
all-clusters-app debug (read only) 5962073 5962441 368 0.0
.text 5174723 5175091 368 0.0
all-clusters-minimal-app debug (read only) 5242049 5242417 368 0.0
.text 4714707 4715075 368 0.0
bridge-app debug (read only) 4634009 4634281 272 0.0
.text 4180707 4180979 272 0.0
chip-tool debug (read only) 12084753 12085105 352 0.0
.text 10924947 10925299 352 0.0
chip-tool-ipv6only arm64 (read only) 11403796 11404116 320 0.0
.text 10165848 10166168 320 0.0
lighting-app debug+rpc+ui (read only) 5558057 5558281 224 0.0
.text 4954483 4954707 224 0.0
lock-app debug (read only) 4699857 4700145 288 0.0
.text 4229827 4230115 288 0.0
ota-provider-app debug (read only) 4310161 4310433 272 0.0
.text 3906035 3906307 272 0.0
ota-requestor-app debug (read only) 4440993 4441265 272 0.0
.text 4026051 4026323 272 0.0
shell debug (read only) 2929913 2930537 624 0.0
.text 2566226 2566850 624 0.0
thermostat-no-ble arm64 (read only) 4433564 4433740 176 0.0
.text 3936328 3936504 176 0.0
tv-app debug (read only) 5773513 5773865 352 0.0
.text 5234291 5234643 352 0.0
tv-casting-app debug (read only) 9898457 9899065 608 0.0
.text 9046819 9047427 608 0.0
Decreases (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 8a4dffc5 e6df82a change % change
bl602 lighting-app bl602 (read/write) 1443066 1442810 -256 -0.0
.text 1108384 1108122 -262 -0.0
bl602+mfd (read/write) 1457490 1457226 -264 -0.0
.text 1123702 1123440 -262 -0.0
bl602+rpc (read/write) 1490466 1490202 -264 -0.0
.text 1139774 1139512 -262 -0.0
bl702 lighting-app bl702 (read/write) 1209499 1209239 -260 -0.0
.text 978896 978634 -262 -0.0
bl702+mfd (read/write) 1220323 1220059 -264 -0.0
.text 990650 990388 -262 -0.0
bl702+rpc (read/write) 1300987 1300727 -260 -0.0
.text 1053604 1053342 -262 -0.0
bl706-eth (read/write) 1025205 1024945 -260 -0.0
.text 768400 768138 -262 -0.0
bl706-wifi (read/write) 1259866 1259618 -248 -0.0
.text 1000292 1000042 -250 -0.0
bl702l lighting-app bl702l (read/write) 1179336 1178560 -776 -0.1
.text 971750 971488 -262 -0.0
bl702l+mfd (read/write) 1190236 1189976 -260 -0.0
.text 984072 983810 -262 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 783724 783644 -80 -0.0
.text 700528 700448 -80 -0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799580 799500 -80 -0.0
.text 722396 722316 -80 -0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788476 788396 -80 -0.0
.text 684376 684296 -80 -0.0
pump-app LP_EM_CC1354P10_6 (read only) 740796 740716 -80 -0.0
.text 661936 661856 -80 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726420 726340 -80 -0.0
.text 651784 651704 -80 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586950 586790 -160 -0.0
.text 497324 497164 -160 -0.0
lock CC3235SF_LAUNCHXL (read only) 633142 632974 -168 -0.0
.text 522832 522664 -168 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570447 570375 -72 -0.0
.app_xip_area 460357 460285 -72 -0.0
lock cyw930739m2evb_01 (read/write) 552663 552591 -72 -0.0
.app_xip_area 437901 437829 -72 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 573215 573143 -72 -0.0
.app_xip_area 464621 464549 -72 -0.0
switch cyw930739m2evb_01 (read/write) 565727 565647 -80 -0.0
.app_xip_area 453949 453869 -80 -0.0
efr32 lighting-app BRD4187C (read/write) 1069672 1069600 -72 -0.0
.text 886300 886228 -72 -0.0
lock-app BRD4338a (read/write) 962068 961908 -160 -0.0
.text 702176 702016 -160 -0.0
window-app BRD4187C (read/write) 1136092 1135924 -168 -0.0
.text 968216 968048 -168 -0.0
esp32 all-clusters-app c3devkit (read only) 1214260 1214138 -122 -0.0
.flash.text 1214260 1214138 -122 -0.0
m5stack (read only) 1257015 1256955 -60 -0.0
.flash.text 1250851 1250791 -60 -0.0
linux chip-tool-ipv6only arm64 (read/write) 587408 587088 -320 -0.1
thermostat-no-ble arm64 (read/write) 245936 245760 -176 -0.1
mbed lock-app-release cy8cproto_062_4343w (read/write) 2535696 2535632 -64 -0.0
.text 1498380 1498316 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1065984 1065920 -64 -0.0
text 782256 782180 -76 -0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1226472 1226392 -80 -0.0
text 797900 797824 -76 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1013584 1013520 -64 -0.0
text 743624 743548 -76 -0.0
nxp contact k32w0+release (read only) 575756 575676 -80 -0.0
.text 575220 575140 -80 -0.0
k32w1+release (read/write) 703028 702948 -80 -0.0
.text 589584 589504 -80 -0.0
light k32w0+release (read only) 609776 609696 -80 -0.0
.text 609240 609160 -80 -0.0
k32w1+release (read/write) 794968 794888 -80 -0.0
.text 672792 672712 -80 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1804796 1804636 -160 -0.0
.text 1595340 1595180 -160 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1726700 1726524 -176 -0.0
.text 1520396 1520220 -176 -0.0
light cy8ckit_062s2_43012 (read/write) 1645420 1645260 -160 -0.0
.text 1445836 1445676 -160 -0.0
lock cy8ckit_062s2_43012 (read/write) 1674108 1673948 -160 -0.0
.text 1447452 1447292 -160 -0.0
qpg lighting-app qpg6105+debug (read/write) 1133316 1133244 -72 -0.0
.text 645696 645624 -72 -0.0
lock-app qpg6105+debug (read/write) 1093316 1093236 -80 -0.0
.text 605700 605620 -80 -0.0
stm32 light STM32WB5MM-DK (read/write) 604921 604841 -80 -0.0
.text 385528 385448 -80 -0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 834086 833974 -112 -0.0
text 624770 624660 -110 -0.0
all-clusters-app tlsr9518adk80d (read/write) 1097308 1097196 -112 -0.0
text 798316 798206 -110 -0.0
all-clusters-minimal-app tlsr9528a (read/write) 1058772 1058660 -112 -0.0
text 772678 772568 -110 -0.0
bridge-app tlsr9518adk80d (read/write) 914156 914044 -112 -0.0
text 656024 655914 -110 -0.0
contact-sensor-app tlsr9528a_retention (read/write) 836114 836002 -112 -0.0
text 626876 626766 -110 -0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 936908 936796 -112 -0.0
text 703542 703432 -110 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1090668 1090556 -112 -0.0
text 794132 794022 -110 -0.0
lock-app-dfu tlsr9528a (read/write) 911360 911248 -112 -0.0
text 660408 660298 -110 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 933008 932896 -112 -0.0
text 675066 674956 -110 -0.0
pump-app tlsr9258a (read/write) 833760 833656 -104 -0.0
text 623972 623862 -110 -0.0
pump-controller-app tlsr9518adk80d (read/write) 799888 799776 -112 -0.0
text 598878 598768 -110 -0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 843854 843742 -112 -0.0
text 633418 633308 -110 -0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 858673 858561 -112 -0.0
text 642362 642252 -110 -0.0
thermostat tlsr9518adk80d (read/write) 825436 825324 -112 -0.0
text 618434 618324 -110 -0.0
window-covering tlsr9258a (read/write) 838560 838448 -112 -0.0
text 626342 626232 -110 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 8a4dffc5 e6df82a change % change
bl602 lighting-app bl602 (read/write) 1443066 1442810 -256 -0.0
.bss 85448 85448 0 0.0
.data 9512 9512 0 0.0
.rodata 159068 159068 0 0.0
.text 1108384 1108122 -262 -0.0
bl602+mfd (read/write) 1457490 1457226 -264 -0.0
.bss 85616 85616 0 0.0
.data 9488 9488 0 0.0
.rodata 158028 158028 0 0.0
.text 1123702 1123440 -262 -0.0
bl602+rpc (read/write) 1490466 1490202 -264 -0.0
.bss 93488 93488 0 0.0
.data 9888 9888 0 0.0
.rodata 166644 166644 0 0.0
.text 1139774 1139512 -262 -0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209499 1209239 -260 -0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108768 108768 0 0.0
.text 978896 978634 -262 -0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220323 1220059 -264 -0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107708 107708 0 0.0
.text 990650 990388 -262 -0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1300987 1300727 -260 -0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124140 124140 0 0.0
.text 1053604 1053342 -262 -0.0
bl706-eth (read/write) 1025205 1024945 -260 -0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101756 101756 0 0.0
.text 768400 768138 -262 -0.0
bl706-wifi (read/write) 1259866 1259618 -248 -0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122756 122756 0 0.0
.text 1000292 1000042 -250 -0.0
bl702l lighting-app bl702l (read/write) 1179336 1178560 -776 -0.1
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102772 102772 0 0.0
.text 971750 971488 -262 -0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190236 1189976 -260 -0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101712 101712 0 0.0
.text 984072 983810 -262 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 783724 783644 -80 -0.0
(read/write) 171660 171660 0 0.0
.bss 93604 93604 0 0.0
.data 3588 3588 0 0.0
.rodata 82932 82932 0 0.0
.text 700528 700448 -80 -0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799580 799500 -80 -0.0
(read/write) 182148 182148 0 0.0
.bss 104092 104092 0 0.0
.data 3588 3588 0 0.0
.rodata 76916 76916 0 0.0
.text 722396 722316 -80 -0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788476 788396 -80 -0.0
(read/write) 176268 176268 0 0.0
.bss 98212 98212 0 0.0
.data 3588 3588 0 0.0
.rodata 103836 103836 0 0.0
.text 684376 684296 -80 -0.0
pump-app LP_EM_CC1354P10_6 (read only) 740796 740716 -80 -0.0
(read/write) 170636 170636 0 0.0
.bss 92344 92344 0 0.0
.data 3580 3580 0 0.0
.rodata 78596 78596 0 0.0
.text 661936 661856 -80 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726420 726340 -80 -0.0
(read/write) 170844 170844 0 0.0
.bss 92568 92568 0 0.0
.data 3572 3572 0 0.0
.rodata 74372 74372 0 0.0
.text 651784 651704 -80 -0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586950 586790 -160 -0.0
(read/write) 208100 208100 0 0.0
.bss 201324 201324 0 0.0
.data 1652 1652 0 0.0
.rodata 87502 87502 0 0.0
.text 497324 497164 -160 -0.0
lock CC3235SF_LAUNCHXL (read only) 633142 632974 -168 -0.0
(read/write) 208364 208364 0 0.0
.bss 201728 201728 0 0.0
.data 1516 1516 0 0.0
.rodata 108190 108190 0 0.0
.text 522832 522664 -168 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570447 570375 -72 -0.0
.app_xip_area 460357 460285 -72 -0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552663 552591 -72 -0.0
.app_xip_area 437901 437829 -72 -0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573215 573143 -72 -0.0
.app_xip_area 464621 464549 -72 -0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565727 565647 -80 -0.0
.app_xip_area 453949 453869 -80 -0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069672 1069600 -72 -0.0
.bss 179920 179920 0 0.0
.data 3432 3432 0 0.0
.text 886300 886228 -72 -0.0
lock-app BRD4338a (read/write) 962068 961908 -160 -0.0
.bss 210236 210236 0 0.0
.data 30288 30288 0 0.0
.text 702176 702016 -160 -0.0
window-app BRD4187C (read/write) 1136092 1135924 -168 -0.0
.bss 164520 164520 0 0.0
.data 3336 3336 0 0.0
.text 968216 968048 -168 -0.0
esp32 all-clusters-app c3devkit (read only) 1214260 1214138 -122 -0.0
(read/write) 1750696 1750696 0 0.0
.dram0.bss 74328 74328 0 0.0
.dram0.data 13636 13636 0 0.0
.flash.rodata 253192 253192 0 0.0
.flash.text 1214260 1214138 -122 -0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1257015 1256955 -60 -0.0
(read/write) 537060 537060 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284896 284896 0 0.0
.flash.text 1250851 1250791 -60 -0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2647317 2647845 528 0.0
(read/write) 130032 130032 0 0.0
.bss 46728 46728 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 185392 185392 0 0.0
.text 2282933 2283461 528 0.0
all-clusters-app debug (read only) 5962073 5962441 368 0.0
(read/write) 481672 481672 0 0.0
.bss 135040 135040 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334632 334632 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 352208 352208 0 0.0
.text 5174723 5175091 368 0.0
all-clusters-minimal-app debug (read only) 5242049 5242417 368 0.0
(read/write) 237624 237624 0 0.0
.bss 127872 127872 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98216 98216 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290858 290858 0 0.0
.text 4714707 4715075 368 0.0
bridge-app debug (read only) 4634009 4634281 272 0.0
(read/write) 218536 218536 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87168 87168 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 231242 231242 0 0.0
.text 4180707 4180979 272 0.0
chip-tool debug (read only) 12084753 12085105 352 0.0
(read/write) 523104 523104 0 0.0
.bss 94744 94744 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451449 451449 0 0.0
.text 10924947 10925299 352 0.0
chip-tool-ipv6only arm64 (read only) 11403796 11404116 320 0.0
(read/write) 587408 587088 -320 -0.1
.bss 103720 103720 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356260 356260 0 0.0
.text 10165848 10166168 320 0.0
lighting-app debug+rpc+ui (read only) 5558057 5558281 224 0.0
(read/write) 227304 227304 0 0.0
.bss 119344 119344 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95536 95536 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 355124 355124 0 0.0
.text 4954483 4954707 224 0.0
lock-app debug (read only) 4699857 4700145 288 0.0
(read/write) 205760 205760 0 0.0
.bss 113704 113704 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81160 81160 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 257034 257034 0 0.0
.text 4229827 4230115 288 0.0
ota-provider-app debug (read only) 4310161 4310433 272 0.0
(read/write) 194200 194200 0 0.0
.bss 113440 113440 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209642 209642 0 0.0
.text 3906035 3906307 272 0.0
ota-requestor-app debug (read only) 4440993 4441265 272 0.0
(read/write) 198568 198568 0 0.0
.bss 114336 114336 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215914 215914 0 0.0
.text 4026051 4026323 272 0.0
shell debug (read only) 2929913 2930537 624 0.0
(read/write) 157040 157040 0 0.0
.bss 62512 62512 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87312 87312 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 188576 188576 0 0.0
.text 2566226 2566850 624 0.0
thermostat-no-ble arm64 (read only) 4433564 4433740 176 0.0
(read/write) 245936 245760 -176 -0.1
.bss 121976 121976 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104424 104424 0 0.0
.dynamic 512 512 0 0.0
.got 8728 8728 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160388 160388 0 0.0
.text 3936328 3936504 176 0.0
tv-app debug (read only) 5773513 5773865 352 0.0
(read/write) 353496 353496 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95320 95320 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295466 295466 0 0.0
.text 5234291 5234643 352 0.0
tv-casting-app debug (read only) 9898457 9899065 608 0.0
(read/write) 342720 342720 0 0.0
.bss 157976 157976 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174848 174848 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384760 384760 0 0.0
.text 9046819 9047427 608 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535696 2535632 -64 -0.0
.bss 220488 220488 0 0.0
.data 5216 5216 0 0.0
.text 1498380 1498316 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1065984 1065920 -64 -0.0
bss 133119 133119 0 0.0
rodata 103400 103400 0 0.0
text 782256 782180 -76 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1226472 1226392 -80 -0.0
bss 127175 127175 0 0.0
rodata 151368 151368 0 0.0
text 797900 797824 -76 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1013584 1013520 -64 -0.0
bss 131977 131977 0 0.0
rodata 90664 90664 0 0.0
text 743624 743548 -76 -0.0
nxp contact k32w0+release (read only) 575756 575676 -80 -0.0
(read/write) 80028 80028 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575220 575140 -80 -0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703028 702948 -80 -0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589584 589504 -80 -0.0
light k32w0+release (read only) 609776 609696 -80 -0.0
(read/write) 79488 79488 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609240 609160 -80 -0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 794968 794888 -80 -0.0
.bss 80744 80744 0 0.0
.data 2064 2064 0 0.0
.text 672792 672712 -80 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832272 832272 0 0.0
(read/write) 1804796 1804636 -160 -0.0
.bss 198380 198380 0 0.0
.data 2688 2688 0 0.0
.text 1595340 1595180 -160 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835424 835424 0 0.0
(read/write) 1726700 1726524 -176 -0.0
.bss 195260 195260 0 0.0
.data 2656 2656 0 0.0
.text 1520396 1520220 -176 -0.0
light cy8ckit_062s2_43012 (read only) 842144 842144 0 0.0
(read/write) 1645420 1645260 -160 -0.0
.bss 188724 188724 0 0.0
.data 2472 2472 0 0.0
.text 1445836 1445676 -160 -0.0
lock cy8ckit_062s2_43012 (read only) 815072 815072 0 0.0
(read/write) 1674108 1673948 -160 -0.0
.bss 215804 215804 0 0.0
.data 2464 2464 0 0.0
.text 1447452 1447292 -160 -0.0
qpg lighting-app qpg6105+debug (read/write) 1133316 1133244 -72 -0.0
.bss 102588 102588 0 0.0
.data 856 856 0 0.0
.text 645696 645624 -72 -0.0
lock-app qpg6105+debug (read/write) 1093316 1093236 -80 -0.0
.bss 97260 97260 0 0.0
.data 860 860 0 0.0
.text 605700 605620 -80 -0.0
stm32 light STM32WB5MM-DK (read/write) 604921 604841 -80 -0.0
.bss 128444 128444 0 0.0
.data 688 688 0 0.0
.rodata 80516 80516 0 0.0
.text 385528 385448 -80 -0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834086 833974 -112 -0.0
bss 49856 49856 0 0.0
text 624770 624660 -110 -0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1097308 1097196 -112 -0.0
bss 101540 101540 0 0.0
text 798316 798206 -110 -0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058772 1058660 -112 -0.0
bss 109988 109988 0 0.0
text 772678 772568 -110 -0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914156 914044 -112 -0.0
bss 92744 92744 0 0.0
text 656024 655914 -110 -0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836114 836002 -112 -0.0
bss 49900 49900 0 0.0
text 626876 626766 -110 -0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 936908 936796 -112 -0.0
bss 77512 77512 0 0.0
text 703542 703432 -110 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090668 1090556 -112 -0.0
bss 99836 99836 0 0.0
text 794132 794022 -110 -0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911360 911248 -112 -0.0
bss 69180 69180 0 0.0
text 660408 660298 -110 -0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933008 932896 -112 -0.0
bss 92448 92448 0 0.0
text 675066 674956 -110 -0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833760 833656 -104 -0.0
bss 58144 58144 0 0.0
text 623972 623862 -110 -0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799888 799776 -112 -0.0
bss 56072 56072 0 0.0
text 598878 598768 -110 -0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676128 676128 0 0.0
bss 73424 73424 0 0.0
text 461864 461864 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843854 843742 -112 -0.0
bss 51528 51528 0 0.0
text 633418 633308 -110 -0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858673 858561 -112 -0.0
bss 59696 59696 0 0.0
text 642362 642252 -110 -0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825436 825324 -112 -0.0
bss 56404 56404 0 0.0
text 618434 618324 -110 -0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838560 838448 -112 -0.0
bss 58360 58360 0 0.0
text 626342 626232 -110 -0.0

@andy31415 andy31415 marked this pull request as ready for review April 18, 2024 20:40
@andy31415
Copy link
Contributor Author

Marking ready for review: bloaty indicates this as a size saving across the board for embedded (which probably are compiled with -Os).

@mergify mergify bot merged commit 9c06a05 into project-chip:master Apr 19, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@cecille cecille cecille approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app core lib review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andy31415 @cecille @Damian-Nordic @jmartinez-silabs @andreilitvin