Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] Add missing space at the end of --icd macro #33049

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mkardous-silabs
Copy link
Contributor

Description

When the sl_enable_test_event_trigger was added to the --icd macro, the space at the end was removed.
PR adds the space back.

Tests

Built an app using the --icd macro

Copy link

github-actions bot commented Apr 18, 2024

PR #33049: Size comparison from 8a4dffc to e3dd1db

Decreases (2 builds for efr32)
platform target config section 8a4dffc5 e3dd1db change % change
efr32 lighting-app BRD4187C (read/write) 1069672 1069664 -8 -0.0
.text 886300 886292 -8 -0.0
window-app BRD4187C (read/write) 1136092 1136084 -8 -0.0
.text 968216 968208 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 8a4dffc5 e3dd1db change % change
bl602 lighting-app bl602 (read/write) 1443066 1443066 0 0.0
.bss 85448 85448 0 0.0
.data 9512 9512 0 0.0
.rodata 159068 159068 0 0.0
.text 1108384 1108384 0 0.0
bl602+mfd (read/write) 1457490 1457490 0 0.0
.bss 85616 85616 0 0.0
.data 9488 9488 0 0.0
.rodata 158028 158028 0 0.0
.text 1123702 1123702 0 0.0
bl602+rpc (read/write) 1490466 1490466 0 0.0
.bss 93488 93488 0 0.0
.data 9888 9888 0 0.0
.rodata 166644 166644 0 0.0
.text 1139774 1139774 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209499 1209499 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108768 108768 0 0.0
.text 978896 978896 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220323 1220323 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107708 107708 0 0.0
.text 990650 990650 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1300987 1300987 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124140 124140 0 0.0
.text 1053604 1053604 0 0.0
bl706-eth (read/write) 1025205 1025205 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101756 101756 0 0.0
.text 768400 768400 0 0.0
bl706-wifi (read/write) 1259866 1259866 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122756 122756 0 0.0
.text 1000292 1000292 0 0.0
bl702l lighting-app bl702l (read/write) 1179336 1179336 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102772 102772 0 0.0
.text 971750 971750 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190236 1190236 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101712 101712 0 0.0
.text 984072 984072 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 783724 783724 0 0.0
(read/write) 171660 171660 0 0.0
.bss 93604 93604 0 0.0
.data 3588 3588 0 0.0
.rodata 82932 82932 0 0.0
.text 700528 700528 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799580 799580 0 0.0
(read/write) 182148 182148 0 0.0
.bss 104092 104092 0 0.0
.data 3588 3588 0 0.0
.rodata 76916 76916 0 0.0
.text 722396 722396 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788476 788476 0 0.0
(read/write) 176268 176268 0 0.0
.bss 98212 98212 0 0.0
.data 3588 3588 0 0.0
.rodata 103836 103836 0 0.0
.text 684376 684376 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 740796 740796 0 0.0
(read/write) 170636 170636 0 0.0
.bss 92344 92344 0 0.0
.data 3580 3580 0 0.0
.rodata 78596 78596 0 0.0
.text 661936 661936 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726420 726420 0 0.0
(read/write) 170844 170844 0 0.0
.bss 92568 92568 0 0.0
.data 3572 3572 0 0.0
.rodata 74372 74372 0 0.0
.text 651784 651784 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586950 586950 0 0.0
(read/write) 208100 208100 0 0.0
.bss 201324 201324 0 0.0
.data 1652 1652 0 0.0
.rodata 87502 87502 0 0.0
.text 497324 497324 0 0.0
lock CC3235SF_LAUNCHXL (read only) 633142 633142 0 0.0
(read/write) 208364 208364 0 0.0
.bss 201728 201728 0 0.0
.data 1516 1516 0 0.0
.rodata 108190 108190 0 0.0
.text 522832 522832 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570447 570447 0 0.0
.app_xip_area 460357 460357 0 0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552663 552663 0 0.0
.app_xip_area 437901 437901 0 0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573215 573215 0 0.0
.app_xip_area 464621 464621 0 0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565727 565727 0 0.0
.app_xip_area 453949 453949 0 0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069672 1069664 -8 -0.0
.bss 179920 179920 0 0.0
.data 3432 3432 0 0.0
.text 886300 886292 -8 -0.0
lock-app BRD4338a (read/write) 962068 962068 0 0.0
.bss 210236 210236 0 0.0
.data 30288 30288 0 0.0
.text 702176 702176 0 0.0
window-app BRD4187C (read/write) 1136092 1136084 -8 -0.0
.bss 164520 164520 0 0.0
.data 3336 3336 0 0.0
.text 968216 968208 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214260 1214260 0 0.0
(read/write) 1750696 1750696 0 0.0
.dram0.bss 74328 74328 0 0.0
.dram0.data 13636 13636 0 0.0
.flash.rodata 253192 253192 0 0.0
.flash.text 1214260 1214260 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1257015 1257015 0 0.0
(read/write) 537060 537060 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284896 284896 0 0.0
.flash.text 1250851 1250851 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2647317 2647317 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46728 46728 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 185392 185392 0 0.0
.text 2282933 2282933 0 0.0
all-clusters-app debug (read only) 5962073 5962073 0 0.0
(read/write) 481672 481672 0 0.0
.bss 135040 135040 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334632 334632 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 352208 352208 0 0.0
.text 5174723 5174723 0 0.0
all-clusters-minimal-app debug (read only) 5242049 5242049 0 0.0
(read/write) 237624 237624 0 0.0
.bss 127872 127872 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98216 98216 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290858 290858 0 0.0
.text 4714707 4714707 0 0.0
bridge-app debug (read only) 4634009 4634009 0 0.0
(read/write) 218536 218536 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87168 87168 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 231242 231242 0 0.0
.text 4180707 4180707 0 0.0
chip-tool debug (read only) 12084753 12084753 0 0.0
(read/write) 523104 523104 0 0.0
.bss 94744 94744 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451449 451449 0 0.0
.text 10924947 10924947 0 0.0
chip-tool-ipv6only arm64 (read only) 11403796 11403796 0 0.0
(read/write) 587408 587408 0 0.0
.bss 103720 103720 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356260 356260 0 0.0
.text 10165848 10165848 0 0.0
lighting-app debug+rpc+ui (read only) 5558057 5558057 0 0.0
(read/write) 227304 227304 0 0.0
.bss 119344 119344 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95536 95536 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 355124 355124 0 0.0
.text 4954483 4954483 0 0.0
lock-app debug (read only) 4699857 4699857 0 0.0
(read/write) 205760 205760 0 0.0
.bss 113704 113704 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81160 81160 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 257034 257034 0 0.0
.text 4229827 4229827 0 0.0
ota-provider-app debug (read only) 4310161 4310161 0 0.0
(read/write) 194200 194200 0 0.0
.bss 113440 113440 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209642 209642 0 0.0
.text 3906035 3906035 0 0.0
ota-requestor-app debug (read only) 4440993 4440993 0 0.0
(read/write) 198568 198568 0 0.0
.bss 114336 114336 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215914 215914 0 0.0
.text 4026051 4026051 0 0.0
shell debug (read only) 2929913 2929913 0 0.0
(read/write) 157040 157040 0 0.0
.bss 62512 62512 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87312 87312 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 188576 188576 0 0.0
.text 2566226 2566226 0 0.0
thermostat-no-ble arm64 (read only) 4433564 4433564 0 0.0
(read/write) 245936 245936 0 0.0
.bss 121976 121976 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104424 104424 0 0.0
.dynamic 512 512 0 0.0
.got 8728 8728 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160388 160388 0 0.0
.text 3936328 3936328 0 0.0
tv-app debug (read only) 5773513 5773513 0 0.0
(read/write) 353496 353496 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95320 95320 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295466 295466 0 0.0
.text 5234291 5234291 0 0.0
tv-casting-app debug (read only) 9898457 9898457 0 0.0
(read/write) 342720 342720 0 0.0
.bss 157976 157976 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174848 174848 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384760 384760 0 0.0
.text 9046819 9046819 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535696 2535696 0 0.0
.bss 220488 220488 0 0.0
.data 5216 5216 0 0.0
.text 1498380 1498380 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1065984 1065984 0 0.0
bss 133119 133119 0 0.0
rodata 103400 103400 0 0.0
text 782256 782256 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1226472 1226472 0 0.0
bss 127175 127175 0 0.0
rodata 151368 151368 0 0.0
text 797900 797900 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1013584 1013584 0 0.0
bss 131977 131977 0 0.0
rodata 90664 90664 0 0.0
text 743624 743624 0 0.0
nxp contact k32w0+release (read only) 575756 575756 0 0.0
(read/write) 80028 80028 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575220 575220 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703028 703028 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589584 589584 0 0.0
light k32w0+release (read only) 609776 609776 0 0.0
(read/write) 79488 79488 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609240 609240 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 794968 794968 0 0.0
.bss 80744 80744 0 0.0
.data 2064 2064 0 0.0
.text 672792 672792 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832272 832272 0 0.0
(read/write) 1804796 1804796 0 0.0
.bss 198380 198380 0 0.0
.data 2688 2688 0 0.0
.text 1595340 1595340 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835424 835424 0 0.0
(read/write) 1726700 1726700 0 0.0
.bss 195260 195260 0 0.0
.data 2656 2656 0 0.0
.text 1520396 1520396 0 0.0
light cy8ckit_062s2_43012 (read only) 842144 842144 0 0.0
(read/write) 1645420 1645420 0 0.0
.bss 188724 188724 0 0.0
.data 2472 2472 0 0.0
.text 1445836 1445836 0 0.0
lock cy8ckit_062s2_43012 (read only) 815072 815072 0 0.0
(read/write) 1674108 1674108 0 0.0
.bss 215804 215804 0 0.0
.data 2464 2464 0 0.0
.text 1447452 1447452 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133316 1133316 0 0.0
.bss 102588 102588 0 0.0
.data 856 856 0 0.0
.text 645696 645696 0 0.0
lock-app qpg6105+debug (read/write) 1093316 1093316 0 0.0
.bss 97260 97260 0 0.0
.data 860 860 0 0.0
.text 605700 605700 0 0.0
stm32 light STM32WB5MM-DK (read/write) 604921 604921 0 0.0
.bss 128444 128444 0 0.0
.data 688 688 0 0.0
.rodata 80516 80516 0 0.0
.text 385528 385528 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834086 834086 0 0.0
bss 49856 49856 0 0.0
text 624770 624770 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1097308 1097308 0 0.0
bss 101540 101540 0 0.0
text 798316 798316 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058772 1058772 0 0.0
bss 109988 109988 0 0.0
text 772678 772678 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914156 914156 0 0.0
bss 92744 92744 0 0.0
text 656024 656024 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836114 836114 0 0.0
bss 49900 49900 0 0.0
text 626876 626876 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 936908 936908 0 0.0
bss 77512 77512 0 0.0
text 703542 703542 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090668 1090668 0 0.0
bss 99836 99836 0 0.0
text 794132 794132 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911360 911360 0 0.0
bss 69180 69180 0 0.0
text 660408 660408 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933008 933008 0 0.0
bss 92448 92448 0 0.0
text 675066 675066 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833760 833760 0 0.0
bss 58144 58144 0 0.0
text 623972 623972 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799888 799888 0 0.0
bss 56072 56072 0 0.0
text 598878 598878 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676128 676128 0 0.0
bss 73424 73424 0 0.0
text 461864 461864 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843854 843854 0 0.0
bss 51528 51528 0 0.0
text 633418 633418 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858673 858673 0 0.0
bss 59696 59696 0 0.0
text 642362 642362 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825436 825436 0 0.0
bss 56404 56404 0 0.0
text 618434 618434 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838560 838560 0 0.0
bss 58360 58360 0 0.0
text 626342 626342 0 0.0

@mkardous-silabs mkardous-silabs merged commit fbe1835 into project-chip:master Apr 18, 2024
65 of 66 checks passed
@mkardous-silabs mkardous-silabs deleted the fix/build_typo branch April 24, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants