-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.3 Commissioner Passcode field for Linux and Android tv-casting-apps #33038
v1.3 Commissioner Passcode field for Linux and Android tv-casting-apps #33038
Conversation
PR #33038: Size comparison from 01facfd to a62b7fe Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp
Outdated
Show resolved
Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java
Outdated
Show resolved
Hide resolved
PR #33038: Size comparison from 01facfd to 33ffe7a Increases (2 builds for esp32, linux)
Decreases (4 builds for cyw30739, linux)
Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
examples/tv-casting-app/tv-casting-common/support/CastingStore.h
Outdated
Show resolved
Hide resolved
PR #33038: Size comparison from 01facfd to 78de299 Increases (4 builds for efr32, esp32, linux)
Decreases (4 builds for cyw30739, linux)
Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
78de299
to
358046b
Compare
PR #33038: Size comparison from 8a4dffc to 358046b Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My spec copy says "CommissionerPasscode" is a flag to instruct the commissioner to use the commissioner-generated passcode.
This seems to indicate we need some form of bool
rather than a uint8_t.
examples/tv-casting-app/tv-casting-common/support/CastingStore.h
Outdated
Show resolved
Hide resolved
PR #33038: Size comparison from 8a4dffc to cad954c Increases above 0.2%:
Increases (18 builds for esp32, linux, nxp)
Decreases (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33038: Size comparison from 8a4dffc to 1e6c5d0 Increases above 0.2%:
Increases (23 builds for cc13x4_26x4, esp32, linux, nxp)
Decreases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Exposed the new Matter v1.3 Commissioner Passcode (CP) field for discovered Casting Players for Linux and Android example tv-casting-apps.
Change summary
Testing
Verified and tested locally with the Linux and Android tv-casting-app example apps. The example apps discover CastingPlayers and display the Commissioner Passcode field for each discovered CastingPlayer in the terminal and Android mobile device tv-casting-app UX respectively.