-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Change BLE address from random resolvable address to random static address #33035
Merged
mergify
merged 3 commits into
project-chip:master
from
mkardous-silabs:fix/random_address
Apr 17, 2024
Merged
[Silabs] Change BLE address from random resolvable address to random static address #33035
mergify
merged 3 commits into
project-chip:master
from
mkardous-silabs:fix/random_address
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
April 17, 2024 20:16
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 17, 2024 20:16
yunhanw-google
approved these changes
Apr 17, 2024
PR #33035: Size comparison from 035d302 to 2f5f8bd Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
jmartinez-silabs
approved these changes
Apr 17, 2024
PR #33035: Size comparison from 035d302 to 2140254 Increases above 0.2%:
Increases (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (5 builds for linux, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
May 8, 2024
Merge in WMN_TOOLS/matter from feature/update_matter_support to RC_2.3.0-1.3 Squashed commit of the following: commit 3e0dd4c3076d244545844a7d330e4ec31e16b02b Author: Mathieu Kardous <[email protected]> Date: Mon Apr 29 12:33:53 2024 -0400 Update matter support pointer to main commit 5a170da155b4170c80d4d0ce2b1e8b254eeac7f2 Author: mkardous-silabs <[email protected]> Date: Wed Apr 17 18:25:20 2024 -0500 [Silabs] Change BLE address from random resolvable address to random static address (project-chip#33035) * Change BLE address from random resolvable address to static address * add comment * Replace lambda function with memcmp
rcasallas-silabs
pushed a commit
to rcasallas-silabs/connectedhomeip
that referenced
this pull request
Jun 20, 2024
Merge in WMN_TOOLS/matter from feature/update_matter_support to RC_2.3.0-1.3 Squashed commit of the following: commit 3e0dd4c3076d244545844a7d330e4ec31e16b02b Author: Mathieu Kardous <[email protected]> Date: Mon Apr 29 12:33:53 2024 -0400 Update matter support pointer to main commit 5a170da155b4170c80d4d0ce2b1e8b254eeac7f2 Author: mkardous-silabs <[email protected]> Date: Wed Apr 17 18:25:20 2024 -0500 [Silabs] Change BLE address from random resolvable address to random static address (project-chip#33035) * Change BLE address from random resolvable address to static address * add comment * Replace lambda function with memcmp
chirag-silabs
pushed a commit
to rosahay-silabs/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…static address (project-chip#33035) * Change BLE address from random resolvable address to static address * add comment * Replace lambda function with memcmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR changes the BLE address generation from a random resolvable address to a random static address. This allows us to remove the BLE SE manager which was only necessary for this step. This allows us to save a significant amount of flash while maintaining the Matter BLE security requirements.
Tests
Manual test to validate the new code flow