-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nl-unit-test with pigweed for platform #33030
Conversation
PR #33030: Size comparison from 294f29e to 589386d Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
c18fb1c
to
5b02c3c
Compare
PR #33030: Size comparison from 511c974 to 5b02c3c Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
OpenIOT seems to fail with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we maybe also need to update src/test_driver/openiotsdk/unit-tests/test_components_nl.txt
as we update tests?
5b02c3c
to
4e7c5df
Compare
Yes, You are right. I've uploaded the fix. |
PR #33030: Size comparison from 84fd7fc to 4e7c5df Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Problem
The problem was described in #29342.
Changes
These changes are another piece of replacing the nl-unit test with the pigweed-unit test. I changed tests for the platform. I didn't introduce any changes to the logic of tests; I only replaced one framework with another.