-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dnssd] Refactored DiscoveredNodeData definition and usage #33025
[Dnssd] Refactored DiscoveredNodeData definition and usage #33025
Conversation
PR #33025: Size comparison from 47c6d46 to 3b657f6 Increases above 0.2%:
Increases (35 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6)
Decreases (27 builds for bl702, bl702l, cc13x4_26x4, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32)
Full report (55 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
examples/tv-casting-app/tv-casting-common/core/CastingPlayerDiscovery.cpp
Outdated
Show resolved
Hide resolved
src/protocols/user_directed_commissioning/UserDirectedCommissioningServer.cpp
Outdated
Show resolved
Hide resolved
PR #33025: Size comparison from 47c6d46 to abad21a Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (10 builds for bl602, bl702, linux, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
abad21a
to
11bc775
Compare
PR #33025: Size comparison from 4f93a66 to 11bc775 Increases above 0.2%:
Increases (44 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (43 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
11bc775
to
205efb2
Compare
PR #33025: Size comparison from 80b2f61 to 205efb2 Increases above 0.2%:
Increases (44 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (43 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few more suggestions, but everything else looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for doing this! Approved, pending @Damian-Nordic's comments being addressed.
be6051d
to
a632edb
Compare
PR #33025: Size comparison from 67ac842 to a632edb Increases above 0.2%:
Increases (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (44 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
a632edb
to
97d10cc
Compare
PR #33025: Size comparison from 742e65b to 97d10cc Increases above 0.2%:
Increases (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (44 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…hip#33025) * Refactored DiscoveredNodeData definition and usage * Restyled by whitespace * Restyled by clang-format * updates based on review feedback * Restyled by whitespace * Restyled by clang-format * fix for build failure * Updates as per feedback * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
As part of mDNS browse interface clean up, updated
DiscoveredNodeData
definition to be a variant ofCommissionNodeData
. AlsoCommissionNodeData
inheritsCommonResolutionData
so that the delegate structured are flattened.Also all references/usage of these structures are updated accordingly.
This work is in continuation to the comments in #32866