Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Change BLE and logging configuration #3301

Merged

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Update BLE and logging configuration for nRF Connect platform/examples

Summary of Changes

  • use meaningful BLE Device names
  • 1 BLE connection at a time should be enough
  • don't print debug BLE messages to the console
  • btw, fix Service.cpp to use the right logger (app instead of serv)

@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
chip-shell.elf [LOAD #1 [RWX]] 6 6
chip-shell.elf [LOAD #2 [RW]] -2 -2
chip-shell.elf [LOAD #3 [RW]] 0 -4
chip-shell.elf datas -118 -118
chip-shell.elf noinit 0 -372
chip-shell.elf bss 0 -2620
chip-shell.elf rodata -14868 -14868
chip-shell.elf text -106886 -106886
chip-lock.elf [LOAD #1 [RWX]] 12 12
chip-lock.elf [LOAD #3 [RW]] 0 -4
chip-lock.elf [LOAD #2 [RW]] -6 -6
chip-lock.elf datas -90 -90
chip-lock.elf noinit 0 -372
chip-lock.elf bss 0 -2620
chip-lock.elf rodata -7132 -7132
chip-lock.elf text -79724 -79724
chip-lighting.elf [LOAD #1 [RWX]] 12 12
chip-lighting.elf [LOAD #3 [RW]] 0 -4
chip-lighting.elf [LOAD #2 [RW]] -6 -6
chip-lighting.elf datas -90 -90
chip-lighting.elf noinit 0 -372
chip-lighting.elf bss 0 -2620
chip-lighting.elf rodata -7132 -7132
chip-lighting.elf text -79724 -79724
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[LOAD #1 [RWX]],6,6
[LOAD #2 [RW]],-2,-2
[LOAD #3 [RW]],-4,0
datas,-118,-118
noinit,-372,0
bss,-2620,0
.debug_aranges,0,-3936
.debug_frame,0,-12764
.debug_ranges,0,-13664
rodata,-14868,-14868
.strtab,0,-17378
.symtab,0,-28000
.debug_str,0,-32086
.debug_abbrev,0,-37334
text,-106886,-106886
.debug_line,0,-128474
.debug_loc,0,-150529
.debug_info,0,-1730303

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
[LOAD #1 [RWX]],12,12
[Unmapped],0,-1
[LOAD #3 [RW]],-4,0
[LOAD #2 [RW]],-6,-6
datas,-90,-90
noinit,-372,0
bss,-2620,0
.debug_aranges,0,-3504
rodata,-7132,-7132
.debug_frame,0,-11084
.debug_ranges,0,-12472
.strtab,0,-13832
.symtab,0,-21264
.debug_str,0,-29219
.debug_abbrev,0,-35769
text,-79724,-79724
.debug_line,0,-112566
.debug_loc,0,-126565
.debug_info,0,-1708536

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
[LOAD #1 [RWX]],12,12
[LOAD #3 [RW]],-4,0
[LOAD #2 [RW]],-6,-6
[Unmapped],0,-9
datas,-90,-90
noinit,-372,0
bss,-2620,0
.debug_aranges,0,-3504
rodata,-7132,-7132
.debug_frame,0,-11084
.debug_ranges,0,-12472
.strtab,0,-13832
.symtab,0,-21264
.debug_str,0,-29219
.debug_abbrev,0,-35769
text,-79724,-79724
.debug_line,0,-112566
.debug_loc,0,-126565
.debug_info,0,-1708536


@rwalker-apple
Copy link
Contributor

@BroderickCarlin BroderickCarlin merged commit 6e56b41 into project-chip:master Oct 26, 2020
@Damian-Nordic Damian-Nordic deleted the feature/ble-config branch October 28, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants