Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeviceControllerFactory: Add InitAndRetainSystemState #32998

Merged
merged 2 commits into from
Apr 17, 2024
Merged

DeviceControllerFactory: Add InitAndRetainSystemState #32998

merged 2 commits into from
Apr 17, 2024

Conversation

ksperling-apple
Copy link
Contributor

This does a RetainSystemState, but re-initializes if necessary.

Also rename no-arg InitSystemState() to ReinitSystemStateIfNecessary() and check for the case where no work is necessary before creating the FactoryInitParams and calling InitSystemState(params).

This means InitSystemState(params) doesn't have to handle that case anymore since it's only called from Init() or after ReinitSystemStateIfNecessary() has already done the check.

@ksperling-apple
DeviceControllerFactory: Add InitAndRetainSystemState
73fbfc3 
This does a RetainSystemState, but re-initializes if necessary.

Also rename no-arg InitSystemState() to ReinitSystemStateIfNecessary() and
check for the case where no work is necessary before creating the
FactoryInitParams and calling InitSystemState(params).

This means InitSystemState(params) doesn't have to handle that case anymore
since it's only called from Init() or after ReinitSystemStateIfNecessary() has
already done the check.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

PR #32998: Size comparison from 4aadee7 to 73fbfc3

Increases (1 build for linux)
platform target config section 4aadee7 73fbfc3 change % change
linux chip-tool-ipv6only arm64 (read/write) 587232 587264 32 0.0
Decreases (4 builds for efr32, linux)
platform target config section 4aadee7 73fbfc3 change % change
efr32 lock-app BRD4338a (read/write) 959908 959900 -8 -0.0
.text 700048 700040 -8 -0.0
linux chip-tool debug (read only) 12084641 12084593 -48 -0.0
.text 10924835 10924787 -48 -0.0
chip-tool-ipv6only arm64 (read only) 11403972 11403940 -32 -0.0
.text 10166024 10165992 -32 -0.0
tv-app debug (read only) 5766793 5766745 -48 -0.0
.text 5228739 5228691 -48 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 4aadee7 73fbfc3 change % change
bl602 lighting-app bl602 (read/write) 1442810 1442810 0 0.0
.bss 85440 85440 0 0.0
.data 9504 9504 0 0.0
.rodata 159068 159068 0 0.0
.text 1108142 1108142 0 0.0
bl602+mfd (read/write) 1457234 1457234 0 0.0
.bss 85608 85608 0 0.0
.data 9480 9480 0 0.0
.rodata 158028 158028 0 0.0
.text 1123460 1123460 0 0.0
bl602+rpc (read/write) 1490466 1490466 0 0.0
.bss 93480 93480 0 0.0
.data 9880 9880 0 0.0
.rodata 166644 166644 0 0.0
.text 1139788 1139788 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1207671 1207671 0 0.0
.bss 11185 11185 0 0.0
.data 3696 3696 0 0.0
.rodata 108432 108432 0 0.0
.text 977442 977442 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1218483 1218483 0 0.0
.bss 11361 11361 0 0.0
.data 3672 3672 0 0.0
.rodata 107372 107372 0 0.0
.text 989196 989196 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1299407 1299407 0 0.0
.bss 19669 19669 0 0.0
.data 4232 4232 0 0.0
.rodata 123804 123804 0 0.0
.text 1052406 1052406 0 0.0
bl706-eth (read/write) 1024937 1024937 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101756 101756 0 0.0
.text 768146 768146 0 0.0
bl706-wifi (read/write) 1259602 1259602 0 0.0
.bss 10645 10645 0 0.0
.data 3696 3696 0 0.0
.rodata 122756 122756 0 0.0
.text 1000036 1000036 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1177012 1177012 0 0.0
.bss 16396 16396 0 0.0
.data 5056 5056 0 0.0
.rodata 102436 102436 0 0.0
.text 970308 970308 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1188420 1188420 0 0.0
.bss 16572 16572 0 0.0
.data 5040 5040 0 0.0
.rodata 101376 101376 0 0.0
.text 982630 982630 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782668 782668 0 0.0
(read/write) 171632 171632 0 0.0
.bss 93588 93588 0 0.0
.data 3584 3584 0 0.0
.rodata 82628 82628 0 0.0
.text 699776 699776 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798652 798652 0 0.0
(read/write) 182104 182104 0 0.0
.bss 104076 104076 0 0.0
.data 3576 3576 0 0.0
.rodata 76716 76716 0 0.0
.text 721672 721672 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787420 787420 0 0.0
(read/write) 176224 176224 0 0.0
.bss 98196 98196 0 0.0
.data 3576 3576 0 0.0
.rodata 103532 103532 0 0.0
.text 683624 683624 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739732 739732 0 0.0
(read/write) 170592 170592 0 0.0
.bss 92328 92328 0 0.0
.data 3568 3568 0 0.0
.rodata 78292 78292 0 0.0
.text 661176 661176 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 725364 725364 0 0.0
(read/write) 170816 170816 0 0.0
.bss 92552 92552 0 0.0
.data 3568 3568 0 0.0
.rodata 74068 74068 0 0.0
.text 651032 651032 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586646 586646 0 0.0
(read/write) 208088 208088 0 0.0
.bss 201316 201316 0 0.0
.data 1648 1648 0 0.0
.rodata 87502 87502 0 0.0
.text 497020 497020 0 0.0
lock CC3235SF_LAUNCHXL (read only) 631454 631454 0 0.0
(read/write) 208344 208344 0 0.0
.bss 201720 201720 0 0.0
.data 1504 1504 0 0.0
.rodata 107854 107854 0 0.0
.text 521480 521480 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569655 569655 0 0.0
.app_xip_area 459589 459589 0 0.0
.bss 64892 64892 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551863 551863 0 0.0
.app_xip_area 437125 437125 0 0.0
.bss 69556 69556 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572967 572967 0 0.0
.app_xip_area 464397 464397 0 0.0
.bss 63436 63436 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564927 564927 0 0.0
.app_xip_area 453173 453173 0 0.0
.bss 66540 66540 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1068344 1068344 0 0.0
.bss 179896 179896 0 0.0
.data 3424 3424 0 0.0
.text 885004 885004 0 0.0
lock-app BRD4338a (read/write) 959908 959900 -8 -0.0
.bss 210220 210220 0 0.0
.data 30272 30272 0 0.0
.text 700048 700040 -8 -0.0
window-app BRD4187C (read/write) 1134084 1134084 0 0.0
.bss 164496 164496 0 0.0
.data 3328 3328 0 0.0
.text 966240 966240 0 0.0
esp32 all-clusters-app c3devkit (read only) 1213416 1213416 0 0.0
(read/write) 1750224 1750224 0 0.0
.dram0.bss 74320 74320 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252752 252752 0 0.0
.flash.text 1213416 1213416 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1256059 1256059 0 0.0
(read/write) 536532 536532 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284368 284368 0 0.0
.flash.text 1249895 1249895 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2645941 2645941 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46728 46728 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 185392 185392 0 0.0
.text 2281557 2281557 0 0.0
all-clusters-app debug (read only) 5955601 5955601 0 0.0
(read/write) 481512 481512 0 0.0
.bss 135040 135040 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334472 334472 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 351760 351760 0 0.0
.text 5169059 5169059 0 0.0
all-clusters-minimal-app debug (read only) 5235545 5235545 0 0.0
(read/write) 237464 237464 0 0.0
.bss 127872 127872 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98056 98056 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290410 290410 0 0.0
.text 4709011 4709011 0 0.0
bridge-app debug (read only) 4628561 4628561 0 0.0
(read/write) 218344 218344 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86976 86976 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230794 230794 0 0.0
.text 4176067 4176067 0 0.0
chip-tool debug (read only) 12084641 12084593 -48 -0.0
(read/write) 523104 523104 0 0.0
.bss 94744 94744 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451449 451449 0 0.0
.text 10924835 10924787 -48 -0.0
chip-tool-ipv6only arm64 (read only) 11403972 11403940 -32 -0.0
(read/write) 587232 587264 32 0.0
.bss 103720 103720 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356260 356260 0 0.0
.text 10166024 10165992 -32 -0.0
lighting-app debug+rpc+ui (read only) 5551473 5551473 0 0.0
(read/write) 227112 227112 0 0.0
.bss 119344 119344 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 95376 95376 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354676 354676 0 0.0
.text 4948707 4948707 0 0.0
lock-app debug (read only) 4693305 4693305 0 0.0
(read/write) 205568 205568 0 0.0
.bss 113704 113704 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 81000 81000 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 256586 256586 0 0.0
.text 4224083 4224083 0 0.0
ota-provider-app debug (read only) 4309905 4309905 0 0.0
(read/write) 194200 194200 0 0.0
.bss 113440 113440 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209642 209642 0 0.0
.text 3905779 3905779 0 0.0
ota-requestor-app debug (read only) 4439569 4439569 0 0.0
(read/write) 198568 198568 0 0.0
.bss 114336 114336 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215914 215914 0 0.0
.text 4024627 4024627 0 0.0
shell debug (read only) 2922121 2922121 0 0.0
(read/write) 156880 156880 0 0.0
.bss 62512 62512 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87152 87152 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 187872 187872 0 0.0
.text 2559570 2559570 0 0.0
thermostat-no-ble arm64 (read only) 4428172 4428172 0 0.0
(read/write) 243152 243152 0 0.0
.bss 121976 121976 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 104296 104296 0 0.0
.dynamic 512 512 0 0.0
.got 8712 8712 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160148 160148 0 0.0
.text 3931480 3931480 0 0.0
tv-app debug (read only) 5766793 5766745 -48 -0.0
(read/write) 353336 353336 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95160 95160 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 294730 294730 0 0.0
.text 5228739 5228691 -48 -0.0
tv-casting-app debug (read only) 9896849 9896849 0 0.0
(read/write) 342720 342720 0 0.0
.bss 157976 157976 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174848 174848 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384472 384472 0 0.0
.text 9045571 9045571 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2534624 2534624 0 0.0
.bss 220480 220480 0 0.0
.data 5216 5216 0 0.0
.text 1497308 1497308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1064780 1064780 0 0.0
bss 133107 133107 0 0.0
rodata 103052 103052 0 0.0
text 781408 781408 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1225560 1225560 0 0.0
bss 127163 127163 0 0.0
rodata 151300 151300 0 0.0
text 797068 797068 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1012260 1012260 0 0.0
bss 131965 131965 0 0.0
rodata 90316 90316 0 0.0
text 742776 742776 0 0.0
nxp contact k32w0+release (read only) 574972 574972 0 0.0
(read/write) 80004 80004 0 0.0
.bss 67840 67840 0 0.0
.data 2180 2180 0 0.0
.text 574436 574436 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 702108 702108 0 0.0
.bss 71184 71184 0 0.0
.data 2856 2856 0 0.0
.text 588688 588688 0 0.0
light k32w0+release (read only) 608912 608912 0 0.0
(read/write) 79464 79464 0 0.0
.bss 67280 67280 0 0.0
.data 2200 2200 0 0.0
.text 608376 608376 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 793848 793848 0 0.0
.bss 80728 80728 0 0.0
.data 2056 2056 0 0.0
.text 671696 671696 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832288 832288 0 0.0
(read/write) 1803100 1803100 0 0.0
.bss 198364 198364 0 0.0
.data 2688 2688 0 0.0
.text 1593660 1593660 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835440 835440 0 0.0
(read/write) 1725004 1725004 0 0.0
.bss 195244 195244 0 0.0
.data 2656 2656 0 0.0
.text 1518716 1518716 0 0.0
light cy8ckit_062s2_43012 (read only) 842168 842168 0 0.0
(read/write) 1643716 1643716 0 0.0
.bss 188708 188708 0 0.0
.data 2464 2464 0 0.0
.text 1444156 1444156 0 0.0
lock cy8ckit_062s2_43012 (read only) 815096 815096 0 0.0
(read/write) 1672420 1672420 0 0.0
.bss 215788 215788 0 0.0
.data 2456 2456 0 0.0
.text 1445788 1445788 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1132224 1132224 0 0.0
.bss 102572 102572 0 0.0
.data 844 844 0 0.0
.text 644608 644608 0 0.0
lock-app qpg6105+debug (read/write) 1092264 1092264 0 0.0
.bss 97244 97244 0 0.0
.data 856 856 0 0.0
.text 604644 604644 0 0.0
stm32 light STM32WB5MM-DK (read/write) 603813 603813 0 0.0
.bss 128428 128428 0 0.0
.data 676 676 0 0.0
.rodata 80212 80212 0 0.0
.text 384752 384752 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832946 832946 0 0.0
bss 49836 49836 0 0.0
text 623976 623976 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096176 1096176 0 0.0
bss 101520 101520 0 0.0
text 797524 797524 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1057632 1057632 0 0.0
bss 109968 109968 0 0.0
text 771882 771882 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 913120 913120 0 0.0
bss 92724 92724 0 0.0
text 655324 655324 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834990 834990 0 0.0
bss 49880 49880 0 0.0
text 626082 626082 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 935768 935768 0 0.0
bss 77492 77492 0 0.0
text 702744 702744 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1089544 1089544 0 0.0
bss 99816 99816 0 0.0
text 793340 793340 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 910220 910220 0 0.0
bss 69160 69160 0 0.0
text 659610 659610 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932812 932812 0 0.0
bss 92428 92428 0 0.0
text 674892 674892 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 832636 832636 0 0.0
bss 58124 58124 0 0.0
text 623178 623178 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 798756 798756 0 0.0
bss 56052 56052 0 0.0
text 598084 598084 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676016 676016 0 0.0
bss 73412 73412 0 0.0
text 461764 461764 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 842714 842714 0 0.0
bss 51508 51508 0 0.0
text 632620 632620 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858477 858477 0 0.0
bss 59676 59676 0 0.0
text 642186 642186 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 824304 824304 0 0.0
bss 56384 56384 0 0.0
text 617636 617636 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 837420 837420 0 0.0
bss 58340 58340 0 0.0
text 625544 625544 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

PR #32998: Size comparison from 4aadee7 to 53795d3

Increases above 0.2%:

platform target config section 4aadee7 53795d3 change % change
linux thermostat-no-ble arm64 (read/write) 243152 246160 3008 1.2
Increases (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 4aadee7 53795d3 change % change
bl602 lighting-app bl602 (read/write) 1442810 1443066 256 0.0
.bss 85440 85448 8 0.0
.text 1108142 1108384 242 0.0
bl602+mfd (read/write) 1457234 1457490 256 0.0
.bss 85608 85616 8 0.0
.text 1123460 1123702 242 0.0
bl602+rpc .bss 93480 93488 8 0.0
bl702 lighting-app bl702 (read/write) 1207671 1207927 256 0.0
.text 977442 977684 242 0.0
bl702+mfd (read/write) 1218483 1218743 260 0.0
.text 989196 989438 242 0.0
bl706-eth (read/write) 1024937 1025193 256 0.0
.text 768146 768388 242 0.0
bl706-wifi (read/write) 1259602 1259846 244 0.0
.text 1000036 1000280 244 0.0
bl702l lighting-app bl702l (read/write) 1177012 1177784 772 0.1
.text 970308 970550 242 0.0
bl702l+mfd (read/write) 1188420 1188676 256 0.0
.text 982630 982872 242 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782668 782820 152 0.0
(read/write) 171632 171640 8 0.0
.bss 93588 93596 8 0.0
.text 699776 699928 152 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798652 798804 152 0.0
(read/write) 182104 182112 8 0.0
.bss 104076 104084 8 0.0
.text 721672 721820 148 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787420 787572 152 0.0
(read/write) 176224 176232 8 0.0
.bss 98196 98204 8 0.0
.text 683624 683776 152 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739732 739884 152 0.0
(read/write) 170592 170600 8 0.0
.bss 92328 92336 8 0.0
.text 661176 661328 152 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 725364 725516 152 0.0
(read/write) 170816 170824 8 0.0
.bss 92552 92560 8 0.0
.text 651032 651184 152 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586646 586950 304 0.1
(read/write) 208088 208096 8 0.0
.bss 201316 201324 8 0.0
.text 497020 497324 304 0.1
lock CC3235SF_LAUNCHXL (read only) 631454 631766 312 0.0
(read/write) 208344 208352 8 0.0
.bss 201720 201728 8 0.0
.text 521480 521792 312 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 569655 569783 128 0.0
.app_xip_area 459589 459709 120 0.0
.bss 64892 64900 8 0.0
lock cyw930739m2evb_01 (read/write) 551863 551999 136 0.0
.app_xip_area 437125 437253 128 0.0
.bss 69556 69564 8 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572967 573111 144 0.0
.app_xip_area 464397 464533 136 0.0
.bss 63436 63444 8 0.0
switch cyw930739m2evb_01 (read/write) 564927 565063 136 0.0
.app_xip_area 453173 453301 128 0.0
.bss 66540 66548 8 0.0
efr32 lighting-app BRD4187C (read/write) 1068344 1068480 136 0.0
.bss 179896 179904 8 0.0
.text 885004 885132 128 0.0
lock-app BRD4338a (read/write) 959908 960724 816 0.1
.bss 210220 210236 16 0.0
.text 700048 700848 800 0.1
window-app BRD4187C (read/write) 1134084 1134380 296 0.0
.bss 164496 164504 8 0.0
.text 966240 966528 288 0.0
esp32 all-clusters-app c3devkit (read only) 1213416 1213674 258 0.0
(read/write) 1750224 1750368 144 0.0
.dram0.bss 74320 74328 8 0.0
.flash.rodata 252752 252880 128 0.1
.flash.text 1213416 1213674 258 0.0
m5stack (read only) 1256059 1256271 212 0.0
(read/write) 536532 536652 120 0.0
.flash.rodata 284368 284488 120 0.0
.flash.text 1249895 1250107 212 0.0
linux chip-tool-ipv6only arm64 (read/write) 587232 587264 32 0.0
thermostat-no-ble arm64 (read only) 4428172 4429260 1088 0.0
(read/write) 243152 246160 3008 1.2
.text 3931480 3932568 1088 0.0
mbed lock-app-release cy8cproto_062_4343w (read/write) 2534624 2534816 192 0.0
.bss 220480 220488 8 0.0
.text 1497308 1497500 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1064780 1065016 236 0.0
rodata 103052 103096 44 0.0
text 781408 781600 192 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1225560 1225908 348 0.0
bss 127163 127171 8 0.0
rodata 151300 151304 4 0.0
text 797068 797400 332 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1012260 1012496 236 0.0
rodata 90316 90360 44 0.0
text 742776 742968 192 0.0
nxp contact k32w0+release (read only) 574972 575100 128 0.0
(read/write) 80004 80012 8 0.0
.bss 67840 67848 8 0.0
.text 574436 574564 128 0.0
k32w1+release (read/write) 702108 702220 112 0.0
.bss 71184 71192 8 0.0
.text 588688 588792 104 0.0
light k32w0+release (read only) 608912 609040 128 0.0
(read/write) 79464 79472 8 0.0
.bss 67280 67288 8 0.0
.text 608376 608504 128 0.0
k32w1+release (read/write) 793848 793992 144 0.0
.bss 80728 80736 8 0.0
.text 671696 671832 136 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1803100 1803444 344 0.0
.bss 198364 198372 8 0.0
.text 1593660 1593996 336 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1725004 1725332 328 0.0
.bss 195244 195252 8 0.0
.text 1518716 1519036 320 0.0
light cy8ckit_062s2_43012 (read/write) 1643716 1644060 344 0.0
.bss 188708 188716 8 0.0
.text 1444156 1444492 336 0.0
lock cy8ckit_062s2_43012 (read/write) 1672420 1672748 328 0.0
.bss 215788 215796 8 0.0
.text 1445788 1446108 320 0.0
qpg lighting-app qpg6105+debug (read/write) 1132224 1132360 136 0.0
.bss 102572 102580 8 0.0
.text 644608 644744 136 0.0
lock-app qpg6105+debug (read/write) 1092264 1092360 96 0.0
.bss 97244 97252 8 0.0
.text 604644 604740 96 0.0
stm32 light STM32WB5MM-DK (read/write) 603813 603949 136 0.0
.bss 128428 128436 8 0.0
.text 384752 384880 128 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 832946 833042 96 0.0
bss 49836 49844 8 0.0
text 623976 624058 82 0.0
all-clusters-app tlsr9518adk80d (read/write) 1096176 1096264 88 0.0
bss 101520 101528 8 0.0
text 797524 797604 80 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1057632 1057728 96 0.0
bss 109968 109976 8 0.0
text 771882 771966 84 0.0
bridge-app tlsr9518adk80d bss 92724 92732 8 0.0
contact-sensor-app tlsr9528a_retention (read/write) 834990 835078 88 0.0
bss 49880 49888 8 0.0
text 626082 626164 82 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 935768 935864 96 0.0
bss 77492 77500 8 0.0
text 702744 702830 86 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1089544 1089632 88 0.0
bss 99816 99824 8 0.0
text 793340 793420 80 0.0
lock-app-dfu tlsr9528a (read/write) 910220 910316 96 0.0
bss 69160 69168 8 0.0
text 659610 659696 86 0.0
ota-requestor-app tlsr9518adk80d (read/write) 932812 932900 88 0.0
bss 92428 92436 8 0.0
text 674892 674972 80 0.0
pump-app tlsr9258a (read/write) 832636 832724 88 0.0
bss 58124 58132 8 0.0
text 623178 623260 82 0.0
pump-controller-app tlsr9518adk80d (read/write) 798756 798852 96 0.0
bss 56052 56060 8 0.0
text 598084 598166 82 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 842714 842810 96 0.0
bss 51508 51516 8 0.0
text 632620 632706 86 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 858477 858565 88 0.0
bss 59676 59684 8 0.0
text 642186 642268 82 0.0
thermostat tlsr9518adk80d (read/write) 824304 824400 96 0.0
bss 56384 56392 8 0.0
text 617636 617722 86 0.0
window-covering tlsr9258a (read/write) 837420 837516 96 0.0
bss 58340 58348 8 0.0
text 625544 625630 86 0.0
Decreases (8 builds for bl602, bl702, linux, psoc6, telink)
platform target config section 4aadee7 53795d3 change % change
bl602 lighting-app bl602+rpc .text 1139788 1139774 -14 -0.0
bl702 lighting-app bl702+rpc .text 1052406 1052392 -14 -0.0
linux chip-tool-ipv6only arm64 (read only) 11403972 11403940 -32 -0.0
.text 10166024 10165992 -32 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832288 832280 -8 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835440 835432 -8 -0.0
light cy8ckit_062s2_43012 (read only) 842168 842160 -8 -0.0
lock cy8ckit_062s2_43012 (read only) 815096 815088 -8 -0.0
telink bridge-app tlsr9518adk80d text 655324 655312 -12 -0.0
Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 4aadee7 53795d3 change % change
bl602 lighting-app bl602 (read/write) 1442810 1443066 256 0.0
.bss 85440 85448 8 0.0
.data 9504 9504 0 0.0
.rodata 159068 159068 0 0.0
.text 1108142 1108384 242 0.0
bl602+mfd (read/write) 1457234 1457490 256 0.0
.bss 85608 85616 8 0.0
.data 9480 9480 0 0.0
.rodata 158028 158028 0 0.0
.text 1123460 1123702 242 0.0
bl602+rpc (read/write) 1490466 1490466 0 0.0
.bss 93480 93488 8 0.0
.data 9880 9880 0 0.0
.rodata 166644 166644 0 0.0
.text 1139788 1139774 -14 -0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1207671 1207927 256 0.0
.bss 11185 11185 0 0.0
.data 3696 3696 0 0.0
.rodata 108432 108432 0 0.0
.text 977442 977684 242 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1218483 1218743 260 0.0
.bss 11361 11361 0 0.0
.data 3672 3672 0 0.0
.rodata 107372 107372 0 0.0
.text 989196 989438 242 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1299407 1299407 0 0.0
.bss 19669 19669 0 0.0
.data 4232 4232 0 0.0
.rodata 123804 123804 0 0.0
.text 1052406 1052392 -14 -0.0
bl706-eth (read/write) 1024937 1025193 256 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101756 101756 0 0.0
.text 768146 768388 242 0.0
bl706-wifi (read/write) 1259602 1259846 244 0.0
.bss 10645 10645 0 0.0
.data 3696 3696 0 0.0
.rodata 122756 122756 0 0.0
.text 1000036 1000280 244 0.0
bl702l lighting-app bl702l (read/write) 1177012 1177784 772 0.1
.bss 16396 16396 0 0.0
.data 5056 5056 0 0.0
.rodata 102436 102436 0 0.0
.text 970308 970550 242 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1188420 1188676 256 0.0
.bss 16572 16572 0 0.0
.data 5040 5040 0 0.0
.rodata 101376 101376 0 0.0
.text 982630 982872 242 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782668 782820 152 0.0
(read/write) 171632 171640 8 0.0
.bss 93588 93596 8 0.0
.data 3584 3584 0 0.0
.rodata 82628 82628 0 0.0
.text 699776 699928 152 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798652 798804 152 0.0
(read/write) 182104 182112 8 0.0
.bss 104076 104084 8 0.0
.data 3576 3576 0 0.0
.rodata 76716 76716 0 0.0
.text 721672 721820 148 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787420 787572 152 0.0
(read/write) 176224 176232 8 0.0
.bss 98196 98204 8 0.0
.data 3576 3576 0 0.0
.rodata 103532 103532 0 0.0
.text 683624 683776 152 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739732 739884 152 0.0
(read/write) 170592 170600 8 0.0
.bss 92328 92336 8 0.0
.data 3568 3568 0 0.0
.rodata 78292 78292 0 0.0
.text 661176 661328 152 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 725364 725516 152 0.0
(read/write) 170816 170824 8 0.0
.bss 92552 92560 8 0.0
.data 3568 3568 0 0.0
.rodata 74068 74068 0 0.0
.text 651032 651184 152 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586646 586950 304 0.1
(read/write) 208088 208096 8 0.0
.bss 201316 201324 8 0.0
.data 1648 1648 0 0.0
.rodata 87502 87502 0 0.0
.text 497020 497324 304 0.1
lock CC3235SF_LAUNCHXL (read only) 631454 631766 312 0.0
(read/write) 208344 208352 8 0.0
.bss 201720 201728 8 0.0
.data 1504 1504 0 0.0
.rodata 107854 107854 0 0.0
.text 521480 521792 312 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 569655 569783 128 0.0
.app_xip_area 459589 459709 120 0.0
.bss 64892 64900 8 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551863 551999 136 0.0
.app_xip_area 437125 437253 128 0.0
.bss 69556 69564 8 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572967 573111 144 0.0
.app_xip_area 464397 464533 136 0.0
.bss 63436 63444 8 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564927 565063 136 0.0
.app_xip_area 453173 453301 128 0.0
.bss 66540 66548 8 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1068344 1068480 136 0.0
.bss 179896 179904 8 0.0
.data 3424 3424 0 0.0
.text 885004 885132 128 0.0
lock-app BRD4338a (read/write) 959908 960724 816 0.1
.bss 210220 210236 16 0.0
.data 30272 30272 0 0.0
.text 700048 700848 800 0.1
window-app BRD4187C (read/write) 1134084 1134380 296 0.0
.bss 164496 164504 8 0.0
.data 3328 3328 0 0.0
.text 966240 966528 288 0.0
esp32 all-clusters-app c3devkit (read only) 1213416 1213674 258 0.0
(read/write) 1750224 1750368 144 0.0
.dram0.bss 74320 74328 8 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252752 252880 128 0.1
.flash.text 1213416 1213674 258 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1256059 1256271 212 0.0
(read/write) 536532 536652 120 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284368 284488 120 0.0
.flash.text 1249895 1250107 212 0.0
.iram0.text 125403 125403 0 0.0
linux chip-tool-ipv6only arm64 (read only) 11403972 11403940 -32 -0.0
(read/write) 587232 587264 32 0.0
.bss 103720 103720 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356260 356260 0 0.0
.text 10166024 10165992 -32 -0.0
thermostat-no-ble arm64 (read only) 4428172 4429260 1088 0.0
(read/write) 243152 246160 3008 1.2
.bss 121976 121976 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 104296 104296 0 0.0
.dynamic 512 512 0 0.0
.got 8712 8712 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160148 160148 0 0.0
.text 3931480 3932568 1088 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2534624 2534816 192 0.0
.bss 220480 220488 8 0.0
.data 5216 5216 0 0.0
.text 1497308 1497500 192 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1064780 1065016 236 0.0
bss 133107 133107 0 0.0
rodata 103052 103096 44 0.0
text 781408 781600 192 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1225560 1225908 348 0.0
bss 127163 127171 8 0.0
rodata 151300 151304 4 0.0
text 797068 797400 332 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1012260 1012496 236 0.0
bss 131965 131965 0 0.0
rodata 90316 90360 44 0.0
text 742776 742968 192 0.0
nxp contact k32w0+release (read only) 574972 575100 128 0.0
(read/write) 80004 80012 8 0.0
.bss 67840 67848 8 0.0
.data 2180 2180 0 0.0
.text 574436 574564 128 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 702108 702220 112 0.0
.bss 71184 71192 8 0.0
.data 2856 2856 0 0.0
.text 588688 588792 104 0.0
light k32w0+release (read only) 608912 609040 128 0.0
(read/write) 79464 79472 8 0.0
.bss 67280 67288 8 0.0
.data 2200 2200 0 0.0
.text 608376 608504 128 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 793848 793992 144 0.0
.bss 80728 80736 8 0.0
.data 2056 2056 0 0.0
.text 671696 671832 136 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832288 832280 -8 -0.0
(read/write) 1803100 1803444 344 0.0
.bss 198364 198372 8 0.0
.data 2688 2688 0 0.0
.text 1593660 1593996 336 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835440 835432 -8 -0.0
(read/write) 1725004 1725332 328 0.0
.bss 195244 195252 8 0.0
.data 2656 2656 0 0.0
.text 1518716 1519036 320 0.0
light cy8ckit_062s2_43012 (read only) 842168 842160 -8 -0.0
(read/write) 1643716 1644060 344 0.0
.bss 188708 188716 8 0.0
.data 2464 2464 0 0.0
.text 1444156 1444492 336 0.0
lock cy8ckit_062s2_43012 (read only) 815096 815088 -8 -0.0
(read/write) 1672420 1672748 328 0.0
.bss 215788 215796 8 0.0
.data 2456 2456 0 0.0
.text 1445788 1446108 320 0.0
qpg lighting-app qpg6105+debug (read/write) 1132224 1132360 136 0.0
.bss 102572 102580 8 0.0
.data 844 844 0 0.0
.text 644608 644744 136 0.0
lock-app qpg6105+debug (read/write) 1092264 1092360 96 0.0
.bss 97244 97252 8 0.0
.data 856 856 0 0.0
.text 604644 604740 96 0.0
stm32 light STM32WB5MM-DK (read/write) 603813 603949 136 0.0
.bss 128428 128436 8 0.0
.data 676 676 0 0.0
.rodata 80212 80212 0 0.0
.text 384752 384880 128 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832946 833042 96 0.0
bss 49836 49844 8 0.0
text 623976 624058 82 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096176 1096264 88 0.0
bss 101520 101528 8 0.0
text 797524 797604 80 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1057632 1057728 96 0.0
bss 109968 109976 8 0.0
text 771882 771966 84 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 913120 913120 0 0.0
bss 92724 92732 8 0.0
text 655324 655312 -12 -0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834990 835078 88 0.0
bss 49880 49888 8 0.0
text 626082 626164 82 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 935768 935864 96 0.0
bss 77492 77500 8 0.0
text 702744 702830 86 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1089544 1089632 88 0.0
bss 99816 99824 8 0.0
text 793340 793420 80 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 910220 910316 96 0.0
bss 69160 69168 8 0.0
text 659610 659696 86 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932812 932900 88 0.0
bss 92428 92436 8 0.0
text 674892 674972 80 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 832636 832724 88 0.0
bss 58124 58132 8 0.0
text 623178 623260 82 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 798756 798852 96 0.0
bss 56052 56060 8 0.0
text 598084 598166 82 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676016 676016 0 0.0
bss 73412 73412 0 0.0
text 461764 461764 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 842714 842810 96 0.0
bss 51508 51516 8 0.0
text 632620 632706 86 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858477 858565 88 0.0
bss 59676 59684 8 0.0
text 642186 642268 82 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 824304 824400 96 0.0
bss 56384 56392 8 0.0
text 617636 617722 86 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 837420 837516 96 0.0
bss 58340 58348 8 0.0
text 625544 625630 86 0.0

@mergify mergify bot merged commit c6fbf7c into project-chip:master Apr 17, 2024
65 checks passed
@ksperling-apple ksperling-apple deleted the dcf-init-and-retain branch April 18, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksperling-apple @saurabhst @bzbarsky-apple @jmartinez-silabs