Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] Add adv change event to the silabs platforms #32987

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

mkardous-silabs
Copy link
Contributor

Description

PR adds the support for the kCHIPoBLEAdvertisingChange to the silabs platform.

  • Event is published when we start and stop advertising. Restarting when we are already advertising does not publish the event.
  • Add the event to the EFR32 BleManager
  • Add the event to the RS91x Ble Manater

Tests

  • Manual test to make sure the device posts the event when it is booted when uncommissionned - Start event
  • Manual test to make sure the device posts the event when commissionning starts - Stop event
  • Manual test to make sure the device posts the event when Ble Adv time out is triggered - Stop event

Copy link

github-actions bot commented Apr 15, 2024

PR #32987: Size comparison from ef44226 to d23bb63

Increases (2 builds for efr32)
platform target config section ef44226 d23bb63 change % change
efr32 lighting-app BRD4187C (read/write) 1068248 1068312 64 0.0
.text 884908 884972 64 0.0
window-app BRD4187C (read/write) 1133988 1134052 64 0.0
.text 966144 966208 64 0.0
Decreases (1 build for efr32)
platform target config section ef44226 d23bb63 change % change
efr32 lock-app BRD4338a (read/write) 959876 959868 -8 -0.0
.text 700016 700008 -8 -0.0
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section ef44226 d23bb63 change % change
bl602 lighting-app bl602 (read/write) 1442794 1442794 0 0.0
.bss 85440 85440 0 0.0
.data 9504 9504 0 0.0
.rodata 159068 159068 0 0.0
.text 1108122 1108122 0 0.0
bl602+mfd (read/write) 1457210 1457210 0 0.0
.bss 85608 85608 0 0.0
.data 9480 9480 0 0.0
.rodata 158028 158028 0 0.0
.text 1123440 1123440 0 0.0
bl602+rpc (read/write) 1490442 1490442 0 0.0
.bss 93480 93480 0 0.0
.data 9880 9880 0 0.0
.rodata 166644 166644 0 0.0
.text 1139768 1139768 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1207651 1207651 0 0.0
.bss 11185 11185 0 0.0
.data 3696 3696 0 0.0
.rodata 108432 108432 0 0.0
.text 977422 977422 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1218463 1218463 0 0.0
.bss 11361 11361 0 0.0
.data 3672 3672 0 0.0
.rodata 107372 107372 0 0.0
.text 989176 989176 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1299387 1299387 0 0.0
.bss 19669 19669 0 0.0
.data 4232 4232 0 0.0
.rodata 123804 123804 0 0.0
.text 1052386 1052386 0 0.0
bl706-eth (read/write) 1024917 1024917 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101756 101756 0 0.0
.text 768126 768126 0 0.0
bl706-wifi (read/write) 1259566 1259566 0 0.0
.bss 10645 10645 0 0.0
.data 3696 3696 0 0.0
.rodata 122756 122756 0 0.0
.text 1000000 1000000 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1176992 1176992 0 0.0
.bss 16396 16396 0 0.0
.data 5056 5056 0 0.0
.rodata 102436 102436 0 0.0
.text 970288 970288 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1188400 1188400 0 0.0
.bss 16572 16572 0 0.0
.data 5040 5040 0 0.0
.rodata 101376 101376 0 0.0
.text 982610 982610 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782484 782484 0 0.0
(read/write) 168816 168816 0 0.0
.bss 90772 90772 0 0.0
.data 3584 3584 0 0.0
.rodata 82628 82628 0 0.0
.text 699592 699592 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798492 798492 0 0.0
(read/write) 178968 178968 0 0.0
.bss 100940 100940 0 0.0
.data 3576 3576 0 0.0
.rodata 76716 76716 0 0.0
.text 721512 721512 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787236 787236 0 0.0
(read/write) 173408 173408 0 0.0
.bss 95380 95380 0 0.0
.data 3576 3576 0 0.0
.rodata 103532 103532 0 0.0
.text 683440 683440 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739556 739556 0 0.0
(read/write) 167776 167776 0 0.0
.bss 89512 89512 0 0.0
.data 3568 3568 0 0.0
.rodata 78292 78292 0 0.0
.text 661000 661000 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 725180 725180 0 0.0
(read/write) 168000 168000 0 0.0
.bss 89736 89736 0 0.0
.data 3568 3568 0 0.0
.rodata 74068 74068 0 0.0
.text 650848 650848 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586614 586614 0 0.0
(read/write) 208088 208088 0 0.0
.bss 201316 201316 0 0.0
.data 1648 1648 0 0.0
.rodata 87502 87502 0 0.0
.text 496988 496988 0 0.0
lock CC3235SF_LAUNCHXL (read only) 631422 631422 0 0.0
(read/write) 208344 208344 0 0.0
.bss 201720 201720 0 0.0
.data 1504 1504 0 0.0
.rodata 107854 107854 0 0.0
.text 521448 521448 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569639 569639 0 0.0
.app_xip_area 459573 459573 0 0.0
.bss 64892 64892 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551847 551847 0 0.0
.app_xip_area 437109 437109 0 0.0
.bss 69556 69556 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572951 572951 0 0.0
.app_xip_area 464381 464381 0 0.0
.bss 63436 63436 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564911 564911 0 0.0
.app_xip_area 453157 453157 0 0.0
.bss 66540 66540 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1068248 1068312 64 0.0
.bss 179896 179896 0 0.0
.data 3424 3424 0 0.0
.text 884908 884972 64 0.0
lock-app BRD4338a (read/write) 959876 959868 -8 -0.0
.bss 210220 210220 0 0.0
.data 30272 30272 0 0.0
.text 700016 700008 -8 -0.0
window-app BRD4187C (read/write) 1133988 1134052 64 0.0
.bss 164496 164496 0 0.0
.data 3328 3328 0 0.0
.text 966144 966208 64 0.0
esp32 all-clusters-app c3devkit (read only) 1213388 1213388 0 0.0
(read/write) 1750224 1750224 0 0.0
.dram0.bss 74320 74320 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252752 252752 0 0.0
.flash.text 1213388 1213388 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1255963 1255963 0 0.0
(read/write) 536532 536532 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284368 284368 0 0.0
.flash.text 1249799 1249799 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2645253 2645253 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46728 46728 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 184912 184912 0 0.0
.text 2281349 2281349 0 0.0
all-clusters-app debug (read only) 5954113 5954113 0 0.0
(read/write) 481512 481512 0 0.0
.bss 135040 135040 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334472 334472 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 350480 350480 0 0.0
.text 5168851 5168851 0 0.0
all-clusters-minimal-app debug (read only) 5234441 5234441 0 0.0
(read/write) 237464 237464 0 0.0
.bss 127872 127872 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98056 98056 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 289514 289514 0 0.0
.text 4708803 4708803 0 0.0
bridge-app debug (read only) 4627841 4627841 0 0.0
(read/write) 218344 218344 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86976 86976 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230282 230282 0 0.0
.text 4175859 4175859 0 0.0
chip-tool debug (read only) 12082801 12082801 0 0.0
(read/write) 523104 523104 0 0.0
.bss 94744 94744 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451225 451225 0 0.0
.text 1092321 1092321 0 0.0
chip-tool-ipv6only arm64 (read only) 11402564 11402564 0 0.0
(read/write) 588640 588640 0 0.0
.bss 103720 103720 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356068 356068 0 0.0
.text 10164808 10164808 0 0.0
lighting-app debug+rpc+ui (read only) 5550641 5550641 0 0.0
(read/write) 227112 227112 0 0.0
.bss 119344 119344 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 95376 95376 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354036 354036 0 0.0
.text 4948515 4948515 0 0.0
lock-app debug (read only) 4692489 4692489 0 0.0
(read/write) 205568 205568 0 0.0
.bss 113704 113704 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 81000 81000 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 255978 255978 0 0.0
.text 4223875 4223875 0 0.0
ota-provider-app debug (read only) 4309249 4309249 0 0.0
(read/write) 194200 194200 0 0.0
.bss 113440 113440 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209194 209194 0 0.0
.text 3905571 3905571 0 0.0
ota-requestor-app debug (read only) 4438817 4438817 0 0.0
(read/write) 198568 198568 0 0.0
.bss 114336 114336 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215370 215370 0 0.0
.text 4024419 4024419 0 0.0
shell debug (read only) 2920825 2920825 0 0.0
(read/write) 156880 156880 0 0.0
.bss 62512 62512 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87152 87152 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 186784 186784 0 0.0
.text 2559362 2559362 0 0.0
thermostat-no-ble arm64 (read only) 4427868 4427868 0 0.0
(read/write) 243456 243456 0 0.0
.bss 121976 121976 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 104296 104296 0 0.0
.dynamic 512 512 0 0.0
.got 8712 8712 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160084 160084 0 0.0
.text 3931240 3931240 0 0.0
tv-app debug (read only) 5763561 5763561 0 0.0
(read/write) 353304 353304 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95128 95128 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 293386 293386 0 0.0
.text 5226947 5226947 0 0.0
tv-casting-app debug (read only) 9893449 9893449 0 0.0
(read/write) 342528 342528 0 0.0
.bss 157880 157880 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174752 174752 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 383704 383704 0 0.0
.text 9043059 9043059 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2534624 2534624 0 0.0
.bss 220480 220480 0 0.0
.data 5216 5216 0 0.0
.text 1497308 1497308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1064764 1064764 0 0.0
bss 133107 133107 0 0.0
rodata 103052 103052 0 0.0
text 781384 781384 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1225544 1225544 0 0.0
bss 127163 127163 0 0.0
rodata 151300 151300 0 0.0
text 797048 797048 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1012244 1012244 0 0.0
bss 131965 131965 0 0.0
rodata 90316 90316 0 0.0
text 742752 742752 0 0.0
nxp contact k32w0+release (read only) 574956 574956 0 0.0
(read/write) 80004 80004 0 0.0
.bss 67840 67840 0 0.0
.data 2180 2180 0 0.0
.text 574420 574420 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 702092 702092 0 0.0
.bss 71184 71184 0 0.0
.data 2856 2856 0 0.0
.text 588672 588672 0 0.0
light k32w0+release (read only) 608880 608880 0 0.0
(read/write) 79464 79464 0 0.0
.bss 67280 67280 0 0.0
.data 2200 2200 0 0.0
.text 608344 608344 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 793824 793824 0 0.0
.bss 80728 80728 0 0.0
.data 2056 2056 0 0.0
.text 671672 671672 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832288 832288 0 0.0
(read/write) 1803068 1803068 0 0.0
.bss 198364 198364 0 0.0
.data 2688 2688 0 0.0
.text 1593628 1593628 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835440 835440 0 0.0
(read/write) 1724972 1724972 0 0.0
.bss 195244 195244 0 0.0
.data 2656 2656 0 0.0
.text 1518684 1518684 0 0.0
light cy8ckit_062s2_43012 (read only) 842168 842168 0 0.0
(read/write) 1643684 1643684 0 0.0
.bss 188708 188708 0 0.0
.data 2464 2464 0 0.0
.text 1444124 1444124 0 0.0
lock cy8ckit_062s2_43012 (read only) 815096 815096 0 0.0
(read/write) 1672388 1672388 0 0.0
.bss 215788 215788 0 0.0
.data 2456 2456 0 0.0
.text 1445756 1445756 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1132200 1132200 0 0.0
.bss 102572 102572 0 0.0
.data 844 844 0 0.0
.text 644584 644584 0 0.0
lock-app qpg6105+debug (read/write) 1092240 1092240 0 0.0
.bss 97244 97244 0 0.0
.data 856 856 0 0.0
.text 604620 604620 0 0.0
stm32 light STM32WB5MM-DK (read/write) 603789 603789 0 0.0
.bss 128428 128428 0 0.0
.data 676 676 0 0.0
.rodata 80212 80212 0 0.0
.text 384728 384728 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832914 832914 0 0.0
bss 49836 49836 0 0.0
text 623940 623940 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096136 1096136 0 0.0
bss 101520 101520 0 0.0
text 797488 797488 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1057600 1057600 0 0.0
bss 109968 109968 0 0.0
text 771846 771846 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 913088 913088 0 0.0
bss 92724 92724 0 0.0
text 655288 655288 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834950 834950 0 0.0
bss 49880 49880 0 0.0
text 626044 626044 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 935736 935736 0 0.0
bss 77492 77492 0 0.0
text 702706 702706 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1089504 1089504 0 0.0
bss 99816 99816 0 0.0
text 793302 793302 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 910180 910180 0 0.0
bss 69160 69160 0 0.0
text 659572 659572 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932780 932780 0 0.0
bss 92428 92428 0 0.0
text 674856 674856 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 832596 832596 0 0.0
bss 58124 58124 0 0.0
text 623140 623140 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 798724 798724 0 0.0
bss 56052 56052 0 0.0
text 598046 598046 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675980 675980 0 0.0
bss 73412 73412 0 0.0
text 461726 461726 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 842674 842674 0 0.0
bss 51508 51508 0 0.0
text 632582 632582 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858437 858437 0 0.0
bss 59676 59676 0 0.0
text 642148 642148 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 824272 824272 0 0.0
bss 56384 56384 0 0.0
text 617598 617598 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 837388 837388 0 0.0
bss 58340 58340 0 0.0
text 625506 625506 0 0.0

@mergify mergify bot merged commit 8d47f40 into project-chip:master Apr 15, 2024
65 checks passed
@mkardous-silabs mkardous-silabs deleted the feature/adv_change branch April 15, 2024 16:51
@mkardous-silabs mkardous-silabs restored the feature/adv_change branch April 15, 2024 20:05
@mkardous-silabs mkardous-silabs deleted the feature/adv_change branch April 15, 2024 21:19
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 8, 2024
… silabs platforms (project-chip#32987)

Merge in WMN_TOOLS/matter from cherry-pick/advertising_change_event to RC_2.3.0-1.3

Squashed commit of the following:

commit 095bd4988dabf92837a81829bf2d8b1d9414200c
Author: mkardous-silabs <[email protected]>
Date:   Mon Apr 15 11:51:14 2024 -0500

    Add adv change event to silabs platforms (project-chip#32987)
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
… silabs platforms (project-chip#32987)

Merge in WMN_TOOLS/matter from cherry-pick/advertising_change_event to RC_2.3.0-1.3

Squashed commit of the following:

commit 095bd4988dabf92837a81829bf2d8b1d9414200c
Author: mkardous-silabs <[email protected]>
Date:   Mon Apr 15 11:51:14 2024 -0500

    Add adv change event to silabs platforms (project-chip#32987)
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants