-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out AttributeAccessInterface.h
into separate headers/cpp for each underlying class
#32984
Split out AttributeAccessInterface.h
into separate headers/cpp for each underlying class
#32984
Conversation
PR #32984: Size comparison from 3cb8382 to 7f80e63 Increases (2 builds for linux)
Decreases (2 builds for cc32xx, linux)
Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32)
|
PR #32984: Size comparison from 3cb8382 to 24cda36 Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! Makes things much more readable, if nothing else.
PR #32984: Size comparison from 3cb8382 to e0f4409 Increases above 0.2%:
Increases (21 builds for cyw30739, esp32, linux, telink)
Decreases (10 builds for cc32xx, efr32, esp32, linux, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Thanks for this split for better readability! |
PR #32984: Size comparison from 3cb8382 to ab509f7 Increases above 0.2%:
Increases (23 builds for cyw30739, efr32, esp32, linux, telink)
Decreases (11 builds for cc32xx, efr32, esp32, linux, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Changes
AttributeValueEncoder
,AttributeValueDecoder
andAttributeReportBuilder