Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin: MTRDeviceControllerFactory cleanup #32960

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Darwin: MTRDeviceControllerFactory cleanup #32960

merged 5 commits into from
Apr 16, 2024

Conversation

ksperling-apple
Copy link
Contributor

Internal methods don't need a named category
Use ivars directly (most internal properties were never used as properties)
Use MTR_DIRECT_MEMBERS for internals / implementation
No need to pre-declare internal methods used only with the same file

Reorder ivars a little to group related things

Allocate C++ objects that are created at init time directly as ivars instead of
as pointers. This avoids the need for manual cleanup code

@ksperling-apple
Darwin: MTRDeviceControllerFactory cleanup
31aeab1 
Internal methods don't need a named category
Use ivars directly (most internal properties were never used as properties)
Use MTR_DIRECT_MEMBERS for internals / implementation
No need to pre-declare internal methods used only with the same file
@ksperling-apple
Darwin: MTRDeviceControllerFactory cleanup (cont)
56a1dfb 
Reorder ivars a little to group related things
@ksperling-apple
Darwin: MTRDeviceControllerFactory cleanup (cont)
e7600f2 
Allocate C++ objects that are created at init time directly as ivars instead of
as pointers. This avoids the need for manual cleanup code.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

PR #32960: Size comparison from 8b3d008 to e7600f2

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 8b3d008 e7600f2 change % change
bl602 lighting-app bl602 (read/write) 1442886 1442886 0 0.0
.bss 85432 85432 0 0.0
.data 9504 9504 0 0.0
.rodata 159072 159072 0 0.0
.text 1108210 1108210 0 0.0
bl602+mfd (read/write) 1457302 1457302 0 0.0
.bss 85600 85600 0 0.0
.data 9480 9480 0 0.0
.rodata 158032 158032 0 0.0
.text 1123528 1123528 0 0.0
bl602+rpc (read/write) 1490270 1490270 0 0.0
.bss 93480 93480 0 0.0
.data 9880 9880 0 0.0
.rodata 166640 166640 0 0.0
.text 1139600 1139600 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1207475 1207475 0 0.0
.bss 11217 11217 0 0.0
.data 3688 3688 0 0.0
.rodata 108432 108432 0 0.0
.text 977256 977256 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1218547 1218547 0 0.0
.bss 11393 11393 0 0.0
.data 3664 3664 0 0.0
.rodata 107372 107372 0 0.0
.text 989266 989266 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1299211 1299211 0 0.0
.bss 19701 19701 0 0.0
.data 4224 4224 0 0.0
.rodata 123804 123804 0 0.0
.text 1052220 1052220 0 0.0
bl706-eth (read/write) 1025013 1025013 0 0.0
.bss 23792 23792 0 0.0
.data 3264 3264 0 0.0
.rodata 101756 101756 0 0.0
.text 768214 768214 0 0.0
bl706-wifi (read/write) 1259670 1259670 0 0.0
.bss 10677 10677 0 0.0
.data 3696 3696 0 0.0
.rodata 122756 122756 0 0.0
.text 1000102 1000102 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1177076 1177076 0 0.0
.bss 16428 16428 0 0.0
.data 5048 5048 0 0.0
.rodata 102436 102436 0 0.0
.text 970378 970378 0 0.0
bl702l+mfd (read/write) 1188992 1188992 0 0.0
.bss 16604 16604 0 0.0
.data 5032 5032 0 0.0
.rodata 101376 101376 0 0.0
.text 982700 982700 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782500 782500 0 0.0
(read/write) 168824 168824 0 0.0
.bss 90780 90780 0 0.0
.data 3584 3584 0 0.0
.rodata 82628 82628 0 0.0
.text 699604 699604 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798492 798492 0 0.0
(read/write) 178976 178976 0 0.0
.bss 100948 100948 0 0.0
.data 3576 3576 0 0.0
.rodata 76716 76716 0 0.0
.text 721508 721508 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787236 787236 0 0.0
(read/write) 173416 173416 0 0.0
.bss 95388 95388 0 0.0
.data 3576 3576 0 0.0
.rodata 103532 103532 0 0.0
.text 683436 683436 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739556 739556 0 0.0
(read/write) 167784 167784 0 0.0
.bss 89520 89520 0 0.0
.data 3568 3568 0 0.0
.rodata 78292 78292 0 0.0
.text 660996 660996 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 725188 725188 0 0.0
(read/write) 168000 168000 0 0.0
.bss 89736 89736 0 0.0
.data 3568 3568 0 0.0
.rodata 74068 74068 0 0.0
.text 650852 650852 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586618 586618 0 0.0
(read/write) 208080 208080 0 0.0
.bss 201308 201308 0 0.0
.data 1648 1648 0 0.0
.rodata 87514 87514 0 0.0
.text 496980 496980 0 0.0
lock CC3235SF_LAUNCHXL (read only) 631418 631418 0 0.0
(read/write) 208336 208336 0 0.0
.bss 201712 201712 0 0.0
.data 1504 1504 0 0.0
.rodata 107858 107858 0 0.0
.text 521436 521436 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569599 569599 0 0.0
.app_xip_area 459517 459517 0 0.0
.bss 64908 64908 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551815 551815 0 0.0
.app_xip_area 437061 437061 0 0.0
.bss 69572 69572 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572911 572911 0 0.0
.app_xip_area 464333 464333 0 0.0
.bss 63444 63444 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564887 564887 0 0.0
.app_xip_area 453117 453117 0 0.0
.bss 66556 66556 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1213544 1213544 0 0.0
(read/write) 1750344 1750344 0 0.0
.dram0.bss 74384 74384 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252808 252808 0 0.0
.flash.text 1213544 1213544 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1255435 1255435 0 0.0
(read/write) 536508 536508 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284344 284344 0 0.0
.flash.text 1249271 1249271 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2645053 2645053 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46736 46736 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184880 184880 0 0.0
.text 2281205 2281205 0 0.0
all-clusters-app debug (read only) 5953881 5953881 0 0.0
(read/write) 481504 481504 0 0.0
.bss 135072 135072 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334456 334456 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1432 1432 0 0.0
.rodata 350416 350416 0 0.0
.text 5168707 5168707 0 0.0
all-clusters-minimal-app debug (read only) 5234145 5234145 0 0.0
(read/write) 237488 237488 0 0.0
.bss 127904 127904 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98040 98040 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 289386 289386 0 0.0
.text 4708659 4708659 0 0.0
bridge-app debug (read only) 4627641 4627641 0 0.0
(read/write) 218336 218336 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86976 86976 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 230250 230250 0 0.0
.text 4175715 4175715 0 0.0
chip-tool debug (read only) 12082489 12082489 0 0.0
(read/write) 523032 523032 0 0.0
.bss 94680 94680 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 451225 451225 0 0.0
.text 10922931 10922931 0 0.0
chip-tool-ipv6only arm64 (read only) 11402292 11402292 0 0.0
(read/write) 588928 588928 0 0.0
.bss 103736 103736 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356004 356004 0 0.0
.text 10164600 10164600 0 0.0
lighting-app debug+rpc+ui (read only) 5550441 5550441 0 0.0
(read/write) 227064 227064 0 0.0
.bss 119336 119336 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 95360 95360 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 354004 354004 0 0.0
.text 4948371 4948371 0 0.0
lock-app debug (read only) 4692241 4692241 0 0.0
(read/write) 205552 205552 0 0.0
.bss 113696 113696 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 81016 81016 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 255914 255914 0 0.0
.text 4223715 4223715 0 0.0
ota-provider-app debug (read only) 4309049 4309049 0 0.0
(read/write) 194224 194224 0 0.0
.bss 113472 113472 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 209162 209162 0 0.0
.text 3905427 3905427 0 0.0
ota-requestor-app debug (read only) 4438649 4438649 0 0.0
(read/write) 198592 198592 0 0.0
.bss 114368 114368 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73552 73552 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 215370 215370 0 0.0
.text 4024275 4024275 0 0.0
shell debug (read only) 2920385 2920385 0 0.0
(read/write) 156904 156904 0 0.0
.bss 62544 62544 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87152 87152 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1104 1104 0 0.0
.rodata 186656 186656 0 0.0
.text 2559074 2559074 0 0.0
thermostat-no-ble arm64 (read only) 4427788 4427788 0 0.0
(read/write) 243536 243536 0 0.0
.bss 121976 121976 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 104296 104296 0 0.0
.dynamic 512 512 0 0.0
.got 8712 8712 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160084 160084 0 0.0
.text 3931160 3931160 0 0.0
tv-app debug (read only) 5763153 5763153 0 0.0
(read/write) 353296 353296 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95128 95128 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 293258 293258 0 0.0
.text 5226691 5226691 0 0.0
tv-casting-app debug (read only) 9893105 9893105 0 0.0
(read/write) 342544 342544 0 0.0
.bss 157904 157904 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174752 174752 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1208 1208 0 0.0
.rodata 383672 383672 0 0.0
.text 9042771 9042771 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2534632 2534632 0 0.0
.bss 220472 220472 0 0.0
.data 5216 5216 0 0.0
.text 1497316 1497316 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1064780 1064780 0 0.0
bss 133107 133107 0 0.0
rodata 103052 103052 0 0.0
text 781400 781400 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1225560 1225560 0 0.0
bss 127163 127163 0 0.0
rodata 151300 151300 0 0.0
text 797064 797064 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1012260 1012260 0 0.0
bss 131965 131965 0 0.0
rodata 90316 90316 0 0.0
text 742768 742768 0 0.0
nxp contact k32w0+release (read only) 574964 574964 0 0.0
(read/write) 80004 80004 0 0.0
.bss 67840 67840 0 0.0
.data 2180 2180 0 0.0
.text 574428 574428 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 702100 702100 0 0.0
.bss 71192 71192 0 0.0
.data 2856 2856 0 0.0
.text 588672 588672 0 0.0
light k32w0+release (read only) 608880 608880 0 0.0
(read/write) 79464 79464 0 0.0
.bss 67280 67280 0 0.0
.data 2200 2200 0 0.0
.text 608344 608344 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 793824 793824 0 0.0
.bss 80728 80728 0 0.0
.data 2056 2056 0 0.0
.text 671672 671672 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832280 832280 0 0.0
(read/write) 1803076 1803076 0 0.0
.bss 198372 198372 0 0.0
.data 2688 2688 0 0.0
.text 1593628 1593628 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835432 835432 0 0.0
(read/write) 1724964 1724964 0 0.0
.bss 195252 195252 0 0.0
.data 2656 2656 0 0.0
.text 1518668 1518668 0 0.0
light cy8ckit_062s2_43012 (read only) 842160 842160 0 0.0
(read/write) 1643700 1643700 0 0.0
.bss 188716 188716 0 0.0
.data 2464 2464 0 0.0
.text 1444132 1444132 0 0.0
lock cy8ckit_062s2_43012 (read only) 815096 815096 0 0.0
(read/write) 1672388 1672388 0 0.0
.bss 215788 215788 0 0.0
.data 2456 2456 0 0.0
.text 1445756 1445756 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1132200 1132200 0 0.0
.bss 102572 102572 0 0.0
.data 844 844 0 0.0
.text 644584 644584 0 0.0
lock-app qpg6105+debug (read/write) 1092232 1092232 0 0.0
.bss 97252 97252 0 0.0
.data 856 856 0 0.0
.text 604612 604612 0 0.0
stm32 light STM32WB5MM-DK (read/write) 603789 603789 0 0.0
.bss 128436 128436 0 0.0
.data 676 676 0 0.0
.rodata 80212 80212 0 0.0
.text 384720 384720 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832938 832938 0 0.0
bss 49836 49836 0 0.0
text 623968 623968 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096176 1096176 0 0.0
bss 101520 101520 0 0.0
text 797526 797526 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1057640 1057640 0 0.0
bss 109968 109968 0 0.0
text 771888 771888 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 913128 913128 0 0.0
bss 92724 92724 0 0.0
text 655326 655326 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834982 834982 0 0.0
bss 49880 49880 0 0.0
text 626074 626074 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 935720 935720 0 0.0
bss 77492 77492 0 0.0
text 702712 702712 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1089536 1089536 0 0.0
bss 99816 99816 0 0.0
text 793336 793336 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 910212 910212 0 0.0
bss 69160 69160 0 0.0
text 659602 659602 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932820 932820 0 0.0
bss 92428 92428 0 0.0
text 674898 674898 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 832628 832628 0 0.0
bss 58124 58124 0 0.0
text 623166 623166 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 798748 798748 0 0.0
bss 56052 56052 0 0.0
text 598072 598072 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 675936 675936 0 0.0
bss 73412 73412 0 0.0
text 461698 461698 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 842706 842706 0 0.0
bss 51508 51508 0 0.0
text 632612 632612 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858469 858469 0 0.0
bss 59676 59676 0 0.0
text 642182 642182 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 824296 824296 0 0.0
bss 56384 56384 0 0.0
text 617624 617624 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 837412 837412 0 0.0
bss 58340 58340 0 0.0
text 625536 625536 0 0.0

@ksperling-apple
Copy link
Contributor Author

Fast-tracking Darwin-only change.

@mergify mergify bot merged commit 0c17072 into project-chip:master Apr 16, 2024
65 checks passed
@ksperling-apple ksperling-apple deleted the mtrdcf-cleanup branch April 16, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@arkq arkq Awaiting requested review from arkq

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksperling-apple @bzbarsky-apple