Separate out attribute access interface registry/cache, remove free functions from InteractionModelEngine.h #32954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
platform
darwin
linux
controller
app
tizen
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex and
harsha-rajendran
|
PR #32954: Size comparison from 15f2c49 to e88d964 Increases above 0.2%:
Increases (22 builds for cc13x4_26x4, cyw30739, linux, psoc6, stm32)
Decreases (47 builds for cc13x4_26x4, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, stm32, telink)
Full report (54 builds for cc13x4_26x4, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, stm32, telink)
|
…nd this was just copy and paste
|
PR #32954: Size comparison from 15f2c49 to c2c9b9e Increases (3 builds for cc32xx, stm32)
Decreases (3 builds for cc32xx, stm32)
Full report (3 builds for cc32xx, stm32)
|
|
PR #32954: Size comparison from 15f2c49 to fb05c95 Increases (10 builds for cc13x4_26x4, cc32xx, linux, mbed, qpg, stm32)
Decreases (14 builds for cc13x4_26x4, cc32xx, linux, mbed, nxp, qpg, stm32)
Full report (17 builds for cc13x4_26x4, cc32xx, linux, mbed, nxp, qpg, stm32)
|
bzbarsky-apple
approved these changes
Apr 12, 2024
|
PR #32954: Size comparison from 15f2c49 to 84dec17 Increases (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, psoc6, qpg, stm32)
Decreases (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nxp, psoc6, qpg, stm32)
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nxp, psoc6, qpg, stm32)
|
yunhanw-google
approved these changes
Apr 12, 2024
|
PR #32954: Size comparison from 15f2c49 to 12ef336 Increases above 0.2%:
Increases (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, psoc6, qpg, stm32)
Decreases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeAccessInterface is very stand-alone and has no reason to be tied to ember directly (as its use is mostly inside the compatibility functions as a hook and the only callbacks ember needs is a cleanup).
Changes
AttributeAccessInterfaceRegistry.h/cppto contain the old functions that existed inattribute-storage.cpp.DispatchSingleClusterCommandmethod into its ownsrc/app/util/IMClusterCommandHandler.hto represent that we generate this code intoIMClusterCommandHandler.cppattributeaccessinterfacebut not using it ... and as a sideffect this made ausing chip::TLVneeding removal (that was also there due to copy and paste, but no TLV is used in platform)