-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add std::source_location to ChipError for C++20 builds #32935
Conversation
PR #32935: Size comparison from c6c8e67 to 95974db Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
95974db
to
b9feff9
Compare
PR #32935: Size comparison from 01facfd to b9feff9 Increases (3 builds for cc32xx, mbed)
Full report (3 builds for cc32xx, mbed)
|
PR #32935: Size comparison from 01facfd to 321b7d7 Increases (3 builds for cc32xx, mbed)
Full report (3 builds for cc32xx, mbed)
|
PR #32935: Size comparison from 01facfd to fc4a2e5 Increases (15 builds for cc32xx, linux, mbed)
Full report (15 builds for cc32xx, linux, mbed)
|
PR #32935: Size comparison from 01facfd to 6e3eced Increases (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
Decreases (1 build for bl702l)
Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #32935: Size comparison from 01facfd to ede91b3 Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (3 builds for bl702l, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #32935: Size comparison from 5e925ca to 65a8027 Increases (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, mbed, nxp, psoc6, qpg, stm32)
Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, mbed, nxp, psoc6, qpg, stm32)
|
PR #32935: Size comparison from 5e925ca to c2be8d2 Increases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (4 builds for esp32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the lag here....
Add std::source_location to ChipError when compiling with C++20.
This has the side effect of making the ChipError default constructor non-trivial, which made ChipDeviceEvent also not trivial. Switching ChipDeviceEvent construction to using the designated initializer syntax fixed this.