-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Refactor Silabs Test Event Trigger impl to be compliant with its requirements #32927
Merged
mergify
merged 7 commits into
project-chip:master
from
mkardous-silabs:feature/refactor_test_event_trigger
Apr 11, 2024
Merged
[Silabs] Refactor Silabs Test Event Trigger impl to be compliant with its requirements #32927
mergify
merged 7 commits into
project-chip:master
from
mkardous-silabs:feature/refactor_test_event_trigger
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
April 10, 2024 13:50
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
April 10, 2024 13:51
jmartinez-silabs
approved these changes
Apr 10, 2024
PR #32927: Size comparison from e05d08e to b2260b0 Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
PR #32927: Size comparison from e05d08e to 9df79e5 Full report (3 builds for cc32xx, stm32)
|
PR #32927: Size comparison from e05d08e to 8c05a06 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
mkardous-silabs
force-pushed
the
feature/refactor_test_event_trigger
branch
from
April 10, 2024 17:58
8c05a06
to
4da1f39
Compare
PR #32927: Size comparison from ee6c9e9 to 4da1f39 Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
andy31415
reviewed
Apr 11, 2024
andy31415
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR refactors the Silabs Test event triggers to be inline with the enableKey handling requirements
PR also changes the smoke&co app to be an ICD app by default. Since the ICDM cluster was present the zap configuration, the app could not link succesfully without building Matter with the ICD build flag to true.
Notes to reviewers
PR doesn't touch
emberAfHandleEventTrigger
that acts like the "global" silabs test event trigger handler. This will be refactored in a follow up PR.Tests
Manual tests to validate that the smoke&co test event trigger still works with the new implementation