Darwin: PlatformManagerImpl improvements #32904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use NL_TEST_ASSERT_SUCCESS when checking errors Add a few more assertions
It is simply an alias for the same type if CHIP_CONFIG_GLOBALS_LAZY_INIT is not enabled, as the eager implementation of Global<T> is thread-safe anyway. Use "friend" instead of "friend class" where the type might be an alias.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
Make PlatformMgr[Impl]() thread-safe by using an AtomicGlobal
Make GetWorkQueue() thread-safe by creating the queue in the constructor
Make {Start,Stop}EventLoopTask thread-safe using an atomic for state
Signal the sempahore only if non-null, no matter where stop is called from
Other minor tweaks
ksperling-apple
force-pushed
the
darwin-platformmgr-improvements
branch
from
13e50ae to
3a85c44
Compare
|
PR #32904: Size comparison from f29ccbe to 3a85c44 Decreases (1 build for efr32)
Full report (61 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #32904: Size comparison from f29ccbe to c1a2732 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Apr 9, 2024
Damian-Nordic
approved these changes
Apr 10, 2024
shaoltan-amazon
pushed a commit
to shaoltan-amazon/connectedhomeip
that referenced
this pull request
Apr 10, 2024
* Small improvements to TestPlatformMgr.cpp
Use NL_TEST_ASSERT_SUCCESS when checking errors
Add a few more assertions
* Add AtomicGlobal<T> as a thread-safe variant of Global<T>
It is simply an alias for the same type if CHIP_CONFIG_GLOBALS_LAZY_INIT is not
enabled, as the eager implementation of Global<T> is thread-safe anyway.
Use "friend" instead of "friend class" where the type might be an alias.
* Darwin: PlatformManagerImpl improvements
Make PlatformMgr[Impl]() thread-safe by using an AtomicGlobal
Make GetWorkQueue() thread-safe by creating the queue in the constructor
Make {Start,Stop}EventLoopTask thread-safe using an atomic for state
Signal the sempahore only if non-null, no matter where stop is called from
Other minor tweaks
* Don't reference std::call_once unless CHIP_CONFIG_GLOBALS_LAZY_INIT=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make PlatformMgrImpl thread-safe by using an AtomicGlobal
Make GetWorkQueue() thread-safe by creating the queue in the constructor
Make {Start,Stop}EventLoopTask thread-safe using an atomic for state
Signal the sempahore only if non-null, no matter where stop is called from
Other minor tweaks
Add AtomicGlobal as a thread-safe variant of Global
Small improvements to TestPlatformMgr.cpp