-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BeaconRxCount attributes results is NULL instead of 0 in linux platform #32805
Merged
mergify
merged 3 commits into
project-chip:master
from
Thirsrin:Bugfix/MATTER-3356-BeaconRxCount-attributes-NULL-instead-of-0
Apr 2, 2024
Merged
BeaconRxCount attributes results is NULL instead of 0 in linux platform #32805
mergify
merged 3 commits into
project-chip:master
from
Thirsrin:Bugfix/MATTER-3356-BeaconRxCount-attributes-NULL-instead-of-0
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thirsrin
force-pushed
the
Bugfix/MATTER-3356-BeaconRxCount-attributes-NULL-instead-of-0
branch
from
April 2, 2024 04:13
4c4b4b6
to
ad538c1
Compare
PR #32805: Size comparison from 6c89640 to 05fa50a Increases (14 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32805: Size comparison from 6c89640 to d2fb328 Increases (14 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
April 2, 2024 12:39
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 2, 2024 12:39
Thirsrin
changed the title
[Silabs]BeaconRxCount attributes results is NULL instead of 0
BeaconRxCount attributes results is NULL instead of 0 in linux platform
Apr 2, 2024
jmartinez-silabs
approved these changes
Apr 2, 2024
arkq
approved these changes
Apr 2, 2024
kurvaSai
pushed a commit
to SiliconLabs/matter-for-unify
that referenced
this pull request
May 29, 2024
…rm (project-chip#32805) * BeaconRxCount attributes results is NULL instead of 0 * Restyled by clang-format * Removed GetWiFiBeaconRxCount from connectivityutills --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#25747
Description of Problem:
Read on "BeaconRxCount" attributes results is NULL instead of 0, BeaconRxCount implementation was missing for linux.
Description of Fix:
Implemented BeaconRxCount for linux.
Testing Done:
Locally tested, getting expected output