[Darwin] Adding more metrics to capture BLE during setup #32793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anush-apple
commented
Mar 29, 2024
anush-apple
commented
- Added more metrics across BLE phase in Darwin
- Fixed MetricsCollector to only capture first event of any kind
- Reset metrics before any API is started
- Fixed bug where duration was not being calculated correctly
- Added more metrics across BLE phase in Darwin - Fixed MetricsCollector to only capture first event of any kind - Reset metrics before any API is started - Fixed bug where duration was not being calculated correctly
pullapprove
bot
requested review from
andy31415,
andyg-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
|
PR #32793: Size comparison from 6ed5dd3 to 494a72f Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
Mar 29, 2024
woody-apple
approved these changes
Mar 29, 2024
anush-apple
commented
Mar 29, 2024
| // Since OnPairingComplete(failure_code) might not be invoked in all cases, use this opportunity to inform of failed commissioning | ||
| // and default the error to timeout since that is best guess in this layer. | ||
| if (status == chip::Controller::DevicePairingDelegate::Status::SecurePairingFailed && [strongDelegate respondsToSelector:@selector(controller:commissioningComplete:nodeID:metrics:)]) { | ||
| OnCommissioningComplete(mDeviceNodeId, CHIP_ERROR_TIMEOUT); |
There was a problem hiding this comment.
This needs to be documented clearly in the APIs. Given what the documentation says right now, API consumers will absolutely not expect a commissioningComplete callback here.
| // Since OnPairingComplete(failure_code) might not be invoked in all cases, use this opportunity to inform of failed commissioning | ||
| // and default the error to timeout since that is best guess in this layer. | ||
| if (status == chip::Controller::DevicePairingDelegate::Status::SecurePairingFailed && [strongDelegate respondsToSelector:@selector(controller:commissioningComplete:nodeID:metrics:)]) { | ||
| OnCommissioningComplete(mDeviceNodeId, CHIP_ERROR_TIMEOUT); |
There was a problem hiding this comment.
But if the API consumer tries to set up a new PASE session while the old setup is in progress, what happens? That will clobber mDeviceNodeId, right? Because we set it before we try to do the new PASE setup, which I think will fail out sync in that case...
This really needs an actual sound model for how this stuff works, so we don't get stuck with behavior clients expect that is broken and we can't change.
There was a problem hiding this comment.
Yup, but I am not sure how to fix this without changing the C++ layer. Ideally, if the callbacks can be fixed to pass on the NodeId, it will eliminate this issue
There was a problem hiding this comment.
Well, one option is to set this only if we successfully kick off an async pairing operation, right? As in, don't set this until the call into the C++ returns success.
There was a problem hiding this comment.
But in that case, the callback above won't be invoked and clobbering the NodeId for the latest one should be fine. Right?
There was a problem hiding this comment.
So the situation is:
- Start PASE with node id 1.
- Try to start PASE with node id 2, that fails to start (because the core SDK can only do one thing at a time for now), but sets mDeviceNodeId to 2.
- Now PASE to node id 1 fails, reports OnCommissioningComplete for node id 2.
There was a problem hiding this comment.
Ah I see, I can fix it in next iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.