-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create workflow yaml file to trigger CI check for Linux tv-casting-app and Linux tv-app. #32788
Create workflow yaml file to trigger CI check for Linux tv-casting-app and Linux tv-app. #32788
Conversation
PR #32788: Size comparison from c5fba0c to 6230e74 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32788: Size comparison from c5fba0c to 4f622a3 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition looks fine but there is already a few Linux workflows that does the Linux bootstrap and build some Apps. Can't we not add the Linux tv build app in those?
Hi @jmartinez-silabs, the idea is to have a separate required CI check set up for verifying that the Linux tv-casting-app continues to work with the Linux tv-app as part of the PR process. This is to prevent the existing Matter casting experience from unknowingly breaking whenever new code changes are merged in. Some of the initial test cases that we would like to test for (and that would be included in a separate test script file) are:
Each of these test cases would be a separate workflow job step. Therefore, I believe by having a separate workflow file with steps to build the Linux tv-app, build the Linux tv-casting-app, and then to run the test script for each test case of interest would be ideal for the intended use case of testing the Linux tv-casting-app with the Linux tv-app. |
…p and Linux tv-app.
4f622a3
to
ae5f9bb
Compare
PR #32788: Size comparison from d09b5ac to ae5f9bb Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Fixes #32787
Problem
There is currently no automated testing available to verify that the Linux tv-casting-app continues to work with the Linux tv-app. Without having a CI check in place, the existing Matter casting experience of the Linux tv-casting-app and the Linux tv-app can unknowingly break whenever a PR is merged.
Solution Overview
Create a CI check to verify that the Linux tv-casting-app continues to work with the Linux tv-app whenever a PR is created. The configurations of the workflow yaml file will use the existing workflow files as reference. For now, the workflow will just be building the Linux tv-casting-app and the Linux tv-app. In follow up PRs, the testing script will be created with specific commands and test scenarios to test for. See #32787 for reference.
Testing