-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Implement async friendly GetConnectedDevice #32760
Merged
mergify
merged 4 commits into
project-chip:master
from
agners:implement-async-friendly-getconnecteddevice
May 1, 2024
Merged
[Python] Implement async friendly GetConnectedDevice #32760
mergify
merged 4 commits into
project-chip:master
from
agners:implement-async-friendly-getconnecteddevice
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
March 27, 2024 21:30
pullapprove
bot
requested review from
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
March 27, 2024 21:30
PR #32760: Size comparison from 60b6beb to a7c9039 Full report (4 builds for cc32xx, mbed, stm32)
|
agners
force-pushed
the
implement-async-friendly-getconnecteddevice
branch
from
March 27, 2024 21:44
a7c9039
to
93ed949
Compare
PR #32760: Size comparison from ef01670 to 93ed949 Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
agners
force-pushed
the
implement-async-friendly-getconnecteddevice
branch
from
March 27, 2024 22:33
93ed949
to
f9fc067
Compare
PR #32760: Size comparison from 2d550d6 to f9fc067 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andy31415
reviewed
Mar 28, 2024
andy31415
reviewed
Mar 28, 2024
andy31415
approved these changes
Mar 28, 2024
woody-apple
approved these changes
Apr 24, 2024
Currently GetConnectedDeviceSync() is blocking e.g. when a new session needs to be created. This is not asyncio friendly as it blocks the whole event loop. Implement a asyncio friendly variant GetConnectedDevice() which is a co-routine function which can be awaited.
agners
force-pushed
the
implement-async-friendly-getconnecteddevice
branch
from
April 29, 2024 08:09
f9fc067
to
877b1d8
Compare
Change semantics slightly to make 0 mean don't wait at all.
PR #32760: Size comparison from 040e5bf to 837bcd7 Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
agners
force-pushed
the
implement-async-friendly-getconnecteddevice
branch
from
April 29, 2024 09:22
837bcd7
to
49f5856
Compare
PR #32760: Size comparison from 040e5bf to 49f5856 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
agners
added a commit
to home-assistant-libs/chip-wheels
that referenced
this pull request
May 14, 2024
The patch has been applied upstream: project-chip/connectedhomeip#32760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently GetConnectedDeviceSync() is blocking e.g. when a new session needs to be created. This is not asyncio friendly as it blocks the whole event loop.
Implement a asyncio friendly variant GetConnectedDevice() which is a co-routine function which can be awaited.