-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs][WiFi] 917 trngKey entropy is only needed on 917 Soc #32759
Merged
mergify
merged 1 commit into
project-chip:master
from
jmartinez-silabs:fix/917_ncp_remove_trng
Mar 28, 2024
Merged
[Silabs][WiFi] 917 trngKey entropy is only needed on 917 Soc #32759
mergify
merged 1 commit into
project-chip:master
from
jmartinez-silabs:fix/917_ncp_remove_trng
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
changed the title
[Silabs][WiFi] 917 trngKey entropy only needed on 917 Soc
[Silabs][WiFi] 917 trngKey entropy is only needed on 917 Soc
Mar 27, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
March 27, 2024 20:58
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
March 27, 2024 20:58
mkardous-silabs
approved these changes
Mar 27, 2024
PR #32759: Size comparison from 60b6beb to 26dc6fa Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jepenven-silabs
approved these changes
Mar 27, 2024
LP727
approved these changes
Mar 28, 2024
lpbeliveau-silabs
approved these changes
Mar 28, 2024
andy31415
approved these changes
Mar 28, 2024
chirag-silabs
pushed a commit
to rosahay-silabs/connectedhomeip
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent pr #32470, cleaned up some of our wifi defines an ifdef.
One too many was removed as the encapsulated functionally is for the 917 SoC, but not the efr32+wifi ncp combos.
add back the #ifdef