-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lint for toplevel "using namespace" in headers. #32757
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-namespace-header-lint
Mar 29, 2024
Merged
Add a lint for toplevel "using namespace" in headers. #32757
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-namespace-header-lint
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tools
examples
crypto
controller
app
github
workflows
tests
icd
Intermittently Connected Devices
protocols
labels
Mar 27, 2024
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
March 27, 2024 16:50
PR #32757: Size comparison from 86af239 to 2fb6f58 Full report (3 builds for cc32xx, stm32)
|
bzbarsky-apple
force-pushed
the
add-namespace-header-lint
branch
2 times, most recently
from
March 27, 2024 17:08
1ec2fee
to
fdf513f
Compare
andy31415
approved these changes
Mar 27, 2024
PR #32757: Size comparison from 86af239 to fdf513f Full report (12 builds for cc32xx, k32w, nrfconnect, qpg, stm32)
|
arkq
approved these changes
Mar 27, 2024
bzbarsky-apple
force-pushed
the
add-namespace-header-lint
branch
from
March 27, 2024 17:37
fdf513f
to
8191d6e
Compare
cecille
approved these changes
Mar 27, 2024
PR #32757: Size comparison from fe889bd to 8191d6e Full report (13 builds for cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
bzbarsky-apple
force-pushed
the
add-namespace-header-lint
branch
from
March 27, 2024 18:07
8191d6e
to
a1a3bae
Compare
PR #32757: Size comparison from 60b6beb to a1a3bae Increases (1 build for linux)
Decreases (1 build for linux)
Full report (20 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg, stm32)
|
bzbarsky-apple
force-pushed
the
add-namespace-header-lint
branch
3 times, most recently
from
March 27, 2024 19:04
eb92eb3
to
7a75970
Compare
PR #32757: Size comparison from 60b6beb to 7a75970 Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
force-pushed
the
add-namespace-header-lint
branch
from
March 27, 2024 21:00
7a75970
to
d798b1b
Compare
PR #32757: Size comparison from 60b6beb to d798b1b Increases (1 build for linux)
Decreases (1 build for linux)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
bzbarsky-apple
force-pushed
the
add-namespace-header-lint
branch
from
March 27, 2024 21:48
d798b1b
to
39cbb2f
Compare
PR #32757: Size comparison from ef01670 to 39cbb2f Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Mar 28, 2024
We had all sorts of things using the wrong namespaces because everything was being imported into multiple namespaces if things happened to include certain headers. Remove the "using namespace" bits in core headers, fix the resulting compile issues, add a lint so people stop doing that.
bzbarsky-apple
force-pushed
the
add-namespace-header-lint
branch
from
March 28, 2024 16:28
39cbb2f
to
9068ae1
Compare
PR #32757: Size comparison from 0aa859a to 9068ae1 Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had all sorts of things using the wrong namespaces because everything was being imported into multiple namespaces if things happened to include certain headers. Remove the "using namespace" bits in core headers, fix the resulting compile issues, add a lint so people stop doing that.