-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Disable static destructors in Matter.framework #32745
Merged
mergify
merged 3 commits into
project-chip:master
from
ksperling-apple:darwin-framework-no-static-destructors
Mar 27, 2024
Merged
Darwin: Disable static destructors in Matter.framework #32745
mergify
merged 3 commits into
project-chip:master
from
ksperling-apple:darwin-framework-no-static-destructors
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also propagate C/C++ flags from Xcode into the build.
PR #32745: Size comparison from f15d3ae to fab44f9 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
March 27, 2024 08:06
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
March 27, 2024 08:06
ksperling-apple
force-pushed
the
darwin-framework-no-static-destructors
branch
from
March 27, 2024 09:11
51f013b
to
470ff50
Compare
PR #32745: Size comparison from f15d3ae to 470ff50 Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
ksperling-apple
force-pushed
the
darwin-framework-no-static-destructors
branch
from
March 27, 2024 10:06
470ff50
to
1c397d2
Compare
PR #32745: Size comparison from f15d3ae to 1c397d2 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
Mar 27, 2024
ksperling-apple
added a commit
to ksperling-apple/connectedhomeip
that referenced
this pull request
Apr 8, 2024
This was missed in project-chip#32745 when adding -fno-c++-static-destructors, since that flag does not carry through to lazily initialized chip::Global instances.
ksperling-apple
added a commit
that referenced
this pull request
Apr 9, 2024
* Darwin: Don't stop/start the stack when creating a controller * Keep refactorings in place but retain current behavior for now * Darwin: Enable CHIP_CONFIG_GLOBALS_NO_DESTRUCT=1 This was missed in #32745 when adding -fno-c++-static-destructors, since that flag does not carry through to lazily initialized chip::Global instances.
shaoltan-amazon
pushed a commit
to shaoltan-amazon/connectedhomeip
that referenced
this pull request
Apr 10, 2024
…ect-chip#32845) * Darwin: Don't stop/start the stack when creating a controller * Keep refactorings in place but retain current behavior for now * Darwin: Enable CHIP_CONFIG_GLOBALS_NO_DESTRUCT=1 This was missed in project-chip#32745 when adding -fno-c++-static-destructors, since that flag does not carry through to lazily initialized chip::Global instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also propagate C/C++ flags from Xcode into the build.