Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] Remove StartupMetricsCollection from fw init #32744

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[Darwin] Remove StartupMetricsCollection from fw init #32744

merged 1 commit into from
Mar 27, 2024

Conversation

anush-apple
Copy link
Contributor

  • MTRFrameworkInit was initializing metrics collector but if controller factory is never created tracing backend will crash on system exit.
  • Remove the unbalanced init and rely on controller to register and unregister the backend
  • Added more logging on shutdown

@anush-apple
[Darwin] Remove StartupMetricsCollection from fw init
4a9ad29 
- MTRFrameworkInit was initializing metrics collector but if
  controller factory is never created tracing backend will crash on
  system exit.
- Remove the unbalanced init and rely on controller to register and
  unregister the backend
- Added more logging on shutdown
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

PR #32744: Size comparison from f15d3ae to 4a9ad29

Decreases (1 build for efr32)
platform target config section f15d3ae 4a9ad29 change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 934944 934936 -8 -0.0
.text 735540 735532 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section f15d3ae 4a9ad29 change % change
bl602 lighting-app bl602 (read/write) 1438370 1438370 0 0.0
.bss 85360 85360 0 0.0
.data 9504 9504 0 0.0
.rodata 158492 158492 0 0.0
.text 1104362 1104362 0 0.0
bl602+mfd (read/write) 1452786 1452786 0 0.0
.bss 85520 85520 0 0.0
.data 9480 9480 0 0.0
.rodata 157452 157452 0 0.0
.text 1119680 1119680 0 0.0
bl602+rpc (read/write) 1486010 1486010 0 0.0
.bss 93392 93392 0 0.0
.data 9880 9880 0 0.0
.rodata 166060 166060 0 0.0
.text 1136008 1136008 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1202823 1202823 0 0.0
.bss 11133 11133 0 0.0
.data 3688 3688 0 0.0
.rodata 107844 107844 0 0.0
.text 973284 973284 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1213895 1213895 0 0.0
.bss 11309 11309 0 0.0
.data 3664 3664 0 0.0
.rodata 106784 106784 0 0.0
.text 985294 985294 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1294571 1294571 0 0.0
.bss 19613 19613 0 0.0
.data 4224 4224 0 0.0
.rodata 123216 123216 0 0.0
.text 1048248 1048248 0 0.0
bl706-eth (read/write) 1020505 1020505 0 0.0
.bss 23708 23708 0 0.0
.data 3264 3264 0 0.0
.rodata 101176 101176 0 0.0
.text 764378 764378 0 0.0
bl706-wifi (read/write) 1255134 1255134 0 0.0
.bss 10577 10577 0 0.0
.data 3696 3696 0 0.0
.rodata 122176 122176 0 0.0
.text 996254 996254 0 0.0
bl702l lighting-app bl702l (read/write) 1172924 1172924 0 0.0
.bss 16328 16328 0 0.0
.data 5048 5048 0 0.0
.rodata 101848 101848 0 0.0
.text 966394 966394 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1183816 1183816 0 0.0
.bss 16504 16504 0 0.0
.data 5032 5032 0 0.0
.rodata 100788 100788 0 0.0
.text 978716 978716 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 774716 774716 0 0.0
(read/write) 168648 168648 0 0.0
.bss 90636 90636 0 0.0
.data 3568 3568 0 0.0
.rodata 82116 82116 0 0.0
.text 692332 692332 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 791092 791092 0 0.0
(read/write) 178896 178896 0 0.0
.bss 100884 100884 0 0.0
.data 3568 3568 0 0.0
.rodata 76292 76292 0 0.0
.text 714532 714532 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 779780 779780 0 0.0
(read/write) 173336 173336 0 0.0
.bss 95324 95324 0 0.0
.data 3568 3568 0 0.0
.rodata 103052 103052 0 0.0
.text 676460 676460 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 731972 731972 0 0.0
(read/write) 167616 167616 0 0.0
.bss 89368 89368 0 0.0
.data 3560 3560 0 0.0
.rodata 77780 77780 0 0.0
.text 653924 653924 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 717572 717572 0 0.0
(read/write) 167824 167824 0 0.0
.bss 89592 89592 0 0.0
.data 3552 3552 0 0.0
.rodata 73556 73556 0 0.0
.text 643748 643748 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 584242 584242 0 0.0
(read/write) 208000 208000 0 0.0
.bss 201228 201228 0 0.0
.data 1648 1648 0 0.0
.rodata 86906 86906 0 0.0
.text 495212 495212 0 0.0
lock CC3235SF_LAUNCHXL (read only) 629490 629490 0 0.0
(read/write) 208344 208344 0 0.0
.bss 201720 201720 0 0.0
.data 1504 1504 0 0.0
.rodata 107354 107354 0 0.0
.text 520012 520012 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569531 569531 0 0.0
.app_xip_area 459269 459269 0 0.0
.bss 65088 65088 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552171 552171 0 0.0
.app_xip_area 437149 437149 0 0.0
.bss 69840 69840 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572387 572387 0 0.0
.app_xip_area 463629 463629 0 0.0
.bss 63624 63624 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565243 565243 0 0.0
.app_xip_area 453205 453205 0 0.0
.bss 66824 66824 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 934944 934936 -8 -0.0
.bss 197976 197976 0 0.0
.data 1404 1404 0 0.0
.text 735540 735532 -8 -0.0
BRD4187C (read/write) 1111704 1111704 0 0.0
.bss 195184 195184 0 0.0
.data 3424 3424 0 0.0
.text 913076 913076 0 0.0
lock-app BRD4161A+wf200 (read/write) 1123660 1123660 0 0.0
.bss 186804 186804 0 0.0
.data 2808 2808 0 0.0
.text 934028 934028 0 0.0
window-app BRD4187C (read/write) 1159064 1159064 0 0.0
.bss 167592 167592 0 0.0
.data 3336 3336 0 0.0
.text 988116 988116 0 0.0
esp32 all-clusters-app c3devkit (read only) 1211908 1211908 0 0.0
(read/write) 1749824 1749824 0 0.0
.dram0.bss 74328 74328 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252336 252336 0 0.0
.flash.text 1211908 1211908 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1254007 1254007 0 0.0
(read/write) 536424 536424 0 0.0
.dram0.bss 81264 81264 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284060 284060 0 0.0
.flash.text 1247843 1247843 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 605312 605312 0 0.0
(read/write) 79480 79480 0 0.0
.bss 67308 67308 0 0.0
.data 2188 2188 0 0.0
.text 604776 604776 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 700412 700412 0 0.0
.bss 71156 71156 0 0.0
.data 2856 2856 0 0.0
.text 587016 587016 0 0.0
light k32w0+release (read only) 607272 607272 0 0.0
(read/write) 79340 79340 0 0.0
.bss 67164 67164 0 0.0
.data 2192 2192 0 0.0
.text 606736 606736 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 791880 791880 0 0.0
.bss 80636 80636 0 0.0
.data 2056 2056 0 0.0
.text 669824 669824 0 0.0
linux air-purifier-app debug (read only) 2624269 2624269 0 0.0
(read/write) 129048 129048 0 0.0
.bss 46544 46544 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 74312 74312 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 184976 184976 0 0.0
.text 2261717 2261717 0 0.0
all-clusters-app debug (read only) 5930417 5930417 0 0.0
(read/write) 480520 480520 0 0.0
.bss 134848 134848 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 333688 333688 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1408 1408 0 0.0
.rodata 349712 349712 0 0.0
.text 5147219 5147219 0 0.0
all-clusters-minimal-app debug (read only) 5211297 5211297 0 0.0
(read/write) 236472 236472 0 0.0
.bss 127680 127680 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 97272 97272 0 0.0
.dynamic 624 624 0 0.0
.got 5272 5272 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 288778 288778 0 0.0
.text 4687699 4687699 0 0.0
bridge-app debug (read only) 4605665 4605665 0 0.0
(read/write) 217384 217384 0 0.0
.bss 118208 118208 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86208 86208 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 229354 229354 0 0.0
.text 4155907 4155907 0 0.0
chip-tool debug (read only) 12055361 12055361 0 0.0
(read/write) 522016 522016 0 0.0
.bss 94424 94424 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 415240 415240 0 0.0
.dynamic 624 624 0 0.0
.got 5760 5760 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 449689 449689 0 0.0
.text 10898611 10898611 0 0.0
chip-tool-ipv6only arm64 (read only) 11373988 11373988 0 0.0
(read/write) 588392 588392 0 0.0
.bss 103528 103528 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455128 455128 0 0.0
.dynamic 512 512 0 0.0
.got 17000 17000 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 355124 355124 0 0.0
.text 10139048 10139048 0 0.0
lighting-app debug+rpc+ui (read only) 5529241 5529241 0 0.0
(read/write) 226112 226112 0 0.0
.bss 119144 119144 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 94576 94576 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 354356 354356 0 0.0
.text 4928099 4928099 0 0.0
lock-app debug (read only) 4672977 4672977 0 0.0
(read/write) 204936 204936 0 0.0
.bss 113632 113632 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 80456 80456 0 0.0
.dynamic 624 624 0 0.0
.got 5192 5192 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 255274 255274 0 0.0
.text 4205939 4205939 0 0.0
ota-provider-app debug (read only) 4300433 4300433 0 0.0
(read/write) 193432 193432 0 0.0
.bss 113312 113312 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 69840 69840 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 208394 208394 0 0.0
.text 3898851 3898851 0 0.0
ota-requestor-app debug (read only) 4429905 4429905 0 0.0
(read/write) 197800 197800 0 0.0
.bss 114208 114208 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 72944 72944 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 214538 214538 0 0.0
.text 4017635 4017635 0 0.0
shell debug (read only) 2898409 2898409 0 0.0
(read/write) 156472 156472 0 0.0
.bss 62768 62768 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 86496 86496 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 185664 185664 0 0.0
.text 2539314 2539314 0 0.0
thermostat-no-ble arm64 (read only) 4419060 4419060 0 0.0
(read/write) 243904 243904 0 0.0
.bss 121832 121832 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 103680 103680 0 0.0
.dynamic 512 512 0 0.0
.got 8624 8624 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 159756 159756 0 0.0
.text 3924440 3924440 0 0.0
tv-app debug (read only) 5737841 5737841 0 0.0
(read/write) 352832 352832 0 0.0
.bss 244400 244400 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 94584 94584 0 0.0
.dynamic 624 624 0 0.0
.got 5488 5488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 292138 292138 0 0.0
.text 5203315 5203315 0 0.0
tv-casting-app debug (read only) 9872969 9872969 0 0.0
(read/write) 340416 340416 0 0.0
.bss 156272 156272 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174240 174240 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 382968 382968 0 0.0
.text 9024147 9024147 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2533072 2533072 0 0.0
.bss 220480 220480 0 0.0
.data 5216 5216 0 0.0
.text 1495756 1495756 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1062888 1062888 0 0.0
bss 133119 133119 0 0.0
rodata 102648 102648 0 0.0
text 779912 779912 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1224252 1224252 0 0.0
bss 127155 127155 0 0.0
rodata 151200 151200 0 0.0
text 795872 795872 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1010464 1010464 0 0.0
bss 131977 131977 0 0.0
rodata 89912 89912 0 0.0
text 741248 741248 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834416 834416 0 0.0
(read/write) 1797676 1797676 0 0.0
.bss 196244 196244 0 0.0
.data 2680 2680 0 0.0
.text 1590364 1590364 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837568 837568 0 0.0
(read/write) 1719748 1719748 0 0.0
.bss 193124 193124 0 0.0
.data 2648 2648 0 0.0
.text 1515588 1515588 0 0.0
light cy8ckit_062s2_43012 (read only) 844296 844296 0 0.0
(read/write) 1638852 1638852 0 0.0
.bss 186588 186588 0 0.0
.data 2456 2456 0 0.0
.text 1441420 1441420 0 0.0
lock cy8ckit_062s2_43012 (read only) 817136 817136 0 0.0
(read/write) 1668460 1668460 0 0.0
.bss 213748 213748 0 0.0
.data 2456 2456 0 0.0
.text 1443868 1443868 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130424 1130424 0 0.0
.bss 102488 102488 0 0.0
.data 836 836 0 0.0
.text 642808 642808 0 0.0
lock-app qpg6105+debug (read/write) 1090392 1090392 0 0.0
.bss 97232 97232 0 0.0
.data 856 856 0 0.0
.text 602772 602772 0 0.0
stm32 light STM32WB5MM-DK (read/write) 601637 601637 0 0.0
.bss 128352 128352 0 0.0
.data 676 676 0 0.0
.rodata 79764 79764 0 0.0
.text 383112 383112 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824426 824426 0 0.0
bss 49692 49692 0 0.0
text 617140 617140 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1093288 1093288 0 0.0
bss 101812 101812 0 0.0
text 794262 794262 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1050744 1050744 0 0.0
bss 110116 110116 0 0.0
text 765576 765576 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 911464 911464 0 0.0
bss 93148 93148 0 0.0
text 653060 653060 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 826058 826058 0 0.0
bss 49740 49740 0 0.0
text 618830 618830 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 931768 931768 0 0.0
bss 77740 77740 0 0.0
text 698980 698980 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1074644 1074644 0 0.0
bss 100228 100228 0 0.0
text 778444 778444 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 904160 904160 0 0.0
bss 69204 69204 0 0.0
text 654234 654234 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 930444 930444 0 0.0
bss 92728 92728 0 0.0
text 672138 672138 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 828782 828782 0 0.0
bss 49848 49848 0 0.0
text 621892 621892 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 792356 792356 0 0.0
bss 56048 56048 0 0.0
text 592570 592570 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 677312 677312 0 0.0
bss 73672 73672 0 0.0
text 462570 462570 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833586 833586 0 0.0
bss 51372 51372 0 0.0
text 625200 625200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 852317 852317 0 0.0
bss 59524 59524 0 0.0
text 637280 637280 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 818012 818012 0 0.0
bss 56336 56336 0 0.0
text 612254 612254 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 836104 836104 0 0.0
bss 68112 68112 0 0.0
text 627512 627512 0 0.0

@mergify mergify bot merged commit c047b59 into project-chip:master Mar 27, 2024
68 checks passed
@anush-apple anush-apple deleted the darwin-unbalanced-metrics-backend branch March 27, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@arkq arkq Awaiting requested review from arkq

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anush-apple @ksperling-apple @woody-apple