-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use curl
to download github artifacts during bloat report
#32666
Merged
mergify
merged 4 commits into
project-chip:master
from
andy31415:use_curl_for_artifacts
Mar 21, 2024
Merged
Use curl
to download github artifacts during bloat report
#32666
mergify
merged 4 commits into
project-chip:master
from
andy31415:use_curl_for_artifacts
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver the documented curl way does
arkq
approved these changes
Mar 21, 2024
Contributor
Author
PR #32666: Size comparison from 7f14133 to 44b08e8 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Mar 21, 2024
yunhanw-google
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #32656
I am unsure why the ghapi does not work, however that is a 3rd party library so there may be bugs.
I tried to report a bug to github and during that I wanted to describe reproduction steps in terms of what they documented in https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28#download-an-artifact ... however it turns out curl actually worked.
Since curl works, just started using that instead.