-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the work directory path in the bootstrap cache key (to account for containerized/non-containerized builds) #32638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksperling-apple
force-pushed
the
ci-cache-fix
branch
3 times, most recently
from
March 20, 2024 04:52
3f2c7e4
to
8010adf
Compare
ksperling-apple
force-pushed
the
ci-cache-fix
branch
from
March 20, 2024 05:03
8010adf
to
05f3072
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
March 20, 2024 05:11
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
March 20, 2024 05:11
bzbarsky-apple
approved these changes
Mar 20, 2024
andy31415
approved these changes
Mar 20, 2024
andy31415
changed the title
Bootstrap cache issue
Include the work directory path in the bootstrap cache key (to account for containerized/non-containerized builds)
Mar 20, 2024
yunhanw-google
approved these changes
Mar 20, 2024
Handle caching and log upload directly within the bootstrap action, and don't perform the actual bootstrap if we have a cache hit. Include the platform name in the cache key.
This is because the bootstrapped Pigweed environment does not like to be relocated. Also don't touch submodules in bootstrap, other than ensuring that Pigweed is available.
ksperling-apple
force-pushed
the
ci-cache-fix
branch
from
March 25, 2024 01:13
05f3072
to
caf9b40
Compare
ksperling-apple
commented
Mar 25, 2024
PR #32638: Size comparison from 437c574 to caf9b40 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
We may start using macos-14 runners in the future which are arm.
PR #32638: Size comparison from 437c574 to 8ff2696 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache key needs to include the work directory path (which differs between containerized and non-containerized builds).
Also don't touch submodules during bootstrap, since we have a separate script / step for that.
Includes changes from #32610 that were reverted due to cache issues.