Implement openSSL based AES 256 CCM #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerickson
requested review from
dougsteed,
emargolis,
pan-apple and
woody-apple
bhaskar-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk and
tpmanley
as code owners
|
@balducci-apple - please take a look. |
|
Figure out why github build is failing |
woody-apple
requested changes
Apr 10, 2020
There was a problem hiding this comment.
Build is failing:
https://github.com/bhaskar-apple/connectedhomeip/runs/575597212
Making all in crypto
4637
CC libChipCrypto_a-CHIPOpenSSL.o
4638
../../../../src/crypto/CHIPOpenSSL.c:7:10: fatal error: CHIPCrypto.h: No such file or directory
4639
#include "CHIPCrypto.h"
4640
^~~~~~~~~~~~~~
4641
| "name": "CHIP openSSL Tests", | ||
| "type": "cppdbg", | ||
| "request": "launch", | ||
| "program": "${workspaceFolder}/build/x86_64-unknown-linux-gnu/src/crypto/tests/TestOpenSSLCrypto", |
There was a problem hiding this comment.
is build/x86_64-unknown-linux-gnu working for you?
reason I ask is that tasks.json has been changed to build into build/default
|
|
||
| #define kKeyLengthInBits 256 | ||
|
|
||
| bool _isValidTagLength(size_t tag_length) |
There was a problem hiding this comment.
can this be static (i.e. not exported?)
|
|
||
| static void TestAES_CCM_256EncryptTestVectors(nlTestSuite * inSuite, void * inContext) | ||
| { | ||
| int numOfTestVectors = sizeof(ccm_test_vectors) / sizeof(ccm_test_vectors[0]); |
There was a problem hiding this comment.
I think one of our nl friends has ArraySize()
| * Test Suite. It lists all the test functions. | ||
| */ | ||
|
|
||
| // clang-format off |
|
Closing this as the commit history on this one is too messed up and I am having a hard time reconciling it. |
mlepage-google
added a commit
to mlepage-google/connectedhomeip
that referenced
this pull request
Nov 24, 2021
Field identifiers were not being used. Instead, the order of field identifiers was used, with ordinal (0 to N-1) indexes. This is likely true of other code generated elements, but this PR only fixes it for struct items. This PR requires PR project-chip#326 in the third_party/zap/repo to function, as that PR actually includes the field identifier in the query results. Tested by running Matter cert tests, and also by inspecting the generated code for correctness.
andy31415
added a commit
that referenced
this pull request
Nov 25, 2021
* Use field identifiers when code gen struct items Field identifiers were not being used. Instead, the order of field identifiers was used, with ordinal (0 to N-1) indexes. This is likely true of other code generated elements, but this PR only fixes it for struct items. This PR requires PR #326 in the third_party/zap/repo to function, as that PR actually includes the field identifier in the query results. Tested by running Matter cert tests, and also by inspecting the generated code for correctness. * Update zap submodule to latest * Update a few generated zap files Re-ran cert tests. * Restyling Why are we styling generated code?! * Revert zap repo update * Update zap to latest zap version * Regen zap with the new zap version Co-authored-by: Andrei Litvin <[email protected]>
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Dec 19, 2022
…eature/CCP_BLE_bringup to RC_1.0.2-1.0 Merge in WMN_TOOLS/matter from cherry_pick/tinycrypt_changes to RC_1.0.2-1.0 Squashed commit of the following: commit 003a64f0f3d3e5f22db764fd9bb8293d5ad4a00d Author: ShubhamNarayanrao Malasane <[email protected]> Date: Wed Nov 30 14:54:14 2022 +0000 Pull request project-chip#326: Feature/shubham tinycrypt Merge in WMN_TOOLS/matter from feature/shubham_tinycrypt to feature/CCP_BLE_bringup Squashed commit of the following: commit 40c432ef8ac2a7ff34940c42f969bc70c1af5068 Author: ShubhamMalasane <[email protected]> Date: Fri Nov 25 13:11:22 2022 +0530 modified gni file commit 9bb17ab4eeefa1d65929ddd81b111840c5d7bc17 Author: ShubhamMalasane <[email protected]> Date: Thu Nov 24 14:20:07 2022 +0530 remove changes from platform specific file commit 6faa303012a0211ef0805b08cfb253f09a6ff624 Author: ShubhamMalasane <[email protected]> Date: Wed Nov 23 22:43:07 2022 +0530 tinycrypt changes
jamesharrow
pushed a commit
that referenced
this pull request
Dec 4, 2023
DSRR-160-B-Implement_SDK_DEM_Delegate Approved-by: James Harrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Implement openSSL based AES-256 CCM
Summary of Changes
src/crypto/CHIPCryptoPALOpenSSL.cpp. Note I changed the existingCstub implementation file to beC++as some of the pulled in headers areC++e.g.CHIP_ERRORlibChipCryptoOpenSSLinsrc/crypto/Makefile.amthat implements these common crypto primitives.src/crypto/tests/CHIPCryptoPALOpenSSLTest.cpp.TestOpenSSLCryptofor the tests.fixes : #256