Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop forcing a particular interface ID when sending response messages. #32581

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Stop forcing a particular interface ID when sending response messages. #32581

merged 1 commit into from
Mar 15, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

Because we were storing the PeerAddress in the session when getting a message, we effectively pinned sessions to particular interface ids at that point.

This can lead to routing failures. We should only be pinning to interface IDs for link-local addresses, just like we do for initial IP resolution via DNS-SD.

@bzbarsky-apple
Stop forcing a particular interface ID when sending response messages.
cf57a6b 
Because we were storing the PeerAddress in the session when getting a message,
we effectively pinned sessions to particular interface ids at that point.

This can lead to routing failures.  We should only be pinning to interface IDs
for link-local addresses, just like we do for initial IP resolution via DNS-SD.
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

PR #32581: Size comparison from 84970a0 to cf57a6b

Increases above 0.2%:

platform target config section 84970a0 cf57a6b change % change
linux chip-tool-ipv6only arm64 (read/write) 585072 589008 3936 0.7
Increases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 84970a0 cf57a6b change % change
bl602 lighting-app bl602 (read/write) 1437690 1437786 96 0.0
.text 1103746 1103848 102 0.0
bl602+mfd (read/write) 1452106 1452210 104 0.0
.text 1119064 1119166 102 0.0
bl602+rpc (read/write) 1485330 1485434 104 0.0
.text 1135392 1135494 102 0.0
bl702 lighting-app bl702 (read/write) 1202131 1202231 100 0.0
.text 972646 972748 102 0.0
bl702+mfd (read/write) 1213183 1213287 104 0.0
.text 984656 984758 102 0.0
bl702+rpc (read/write) 1293879 1293979 100 0.0
.text 1047610 1047712 102 0.0
bl706-eth (read/write) 1020101 1020201 100 0.0
.text 764030 764132 102 0.0
bl706-wifi (read/write) 1254610 1254786 176 0.0
.text 995802 995978 176 0.0
bl702l lighting-app bl702l (read/write) 1171704 1171808 104 0.0
.text 965744 965846 102 0.0
bl702l+mfd (read/write) 1183112 1183212 100 0.0
.text 978066 978168 102 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 773996 774060 64 0.0
.text 691912 691976 64 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 790404 790484 80 0.0
.text 714136 714216 80 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 779076 779140 64 0.0
.text 676056 676120 64 0.0
pump-app LP_EM_CC1354P10_6 (read only) 731340 731412 72 0.0
.text 653592 653664 72 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 716852 716924 72 0.0
.text 643320 643392 72 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 583314 583426 112 0.0
.text 494588 494700 112 0.0
lock CC3235SF_LAUNCHXL (read only) 628586 628698 112 0.0
.text 519404 519516 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569115 569203 88 0.0
.app_xip_area 458869 458957 88 0.0
lock cyw930739m2evb_01 (read/write) 551787 551875 88 0.0
.app_xip_area 436781 436869 88 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571947 572011 64 0.0
.app_xip_area 463205 463269 64 0.0
switch cyw930739m2evb_01 (read/write) 564851 564939 88 0.0
.app_xip_area 452829 452917 88 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 933464 933584 120 0.0
.text 734084 734204 120 0.0
BRD4187C (read/write) 1110368 1110424 56 0.0
.text 911756 911812 56 0.0
lock-app BRD4161A+wf200 (read/write) 1122748 1122844 96 0.0
.text 933140 933236 96 0.0
window-app BRD4187C (read/write) 1157048 1157168 120 0.0
.text 986276 986396 120 0.0
esp32 all-clusters-app c3devkit (read only) 1211602 1211696 94 0.0
.flash.text 1211602 1211696 94 0.0
m5stack (read only) 1253847 1253879 32 0.0
.flash.text 1247683 1247715 32 0.0
k32w contact k32w0+release (read only) 606304 606384 80 0.0
.text 605768 605848 80 0.0
k32w1+release (read/write) 747712 747792 80 0.0
.text 626312 626392 80 0.0
light k32w0+release (read only) 610056 610120 64 0.0
.text 609520 609584 64 0.0
k32w1+release (read/write) 790492 790564 72 0.0
.text 668496 668568 72 0.0
lock k32w0+release (read only) 589856 589920 64 0.0
.text 589320 589384 64 0.0
linux air-purifier-app debug (read only) 2617181 2617405 224 0.0
.text 2254709 2254933 224 0.0
all-clusters-app debug (read only) 5923601 5923857 256 0.0
.text 5140483 5140739 256 0.0
all-clusters-minimal-app debug (read only) 5204113 5204369 256 0.0
.text 4680659 4680915 256 0.0
bridge-app debug (read only) 4598561 4598801 240 0.0
.text 4148883 4149123 240 0.0
chip-tool debug (read only) 12040505 12040745 240 0.0
.text 1088568 10885923 240 0.0
chip-tool-ipv6only arm64 (read only) 11365004 11365164 160 0.0
(read/write) 585072 589008 3936 0.7
.text 10131640 10131800 160 0.0
lighting-app debug+rpc+ui (read only) 5522169 5522409 240 0.0
.text 4920947 4921187 240 0.0
lock-app debug (read only) 4665921 4666161 240 0.0
.text 4198963 4199203 240 0.0
ota-provider-app debug (read only) 4297769 4298025 256 0.0
.text 3896915 3897171 256 0.0
ota-requestor-app debug (read only) 4427209 4427449 240 0.0
.text 4015699 4015939 240 0.0
shell debug (read only) 2891321 2891561 240 0.0
.text 2532306 2532546 240 0.0
thermostat-no-ble arm64 (read only) 4417364 4417540 176 0.0
.text 3923320 3923496 176 0.0
tv-app debug (read only) 5712929 5713169 240 0.0
.text 5180339 5180579 240 0.0
tv-casting-app debug (read only) 9865145 9865385 240 0.0
.text 9016371 9016611 240 0.0
mbed lock-app-release cy8cproto_062_4343w (read/write) 2532304 2532432 128 0.0
.text 1494988 1495116 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1103160 1103224 64 0.0
text 811552 811620 68 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1222408 1222504 96 0.0
text 807148 807236 88 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1051408 1051472 64 0.0
text 773592 773660 68 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1796788 1796900 112 0.0
.text 1589500 1589612 112 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1718820 1718948 128 0.0
.text 1514676 1514804 128 0.0
light cy8ckit_062s2_43012 (read/write) 1637948 1638076 128 0.0
.text 1440532 1440660 128 0.0
lock cy8ckit_062s2_43012 (read/write) 1667588 1667716 128 0.0
.text 1443020 1443148 128 0.0
qpg lighting-app qpg6105+debug (read/write) 1129980 1130052 72 0.0
.text 642360 642432 72 0.0
lock-app qpg6105+debug (read/write) 1089948 1090012 64 0.0
.text 602332 602396 64 0.0
stm32 light STM32WB5MM-DK (read/write) 601201 601273 72 0.0
.text 382744 382816 72 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 823954 824034 80 0.0
text 616750 616836 86 0.0
all-clusters-app tlsr9518adk80d (read/write) 1092800 1092880 80 0.0
text 793858 793944 86 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1050264 1050352 88 0.0
text 765180 765266 86 0.0
bridge-app tlsr9518adk80d (read/write) 910976 911064 88 0.0
text 652656 652742 86 0.0
contact-sensor-app tlsr9528a_retention (read/write) 825578 825666 88 0.0
text 618440 618526 86 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 931288 931376 88 0.0
text 698584 698670 86 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1074156 1074244 88 0.0
text 778044 778130 86 0.0
lock-app-dfu tlsr9528a (read/write) 903688 903776 88 0.0
text 653852 653938 86 0.0
ota-requestor-app tlsr9518adk80d (read/write) 929956 930036 80 0.0
text 671734 671820 86 0.0
pump-app tlsr9258a_retention (read/write) 828310 828398 88 0.0
text 621502 621588 86 0.0
pump-controller-app tlsr9518adk80d (read/write) 791884 791964 80 0.0
text 592178 592264 86 0.0
shell tlsr9518adk80d (read/write) 677224 677312 88 0.0
text 462484 462570 86 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 833114 833202 88 0.0
text 624810 624896 86 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 851845 851933 88 0.0
text 636888 636974 86 0.0
thermostat tlsr9518adk80d (read/write) 817532 817620 88 0.0
text 611862 611948 86 0.0
window-covering tlsr9258a (read/write) 835624 835712 88 0.0
text 627116 627202 86 0.0
Decreases (1 build for linux)
platform target config section 84970a0 cf57a6b change % change
linux thermostat-no-ble arm64 (read/write) 245592 245416 -176 -0.1
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 84970a0 cf57a6b change % change
bl602 lighting-app bl602 (read/write) 1437690 1437786 96 0.0
.bss 85352 85352 0 0.0
.data 9496 9496 0 0.0
.rodata 158448 158448 0 0.0
.text 1103746 1103848 102 0.0
bl602+mfd (read/write) 1452106 1452210 104 0.0
.bss 85512 85512 0 0.0
.data 9472 9472 0 0.0
.rodata 157408 157408 0 0.0
.text 1119064 1119166 102 0.0
bl602+rpc (read/write) 1485330 1485434 104 0.0
.bss 93384 93384 0 0.0
.data 9872 9872 0 0.0
.rodata 166016 166016 0 0.0
.text 1135392 1135494 102 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1202131 1202231 100 0.0
.bss 11133 11133 0 0.0
.data 3680 3680 0 0.0
.rodata 107800 107800 0 0.0
.text 972646 972748 102 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1213183 1213287 104 0.0
.bss 11309 11309 0 0.0
.data 3656 3656 0 0.0
.rodata 106740 106740 0 0.0
.text 984656 984758 102 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1293879 1293979 100 0.0
.bss 19613 19613 0 0.0
.data 4216 4216 0 0.0
.rodata 123172 123172 0 0.0
.text 1047610 1047712 102 0.0
bl706-eth (read/write) 1020101 1020201 100 0.0
.bss 23708 23708 0 0.0
.data 3256 3256 0 0.0
.rodata 101132 101132 0 0.0
.text 764030 764132 102 0.0
bl706-wifi (read/write) 1254610 1254786 176 0.0
.bss 10577 10577 0 0.0
.data 3688 3688 0 0.0
.rodata 122132 122132 0 0.0
.text 995802 995978 176 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1171704 1171808 104 0.0
.bss 16328 16328 0 0.0
.data 5040 5040 0 0.0
.rodata 101804 101804 0 0.0
.text 965744 965846 102 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1183112 1183212 100 0.0
.bss 16504 16504 0 0.0
.data 5024 5024 0 0.0
.rodata 100744 100744 0 0.0
.text 978066 978168 102 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 773996 774060 64 0.0
(read/write) 168624 168624 0 0.0
.bss 90628 90628 0 0.0
.data 3560 3560 0 0.0
.rodata 81820 81820 0 0.0
.text 691912 691976 64 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 790404 790484 80 0.0
(read/write) 178872 178872 0 0.0
.bss 100876 100876 0 0.0
.data 3560 3560 0 0.0
.rodata 76004 76004 0 0.0
.text 714136 714216 80 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 779076 779140 64 0.0
(read/write) 173312 173312 0 0.0
.bss 95316 95316 0 0.0
.data 3560 3560 0 0.0
.rodata 102756 102756 0 0.0
.text 676056 676120 64 0.0
pump-app LP_EM_CC1354P10_6 (read only) 731340 731412 72 0.0
(read/write) 167592 167592 0 0.0
.bss 89360 89360 0 0.0
.data 3552 3552 0 0.0
.rodata 77484 77484 0 0.0
.text 653592 653664 72 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 716852 716924 72 0.0
(read/write) 167800 167800 0 0.0
.bss 89584 89584 0 0.0
.data 3544 3544 0 0.0
.rodata 73268 73268 0 0.0
.text 643320 643392 72 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 583314 583426 112 0.0
(read/write) 207992 207992 0 0.0
.bss 201228 201228 0 0.0
.data 1640 1640 0 0.0
.rodata 86602 86602 0 0.0
.text 494588 494700 112 0.0
lock CC3235SF_LAUNCHXL (read only) 628586 628698 112 0.0
(read/write) 208336 208336 0 0.0
.bss 201720 201720 0 0.0
.data 1496 1496 0 0.0
.rodata 107058 107058 0 0.0
.text 519404 519516 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569115 569203 88 0.0
.app_xip_area 458869 458957 88 0.0
.bss 65080 65080 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551787 551875 88 0.0
.app_xip_area 436781 436869 88 0.0
.bss 69832 69832 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571947 572011 64 0.0
.app_xip_area 463205 463269 64 0.0
.bss 63616 63616 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564851 564939 88 0.0
.app_xip_area 452829 452917 88 0.0
.bss 66816 66816 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 933464 933584 120 0.0
.bss 197960 197960 0 0.0
.data 1396 1396 0 0.0
.text 734084 734204 120 0.0
BRD4187C (read/write) 1110368 1110424 56 0.0
.bss 195176 195176 0 0.0
.data 3416 3416 0 0.0
.text 911756 911812 56 0.0
lock-app BRD4161A+wf200 (read/write) 1122748 1122844 96 0.0
.bss 186788 186788 0 0.0
.data 2800 2800 0 0.0
.text 933140 933236 96 0.0
window-app BRD4187C (read/write) 1157048 1157168 120 0.0
.bss 167424 167424 0 0.0
.data 3328 3328 0 0.0
.text 986276 986396 120 0.0
esp32 all-clusters-app c3devkit (read only) 1211602 1211696 94 0.0
(read/write) 1749760 1749760 0 0.0
.dram0.bss 74320 74320 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 252288 252288 0 0.0
.flash.text 1211602 1211696 94 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1253847 1253879 32 0.0
(read/write) 536352 536352 0 0.0
.dram0.bss 81256 81256 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 284012 284012 0 0.0
.flash.text 1247683 1247715 32 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 606304 606384 80 0.0
(read/write) 79660 79660 0 0.0
.bss 67476 67476 0 0.0
.data 2200 2200 0 0.0
.text 605768 605848 80 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 747712 747792 80 0.0
.bss 79212 79212 0 0.0
.data 2816 2816 0 0.0
.text 626312 626392 80 0.0
light k32w0+release (read only) 610056 610120 64 0.0
(read/write) 79536 79536 0 0.0
.bss 67348 67348 0 0.0
.data 2204 2204 0 0.0
.text 609520 609584 64 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 790492 790564 72 0.0
.bss 80604 80604 0 0.0
.data 2032 2032 0 0.0
.text 668496 668568 72 0.0
lock k32w0+release (read only) 589856 589920 64 0.0
(read/write) 77524 77524 0 0.0
.bss 65388 65388 0 0.0
.data 2152 2152 0 0.0
.text 589320 589384 64 0.0
linux air-purifier-app debug (read only) 2617181 2617405 224 0.0
(read/write) 128960 128960 0 0.0
.bss 46544 46544 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74248 74248 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 185008 185008 0 0.0
.text 2254709 2254933 224 0.0
all-clusters-app debug (read only) 5923601 5923857 256 0.0
(read/write) 480432 480432 0 0.0
.bss 134848 134848 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 333640 333640 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1384 1384 0 0.0
.rodata 349744 349744 0 0.0
.text 5140483 5140739 256 0.0
all-clusters-minimal-app debug (read only) 5204113 5204369 256 0.0
(read/write) 236384 236384 0 0.0
.bss 127680 127680 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 97208 97208 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 288746 288746 0 0.0
.text 4680659 4680915 256 0.0
bridge-app debug (read only) 4598561 4598801 240 0.0
(read/write) 217232 217232 0 0.0
.bss 118176 118176 0 0.0
.data 6208 6208 0 0.0
.data.rel.ro 86144 86144 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 229386 229386 0 0.0
.text 4148883 4149123 240 0.0
chip-tool debug (read only) 12040505 12040745 240 0.0
(read/write) 521512 521512 0 0.0
.bss 94424 94424 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 414744 414744 0 0.0
.dynamic 624 624 0 0.0
.got 5768 5768 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 449049 449049 0 0.0
.text 1088568 10885923 240 0.0
chip-tool-ipv6only arm64 (read only) 11365004 11365164 160 0.0
(read/write) 585072 589008 3936 0.7
.bss 103512 103512 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 454592 454592 0 0.0
.dynamic 512 512 0 0.0
.got 16976 16976 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 354956 354956 0 0.0
.text 10131640 10131800 160 0.0
lighting-app debug+rpc+ui (read only) 5522169 5522409 240 0.0
(read/write) 226024 226024 0 0.0
.bss 119144 119144 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94544 94544 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 354548 354548 0 0.0
.text 4920947 4921187 240 0.0
lock-app debug (read only) 4665921 4666161 240 0.0
(read/write) 204816 204816 0 0.0
.bss 113600 113600 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80392 80392 0 0.0
.dynamic 624 624 0 0.0
.got 5200 5200 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 255306 255306 0 0.0
.text 4198963 4199203 240 0.0
ota-provider-app debug (read only) 4297769 4298025 256 0.0
(read/write) 193288 193288 0 0.0
.bss 113280 113280 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69776 69776 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207882 207882 0 0.0
.text 3896915 3897171 256 0.0
ota-requestor-app debug (read only) 4427209 4427449 240 0.0
(read/write) 197720 197720 0 0.0
.bss 114208 114208 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72896 72896 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 213994 213994 0 0.0
.text 4015699 4015939 240 0.0
shell debug (read only) 2891321 2891561 240 0.0
(read/write) 156352 156352 0 0.0
.bss 62736 62736 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86464 86464 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185696 185696 0 0.0
.text 2532306 2532546 240 0.0
thermostat-no-ble arm64 (read only) 4417364 4417540 176 0.0
(read/write) 245592 245416 -176 -0.1
.bss 121832 121832 0 0.0
.data 3376 3376 0 0.0
.data.rel.ro 103624 103624 0 0.0
.dynamic 512 512 0 0.0
.got 8616 8616 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 159404 159404 0 0.0
.text 3923320 3923496 176 0.0
tv-app debug (read only) 5712929 5713169 240 0.0
(read/write) 352584 352584 0 0.0
.bss 244368 244368 0 0.0
.data 6528 6528 0 0.0
.data.rel.ro 94424 94424 0 0.0
.dynamic 624 624 0 0.0
.got 5496 5496 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 290506 290506 0 0.0
.text 5180339 5180579 240 0.0
tv-casting-app debug (read only) 9865145 9865385 240 0.0
(read/write) 340296 340296 0 0.0
.bss 156272 156272 0 0.0
.data 2976 2976 0 0.0
.data.rel.ro 174176 174176 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5072 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 383032 383032 0 0.0
.text 9016371 9016611 240 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2532304 2532432 128 0.0
.bss 220472 220472 0 0.0
.data 5200 5200 0 0.0
.text 1494988 1495116 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1103160 1103224 64 0.0
bss 130855 130855 0 0.0
rodata 112928 112928 0 0.0
text 811552 811620 68 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1222408 1222504 96 0.0
bss 122945 122945 0 0.0
rodata 141792 141792 0 0.0
text 807148 807236 88 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1051408 1051472 64 0.0
bss 129713 129713 0 0.0
rodata 100288 100288 0 0.0
text 773592 773660 68 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834440 834440 0 0.0
(read/write) 1796788 1796900 112 0.0
.bss 196236 196236 0 0.0
.data 2664 2664 0 0.0
.text 1589500 1589612 112 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837584 837584 0 0.0
(read/write) 1718820 1718948 128 0.0
.bss 193116 193116 0 0.0
.data 2640 2640 0 0.0
.text 1514676 1514804 128 0.0
light cy8ckit_062s2_43012 (read only) 844312 844312 0 0.0
(read/write) 1637948 1638076 128 0.0
.bss 186580 186580 0 0.0
.data 2448 2448 0 0.0
.text 1440532 1440660 128 0.0
lock cy8ckit_062s2_43012 (read only) 817160 817160 0 0.0
(read/write) 1667588 1667716 128 0.0
.bss 213740 213740 0 0.0
.data 2440 2440 0 0.0
.text 1443020 1443148 128 0.0
qpg lighting-app qpg6105+debug (read/write) 1129980 1130052 72 0.0
.bss 102480 102480 0 0.0
.data 824 824 0 0.0
.text 642360 642432 72 0.0
lock-app qpg6105+debug (read/write) 1089948 1090012 64 0.0
.bss 97224 97224 0 0.0
.data 844 844 0 0.0
.text 602332 602396 64 0.0
stm32 light STM32WB5MM-DK (read/write) 601201 601273 72 0.0
.bss 128344 128344 0 0.0
.data 668 668 0 0.0
.rodata 79716 79716 0 0.0
.text 382744 382816 72 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823954 824034 80 0.0
bss 49684 49684 0 0.0
text 616750 616836 86 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1092800 1092880 80 0.0
bss 101804 101804 0 0.0
text 793858 793944 86 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1050264 1050352 88 0.0
bss 110108 110108 0 0.0
text 765180 765266 86 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 910976 911064 88 0.0
bss 93140 93140 0 0.0
text 652656 652742 86 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825578 825666 88 0.0
bss 49732 49732 0 0.0
text 618440 618526 86 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 931288 931376 88 0.0
bss 77732 77732 0 0.0
text 698584 698670 86 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1074156 1074244 88 0.0
bss 100220 100220 0 0.0
text 778044 778130 86 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 903688 903776 88 0.0
bss 69196 69196 0 0.0
text 653852 653938 86 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 929956 930036 80 0.0
bss 92720 92720 0 0.0
text 671734 671820 86 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 828310 828398 88 0.0
bss 49840 49840 0 0.0
text 621502 621588 86 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 791884 791964 80 0.0
bss 56040 56040 0 0.0
text 592178 592264 86 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 677224 677312 88 0.0
bss 73672 73672 0 0.0
text 462484 462570 86 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833114 833202 88 0.0
bss 51364 51364 0 0.0
text 624810 624896 86 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 851845 851933 88 0.0
bss 59516 59516 0 0.0
text 636888 636974 86 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 817532 817620 88 0.0
bss 56328 56328 0 0.0
text 611862 611948 86 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 835624 835712 88 0.0
bss 68104 68104 0 0.0
text 627116 627202 86 0.0

@woody-apple woody-apple merged commit 09fbf5c into project-chip:master Mar 15, 2024
56 of 58 checks passed
@bzbarsky-apple bzbarsky-apple deleted the interface-id-remove branch March 18, 2024 08:56
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
@bzbarsky-apple @huangxuyong
Stop forcing a particular interface ID when sending response messages. (
7d48d3b 
project-chip#32581)

Because we were storing the PeerAddress in the session when getting a message,
we effectively pinned sessions to particular interface ids at that point.

This can lead to routing failures.  We should only be pinning to interface IDs
for link-local addresses, just like we do for initial IP resolution via DNS-SD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @tcarmelveilleux @yunhanw-google @woody-apple