Added macro variants with metric support matching the ones in CodeUtils #32553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anush-apple
commented
Mar 12, 2024
anush-apple
commented
- Added Verify/Return/Log/Succ/Exit XYZ WithMetric macro variants for use in metrics
- Added unit tests for these macro variants
- Added Verify/Return/Log/Succ/Exit XYZ WithMetric macro variants for use in metrics - Added unit tests for these macro variants
pullapprove
bot
requested review from
andy31415,
andyg-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs and
mspang
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #32553: Size comparison from 1404f80 to 2d728ca Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
Mar 13, 2024
tcarmelveilleux
approved these changes
Mar 13, 2024
| * @def ReturnErrorOnFailureWithMetric(kMetricKey, expr) | ||
| * | ||
| * @brief | ||
| * This macros emits the specified metric with error code and returns the error code, |
Comment on lines
+43
to
+44
| * @param[in] kMetricKey Metric key for the metric event to be emitted if the expr evaluates | ||
| * does not evaluate to CHIP_NO_ERROR. Value of the metric is to the |
There was a problem hiding this comment.
What does "evaluates does not evaluate" mean?
What does "is to the result" mean?
Comment on lines
+73
to
+74
| * @param[in] kMetricKey Metric key for the metric event to be emitted if the expr evaluates | ||
| * does not evaluate to CHIP_NO_ERROR. Value of the metric is to the |
There was a problem hiding this comment.
Same questions as above.
Comment on lines
+104
to
+105
| * @param[in] kMetricKey Metric key for the metric event to be emitted if the expr evaluates | ||
| * does not evaluate to CHIP_NO_ERROR. Value of the metric is to the |
There was a problem hiding this comment.
Same questions as above.
| * | ||
| * @brief | ||
| * Returns a specified error code if expression evaluates to false. If the expression evaluates | ||
| * to false, a metric with the specified key is emitted with the value set to the code. |
There was a problem hiding this comment.
"to the error code"? Or "to code"? Either would be better than what we have here.
| * @endcode | ||
| * | ||
| * @param[in] kMetricKey Metric key for the metric event to be emitted if the expr evaluates | ||
| * to false. Value of the metric is to value. |
There was a problem hiding this comment.
What does "to value" mean?
| * @endcode | ||
| * | ||
| * @param[in] kMetricKey Metric key for the metric event to be emitted if the expr evaluates | ||
| * to false. Value of the metric is to code. |
There was a problem hiding this comment.
What does "to code" mean here?
| * @endcode | ||
| * | ||
| * @param[in] kMetricKey Metric key for the metric event to be emitted if the expr evaluates | ||
| * to true. Value of the metric is to code. |
| * | ||
| * @brief | ||
| * Logs a message if the expression returns something different than CHIP_NO_ERROR. | ||
| * In addition, a metric is emitted with the specified key and value set to result |
Comment on lines
+405
to
+406
| * @param[in] kMetricKey Metric key for the metric event to be emitted if the expr evaluates | ||
| * does not evaluate to CHIP_NO_ERROR. Value of the metric is to the |
There was a problem hiding this comment.
See questions above, for both the evaluate part and "is to the" part.
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…ls (project-chip#32553) - Added Verify/Return/Log/Succ/Exit XYZ WithMetric macro variants for use in metrics - Added unit tests for these macro variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.