-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Si917: C files converted to C++. #32547
Merged
jmartinez-silabs
merged 2 commits into
project-chip:master
from
rcasallas-silabs:cleanup/wifi_c_cpp
Mar 19, 2024
Merged
[Silabs] Si917: C files converted to C++. #32547
jmartinez-silabs
merged 2 commits into
project-chip:master
from
rcasallas-silabs:cleanup/wifi_c_cpp
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
March 12, 2024 16:01
pullapprove
bot
requested review from
younghak-hwang,
yufengwangca and
yunhanw-google
March 12, 2024 16:01
PR #32547: Size comparison from 9d2f350 to d05d679 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jepenven-silabs
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond the broken symlink the rest of the comments can be applied in a follow up PR.
woody-apple
approved these changes
Mar 15, 2024
andy31415
approved these changes
Mar 18, 2024
rcasallas-silabs
force-pushed
the
cleanup/wifi_c_cpp
branch
5 times, most recently
from
March 19, 2024 15:57
5d0d256
to
423a8d7
Compare
rcasallas-silabs
force-pushed
the
cleanup/wifi_c_cpp
branch
4 times, most recently
from
March 19, 2024 18:57
2e45957
to
bb11c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C files converted to C++:
Compiled in BRD4338A.