Add UI for temperature sensor in CHIPTool iOS app #3250
Conversation
|
Some code here seems to be shared with wifi-echo example. Could we somehow reuse things instead of duplicating? This would help any refactoring that is expected, since we are still developing some API and message layer bits. |
Actually the shared code is from the commit of the other PR that this PR is blocked on. This specific UI does not add any shared code. I do have an issue tracking removing duplicated code from the esp32 example apps. |
|
@shana-apple Now that #3053 has landed can you update this PR ? That will make it easier to see the relevant diff. |
|
@shana-apple - dependency seems to have been merged, however this PR became stale. Should we update or drop? |
I'll update :) |
|
ping @shana-apple :) |
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
saurabhst and
woody-apple
shana-apple
force-pushed
the
sazria/temperature-sensor-ui
branch
from
96db43c to
2f3f887
Compare
|
@woody-apple was waiting on the callback APIs, which I have adopted in their first version pending @vivien-apple's changes. But this can go in as is |
|
Thanks! |
* Add UI screen to controll temeprature sensor from iOS app * Add reporting setup code * Call CHIPTemperatureMeasurement callback methods * Add dismiss keyboard and some logs * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
* Add UI screen to controll temeprature sensor from iOS app * Add reporting setup code * Call CHIPTemperatureMeasurement callback methods * Add dismiss keyboard and some logs * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
* Add UI screen to controll temeprature sensor from iOS app * Add reporting setup code * Call CHIPTemperatureMeasurement callback methods * Add dismiss keyboard and some logs * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Adds UI to control the temperature sensor app.
Add UI to send reporting controls
Call CHIPTemperatureMeasurement methods (although they currently do not return a value but an NSError pending @vivien-apple 's patch.)
Fixes #2983