Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OperationalState to chef examples #32495

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add OperationalState to chef examples #32495

merged 1 commit into from
Mar 7, 2024

Conversation

tehampson
Copy link
Contributor

@tehampson tehampson commented Mar 7, 2024 •
edited
Loading

cluster-init-callback.cpp is autogenerated when chef is compiled. It has a weak reference to emberAfOperationalStateClusterInitCallback. As a result any command before this PR to OperationalState would fail with UNSUPPORTED_CLUSTER

Files were copied from examples/all-clusters-app/all-clusters-common/src/operational-state-delegate-impl.cpp and examples/all-clusters-app/all-clusters-common/include/operational-state-delegate-impl.h

Test:

  • cd examples/chef
  • python chef.py -d rootnode_laundrywasher_fb10d238c8 -t linux -b
  • Run ./rootnode_laundrywasher_fb10d238c8 in a terminal and commission with chip-tool
  • ./chip-tool operationalstate stop 0x12344321 1

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024 •
edited
Loading

PR #32495: Size comparison from c554f44 to 3571455

Decreases (2 builds for efr32)
platform target config section c554f44 3571455 change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 932464 932456 -8 -0.0
.text 733140 733132 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1122132 1122124 -8 -0.0
.text 932548 932540 -8 -0.0
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section c554f44 3571455 change % change
bl602 lighting-app bl602 (read/write) 1436642 1436642 0 0.0
.bss 85328 85328 0 0.0
.data 9496 9496 0 0.0
.rodata 158376 158376 0 0.0
.text 1102790 1102790 0 0.0
bl602+mfd (read/write) 1451306 1451306 0 0.0
.bss 85488 85488 0 0.0
.data 9472 9472 0 0.0
.rodata 157336 157336 0 0.0
.text 1118364 1118364 0 0.0
bl602+rpc (read/write) 1484282 1484282 0 0.0
.bss 93360 93360 0 0.0
.data 9872 9872 0 0.0
.rodata 165952 165952 0 0.0
.text 1134436 1134436 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1200999 1200999 0 0.0
.bss 11133 11133 0 0.0
.data 3680 3680 0 0.0
.rodata 107732 107732 0 0.0
.text 971598 971598 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1212051 1212051 0 0.0
.bss 11309 11309 0 0.0
.data 3656 3656 0 0.0
.rodata 106672 106672 0 0.0
.text 983608 983608 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1292735 1292735 0 0.0
.bss 19613 19613 0 0.0
.data 4216 4216 0 0.0
.rodata 123104 123104 0 0.0
.text 1046550 1046550 0 0.0
bl706-eth (read/write) 1019077 1019077 0 0.0
.bss 23708 23708 0 0.0
.data 3256 3256 0 0.0
.rodata 101064 101064 0 0.0
.text 763090 763090 0 0.0
bl706-wifi (read/write) 1253558 1253558 0 0.0
.bss 10577 10577 0 0.0
.data 3688 3688 0 0.0
.rodata 122064 122064 0 0.0
.text 994852 994852 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1170572 1170572 0 0.0
.bss 16328 16328 0 0.0
.data 5040 5040 0 0.0
.rodata 101736 101736 0 0.0
.text 964696 964696 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1181980 1181980 0 0.0
.bss 16504 16504 0 0.0
.data 5024 5024 0 0.0
.rodata 100676 100676 0 0.0
.text 977018 977018 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 773204 773204 0 0.0
(read/write) 168600 168600 0 0.0
.bss 90604 90604 0 0.0
.data 3560 3560 0 0.0
.rodata 81756 81756 0 0.0
.text 691180 691180 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 789724 789724 0 0.0
(read/write) 178848 178848 0 0.0
.bss 100852 100852 0 0.0
.data 3560 3560 0 0.0
.rodata 76004 76004 0 0.0
.text 713456 713456 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 778396 778396 0 0.0
(read/write) 173288 173288 0 0.0
.bss 95292 95292 0 0.0
.data 3560 3560 0 0.0
.rodata 102756 102756 0 0.0
.text 675372 675372 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 730556 730556 0 0.0
(read/write) 167568 167568 0 0.0
.bss 89336 89336 0 0.0
.data 3552 3552 0 0.0
.rodata 77420 77420 0 0.0
.text 652868 652868 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 716188 716188 0 0.0
(read/write) 167776 167776 0 0.0
.bss 89560 89560 0 0.0
.data 3544 3544 0 0.0
.rodata 73268 73268 0 0.0
.text 642652 642652 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 582842 582842 0 0.0
(read/write) 207968 207968 0 0.0
.bss 201204 201204 0 0.0
.data 1640 1640 0 0.0
.rodata 86602 86602 0 0.0
.text 494116 494116 0 0.0
lock CC3235SF_LAUNCHXL (read only) 628114 628114 0 0.0
(read/write) 208312 208312 0 0.0
.bss 201696 201696 0 0.0
.data 1496 1496 0 0.0
.rodata 107058 107058 0 0.0
.text 518932 518932 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 568387 568387 0 0.0
.app_xip_area 458165 458165 0 0.0
.bss 65056 65056 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551107 551107 0 0.0
.app_xip_area 436125 436125 0 0.0
.bss 69808 69808 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571291 571291 0 0.0
.app_xip_area 462573 462573 0 0.0
.bss 63592 63592 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564163 564163 0 0.0
.app_xip_area 452165 452165 0 0.0
.bss 66792 66792 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 932464 932456 -8 -0.0
.bss 197912 197912 0 0.0
.data 1392 1392 0 0.0
.text 733140 733132 -8 -0.0
BRD4187C (read/write) 1109508 1109508 0 0.0
.bss 195176 195176 0 0.0
.data 3412 3412 0 0.0
.text 910900 910900 0 0.0
lock-app BRD4161A+wf200 (read/write) 1122132 1122124 -8 -0.0
.bss 186764 186764 0 0.0
.data 2796 2796 0 0.0
.text 932548 932540 -8 -0.0
window-app BRD4187C (read/write) 1156220 1156220 0 0.0
.bss 167416 167416 0 0.0
.data 3324 3324 0 0.0
.text 985460 985460 0 0.0
esp32 all-clusters-app c3devkit (read only) 1210904 1210904 0 0.0
(read/write) 1749680 1749680 0 0.0
.dram0.bss 74296 74296 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 252224 252224 0 0.0
.flash.text 1210904 1210904 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1253335 1253335 0 0.0
(read/write) 536224 536224 0 0.0
.dram0.bss 81208 81208 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 283932 283932 0 0.0
.flash.text 1247171 1247171 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 605632 605632 0 0.0
(read/write) 79612 79612 0 0.0
.bss 67428 67428 0 0.0
.data 2200 2200 0 0.0
.text 605096 605096 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 747032 747032 0 0.0
.bss 79188 79188 0 0.0
.data 2816 2816 0 0.0
.text 625656 625656 0 0.0
light k32w0+release (read only) 609352 609352 0 0.0
(read/write) 79496 79496 0 0.0
.bss 67308 67308 0 0.0
.data 2204 2204 0 0.0
.text 608816 608816 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 789724 789724 0 0.0
.bss 80580 80580 0 0.0
.data 2032 2032 0 0.0
.text 667752 667752 0 0.0
lock k32w0+release (read only) 589184 589184 0 0.0
(read/write) 77484 77484 0 0.0
.bss 65348 65348 0 0.0
.data 2152 2152 0 0.0
.text 588648 588648 0 0.0
linux air-purifier-app debug (read only) 2615341 2615341 0 0.0
(read/write) 128928 128928 0 0.0
.bss 46512 46512 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74248 74248 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 184528 184528 0 0.0
.text 2253349 2253349 0 0.0
all-clusters-app debug (read only) 5921361 5921361 0 0.0
(read/write) 480400 480400 0 0.0
.bss 134816 134816 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 333640 333640 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1384 1384 0 0.0
.rodata 349136 349136 0 0.0
.text 5138851 5138851 0 0.0
all-clusters-minimal-app debug (read only) 5201937 5201937 0 0.0
(read/write) 236352 236352 0 0.0
.bss 127648 127648 0 0.0
.data 4432 4432 0 0.0
.data.rel.ro 97208 97208 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 288202 288202 0 0.0
.text 4679027 4679027 0 0.0
bridge-app debug (read only) 4596385 4596385 0 0.0
(read/write) 217200 217200 0 0.0
.bss 118144 118144 0 0.0
.data 6208 6208 0 0.0
.data.rel.ro 86144 86144 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228810 228810 0 0.0
.text 4147283 4147283 0 0.0
chip-tool debug (read only) 12032201 12032201 0 0.0
(read/write) 521512 521512 0 0.0
.bss 94424 94424 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 414744 414744 0 0.0
.dynamic 624 624 0 0.0
.got 5768 5768 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 448153 448153 0 0.0
.text 10878275 10878275 0 0.0
chip-tool-ipv6only arm64 (read only) 11356732 11356732 0 0.0
(read/write) 585152 585152 0 0.0
.bss 103512 103512 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 454528 454528 0 0.0
.dynamic 512 512 0 0.0
.got 16976 16976 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 354476 354476 0 0.0
.text 10123944 10123944 0 0.0
lighting-app debug+rpc+ui (read only) 5520025 5520025 0 0.0
(read/write) 225992 225992 0 0.0
.bss 119112 119112 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94544 94544 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 354004 354004 0 0.0
.text 4919347 4919347 0 0.0
lock-app debug (read only) 4664081 4664081 0 0.0
(read/write) 204784 204784 0 0.0
.bss 113568 113568 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80392 80392 0 0.0
.dynamic 624 624 0 0.0
.got 5200 5200 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 254794 254794 0 0.0
.text 4197635 4197635 0 0.0
ota-provider-app debug (read only) 4296105 4296105 0 0.0
(read/write) 193288 193288 0 0.0
.bss 113280 113280 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69776 69776 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207530 207530 0 0.0
.text 3895603 3895603 0 0.0
ota-requestor-app debug (read only) 4425529 4425529 0 0.0
(read/write) 197720 197720 0 0.0
.bss 114208 114208 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72896 72896 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 213642 213642 0 0.0
.text 4014371 4014371 0 0.0
shell debug (read only) 2889145 2889145 0 0.0
(read/write) 156320 156320 0 0.0
.bss 62704 62704 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86464 86464 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185152 185152 0 0.0
.text 2530674 2530674 0 0.0
thermostat-no-ble arm64 (read only) 4416356 4416356 0 0.0
(read/write) 242472 242472 0 0.0
.bss 121816 121816 0 0.0
.data 3376 3376 0 0.0
.data.rel.ro 103608 103608 0 0.0
.dynamic 512 512 0 0.0
.got 8616 8616 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 159388 159388 0 0.0
.text 3922328 3922328 0 0.0
tv-app debug (read only) 5704129 5704129 0 0.0
(read/write) 352552 352552 0 0.0
.bss 244336 244336 0 0.0
.data 6528 6528 0 0.0
.data.rel.ro 94424 94424 0 0.0
.dynamic 624 624 0 0.0
.got 5496 5496 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 289514 289514 0 0.0
.text 5172531 5172531 0 0.0
tv-casting-app debug (read only) 9863305 9863305 0 0.0
(read/write) 340264 340264 0 0.0
.bss 156240 156240 0 0.0
.data 2976 2976 0 0.0
.data.rel.ro 174176 174176 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5072 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 382552 382552 0 0.0
.text 9015011 9015011 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531848 2531848 0 0.0
.bss 220448 220448 0 0.0
.data 5200 5200 0 0.0
.text 1494532 1494532 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1102440 1102440 0 0.0
bss 130831 130831 0 0.0
rodata 112864 112864 0 0.0
text 810892 810892 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1221840 1221840 0 0.0
bss 122921 122921 0 0.0
rodata 141792 141792 0 0.0
text 806596 806596 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1050684 1050684 0 0.0
bss 129689 129689 0 0.0
rodata 100220 100220 0 0.0
text 772932 772932 0 0.0
light-switch-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1001868 1001868 0 0.0
bss 123726 123726 0 0.0
rodata 89676 89676 0 0.0
text 740796 740796 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1192092 1192092 0 0.0
bss 115033 115033 0 0.0
rodata 167572 167572 0 0.0
text 755096 755096 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read only) 4 4 0 0.0
(read/write) 1101200 1101200 0 0.0
bss 135517 135517 0 0.0
rodata 95288 95288 0 0.0
text 819664 819664 0 0.0
nrf52840dongle_nrf52840 (read only) 4 4 0 0.0
(read/write) 1061232 1061232 0 0.0
bss 143582 143582 0 0.0
rodata 85400 85400 0 0.0
text 776788 776788 0 0.0
nrf5340dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 985552 985552 0 0.0
bss 131854 131854 0 0.0
rodata 84352 84352 0 0.0
text 717128 717128 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1192092 1192092 0 0.0
bss 115033 115033 0 0.0
rodata 167572 167572 0 0.0
text 755096 755096 0 0.0
lock-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1014244 1014244 0 0.0
bss 124257 124257 0 0.0
rodata 109236 109236 0 0.0
text 733144 733144 0 0.0
nrf5340dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 929416 929416 0 0.0
bss 121854 121854 0 0.0
rodata 103520 103520 0 0.0
text 651876 651876 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1205400 1205400 0 0.0
bss 115564 115564 0 0.0
rodata 187124 187124 0 0.0
text 748340 748340 0 0.0
pump-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 965488 965488 0 0.0
bss 122958 122958 0 0.0
rodata 84696 84696 0 0.0
text 710240 710240 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 953476 953476 0 0.0
bss 122757 122757 0 0.0
rodata 81612 81612 0 0.0
text 701436 701436 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834464 834464 0 0.0
(read/write) 1796020 1796020 0 0.0
.bss 196212 196212 0 0.0
.data 2664 2664 0 0.0
.text 1588756 1588756 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837608 837608 0 0.0
(read/write) 1718092 1718092 0 0.0
.bss 193092 193092 0 0.0
.data 2640 2640 0 0.0
.text 1513972 1513972 0 0.0
light cy8ckit_062s2_43012 (read only) 844336 844336 0 0.0
(read/write) 1637196 1637196 0 0.0
.bss 186556 186556 0 0.0
.data 2448 2448 0 0.0
.text 1439804 1439804 0 0.0
lock cy8ckit_062s2_43012 (read only) 817184 817184 0 0.0
(read/write) 1667084 1667084 0 0.0
.bss 213716 213716 0 0.0
.data 2440 2440 0 0.0
.text 1442540 1442540 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129244 1129244 0 0.0
.bss 102456 102456 0 0.0
.data 824 824 0 0.0
.text 641624 641624 0 0.0
lock-app qpg6105+debug (read/write) 1089332 1089332 0 0.0
.bss 97200 97200 0 0.0
.data 844 844 0 0.0
.text 601716 601716 0 0.0
stm32 light STM32WB5MM-DK (read/write) 600425 600425 0 0.0
.bss 128320 128320 0 0.0
.data 668 668 0 0.0
.rodata 79644 79644 0 0.0
.text 382064 382064 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823218 823218 0 0.0
bss 49660 49660 0 0.0
text 616040 616040 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1091900 1091900 0 0.0
bss 101780 101780 0 0.0
text 793056 793056 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1049372 1049372 0 0.0
bss 110084 110084 0 0.0
text 764378 764378 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 910084 910084 0 0.0
bss 93116 93116 0 0.0
text 651852 651852 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824850 824850 0 0.0
bss 49708 49708 0 0.0
text 617730 617730 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 930560 930560 0 0.0
bss 77708 77708 0 0.0
text 697874 697874 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1073256 1073256 0 0.0
bss 100196 100196 0 0.0
text 777232 777232 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 902960 902960 0 0.0
bss 69172 69172 0 0.0
text 653142 653142 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 929204 929204 0 0.0
bss 92696 92696 0 0.0
text 671012 671012 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 827426 827426 0 0.0
bss 49816 49816 0 0.0
text 620710 620710 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 791148 791148 0 0.0
bss 56016 56016 0 0.0
text 591468 591468 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 677148 677148 0 0.0
bss 73672 73672 0 0.0
text 462406 462406 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832378 832378 0 0.0
bss 51340 51340 0 0.0
text 624100 624100 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 851109 851109 0 0.0
bss 59492 59492 0 0.0
text 636178 636178 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 816784 816784 0 0.0
bss 56304 56304 0 0.0
text 611152 611152 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 834888 834888 0 0.0
bss 68080 68080 0 0.0
text 626408 626408 0 0.0

@mergify mergify bot merged commit 0aa2442 into project-chip:master Mar 7, 2024
58 checks passed
bzbarsky-apple
bzbarsky-apple reviewed Mar 13, 2024
View reviewed changes
examples/chef/common/chef-operational-state-delegate-impl.cpp
Comment on lines +83 to +87
if (state == OperationalState::OperationalStateEnum::kStopped || state == OperationalState::OperationalStateEnum::kError)
{
err.Set(to_underlying(OperationalState::ErrorStateEnum::kCommandInvalidInState));
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicating cluster code. Why is it doing that? Those checks happen before this method is ever called.

Similar for various other bits in this file.

huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
@tehampson @huangxuyong
Add OperationalState to chef examples (project-chip#32495)
fe105b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@younghak-hwang younghak-hwang younghak-hwang approved these changes

@marktrayer marktrayer marktrayer approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tehampson @tcarmelveilleux @marktrayer @bzbarsky-apple @younghak-hwang