-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Support ICD Check in message #32476
[Android] Support ICD Check in message #32476
Conversation
bcdf546
to
1d4f577
Compare
PR #32476: Size comparison from f834092 to ff03d3f Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32476: Size comparison from c2f58e4 to 505ad4f Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement AndroidCheckInDelegate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is enableServerInteractions for? Could you put more comment about this?
To receive a check in message, mDNS search of _matter._tcp must be possible. I thought a separate feature was needed to operate this function. (If the app requires only the commissioner, this function is not needed.) |
505ad4f
to
398e209
Compare
PR #32476: Size comparison from b278978 to a2efedc Full report (3 builds for cc32xx, stm32)
|
PR #32476: Size comparison from b278978 to 3692e04 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
src/controller/java/src/chip/devicecontroller/ControllerParams.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/ControllerParams.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: mkardous-silabs <[email protected]>
address comment
PR #32476: Size comparison from b278978 to 9f5818d Increases above 0.2%:
Increases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (4 builds for psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32476: Size comparison from b278978 to 32fcfb6 Increases above 0.2%:
Increases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (4 builds for psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
* Add Android Checkin * Restyled by clang-format * Restyled by clang-format * Add enableServerInteractions comment * Restyled by whitespace * Restyled by google-java-format * Update src/controller/java/src/chip/devicecontroller/ControllerParams.java Co-authored-by: mkardous-silabs <[email protected]> * Update ControllerParams.java address comment --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: yunhanw-google <[email protected]> Co-authored-by: mkardous-silabs <[email protected]>
Fix #31359