Add tests to lib/support/SortUtils.h #32421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SortUtils.h has no tests. While it is apparently trivial, we should never have code that has no tests - BubbleSort could crash (never-ending loop due to integer overflow) when input size was < 2. Its use is removed and replaced by InsertionSort which is known to be faster on average. A better solution is to move to using STL sorts in the future, but this requires analysis of flash costs and STL usage, given lambdas are used with sorts many places. Fixes project-chip#32420 Testing done: - Added missing unit tests. - All integration tests still pass.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Mar 4, 2024
|
PR #32421: Size comparison from 4080775 to 1951448 Increases (3 builds for qpg, stm32)
Decreases (2 builds for cc32xx)
Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
bzbarsky-apple
approved these changes
Mar 4, 2024
|
PR #32421: Size comparison from 4080775 to ae70df3 Increases (43 builds for bl702, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, stm32, telink)
Decreases (31 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #32421: Size comparison from 5c59934 to bc5cf90 Increases (42 builds for bl702, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, nrfconnect, qpg, stm32, telink)
Decreases (31 builds for bl602, bl702, bl702l, cc32xx, efr32, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Mar 7, 2024
* Add tests to lib/support/SortUtils.h - SortUtils.h has no tests. While it is apparently trivial, we should never have code that has no tests - BubbleSort could crash (never-ending loop due to integer overflow) when input size was < 2. Its use is removed and replaced by InsertionSort which is known to be faster on average. A better solution is to move to using STL sorts in the future, but this requires analysis of flash costs and STL usage, given lambdas are used with sorts many places. Fixes project-chip#32420 Testing done: - Added missing unit tests. - All integration tests still pass. * Restyled by clang-format * Fix build error on Android * Add constness to operator== --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
* Add tests to lib/support/SortUtils.h - SortUtils.h has no tests. While it is apparently trivial, we should never have code that has no tests - BubbleSort could crash (never-ending loop due to integer overflow) when input size was < 2. Its use is removed and replaced by InsertionSort which is known to be faster on average. A better solution is to move to using STL sorts in the future, but this requires analysis of flash costs and STL usage, given lambdas are used with sorts many places. Fixes project-chip#32420 Testing done: - Added missing unit tests. - All integration tests still pass. * Restyled by clang-format * Fix build error on Android * Add constness to operator== --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32420
Testing done: