Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EventLoggingTypes.h and EventHeader.h to be seen by GN #32416

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Move EventLoggingTypes.h and EventHeader.h to be seen by GN #32416

merged 3 commits into from
Mar 4, 2024

Conversation

andy31415
Copy link
Contributor

Given that MessageDef files were depending on these, I placed them into MessageDef.

To avoid a circular dependency loop on access (because access uses platform which in turn uses MessageDef which use events which use access) I split out the access type definitions as their own separate source set.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

PR #32416: Size comparison from 0c4ecc7 to 2a510fa

Decreases (3 builds for efr32)
platform target config section 0c4ecc7 2a510fa change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 931504 931496 -8 -0.0
.text 732204 732196 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1121900 1121892 -8 -0.0
.text 932348 932340 -8 -0.0
window-app BRD4187C (read/write) 1155512 1155504 -8 -0.0
.text 984780 984772 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 0c4ecc7 2a510fa change % change
bl602 lighting-app bl602 (read/write) 1436234 1436234 0 0.0
.bss 85304 85304 0 0.0
.data 9496 9496 0 0.0
.rodata 158324 158324 0 0.0
.text 1102466 1102466 0 0.0
bl602+mfd (read/write) 1450650 1450650 0 0.0
.bss 85464 85464 0 0.0
.data 9472 9472 0 0.0
.rodata 157284 157284 0 0.0
.text 1117784 1117784 0 0.0
bl602+rpc (read/write) 1483882 1483882 0 0.0
.bss 93336 93336 0 0.0
.data 9880 9880 0 0.0
.rodata 165900 165900 0 0.0
.text 1134112 1134112 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1200575 1200575 0 0.0
.bss 11117 11117 0 0.0
.data 3680 3680 0 0.0
.rodata 107680 107680 0 0.0
.text 971246 971246 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1211627 1211627 0 0.0
.bss 11293 11293 0 0.0
.data 3656 3656 0 0.0
.rodata 106620 106620 0 0.0
.text 983256 983256 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1292303 1292303 0 0.0
.bss 19581 19581 0 0.0
.data 4224 4224 0 0.0
.rodata 123052 123052 0 0.0
.text 1046198 1046198 0 0.0
bl706-eth (read/write) 1018653 1018653 0 0.0
.bss 23692 23692 0 0.0
.data 3256 3256 0 0.0
.rodata 101012 101012 0 0.0
.text 762738 762738 0 0.0
bl706-wifi (read/write) 1252854 1252854 0 0.0
.bss 10561 10561 0 0.0
.data 3696 3696 0 0.0
.rodata 122012 122012 0 0.0
.text 994210 994210 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1170176 1170176 0 0.0
.bss 16312 16312 0 0.0
.data 5040 5040 0 0.0
.rodata 101684 101684 0 0.0
.text 964372 964372 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1181584 1181584 0 0.0
.bss 16488 16488 0 0.0
.data 5024 5024 0 0.0
.rodata 100624 100624 0 0.0
.text 976694 976694 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 772932 772932 0 0.0
(read/write) 168576 168576 0 0.0
.bss 90580 90580 0 0.0
.data 3560 3560 0 0.0
.rodata 81700 81700 0 0.0
.text 690968 690968 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 789452 789452 0 0.0
(read/write) 178824 178824 0 0.0
.bss 100828 100828 0 0.0
.data 3560 3560 0 0.0
.rodata 75948 75948 0 0.0
.text 713236 713236 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 778108 778108 0 0.0
(read/write) 173264 173264 0 0.0
.bss 95268 95268 0 0.0
.data 3560 3560 0 0.0
.rodata 102700 102700 0 0.0
.text 675144 675144 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 730284 730284 0 0.0
(read/write) 167544 167544 0 0.0
.bss 89312 89312 0 0.0
.data 3552 3552 0 0.0
.rodata 77372 77372 0 0.0
.text 652648 652648 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 715908 715908 0 0.0
(read/write) 167752 167752 0 0.0
.bss 89536 89536 0 0.0
.data 3544 3544 0 0.0
.rodata 73212 73212 0 0.0
.text 642432 642432 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 582154 582154 0 0.0
(read/write) 207944 207944 0 0.0
.bss 201180 201180 0 0.0
.data 1640 1640 0 0.0
.rodata 86530 86530 0 0.0
.text 493500 493500 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627514 627514 0 0.0
(read/write) 208288 208288 0 0.0
.bss 201672 201672 0 0.0
.data 1496 1496 0 0.0
.rodata 106994 106994 0 0.0
.text 518396 518396 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 568155 568155 0 0.0
.app_xip_area 457957 457957 0 0.0
.bss 65032 65032 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 550867 550867 0 0.0
.app_xip_area 435909 435909 0 0.0
.bss 69784 69784 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571043 571043 0 0.0
.app_xip_area 462349 462349 0 0.0
.bss 63568 63568 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 563931 563931 0 0.0
.app_xip_area 451957 451957 0 0.0
.bss 66768 66768 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 931504 931496 -8 -0.0
.bss 197888 197888 0 0.0
.data 1388 1388 0 0.0
.text 732204 732196 -8 -0.0
BRD4187C (read/write) 1108920 1108920 0 0.0
.bss 195152 195152 0 0.0
.data 3408 3408 0 0.0
.text 910340 910340 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121900 1121892 -8 -0.0
.bss 186740 186740 0 0.0
.data 2792 2792 0 0.0
.text 932348 932340 -8 -0.0
window-app BRD4187C (read/write) 1155512 1155504 -8 -0.0
.bss 167392 167392 0 0.0
.data 3320 3320 0 0.0
.text 984780 984772 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1210446 1210446 0 0.0
(read/write) 1749440 1749440 0 0.0
.dram0.bss 74272 74272 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 252016 252016 0 0.0
.flash.text 1210446 1210446 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1252815 1252815 0 0.0
(read/write) 536004 536004 0 0.0
.dram0.bss 81184 81184 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 283736 283736 0 0.0
.flash.text 1246651 1246651 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 605184 605184 0 0.0
(read/write) 79584 79584 0 0.0
.bss 67404 67404 0 0.0
.data 2196 2196 0 0.0
.text 604648 604648 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 746548 746548 0 0.0
.bss 79164 79164 0 0.0
.data 2816 2816 0 0.0
.text 625200 625200 0 0.0
light k32w0+release (read only) 609128 609128 0 0.0
(read/write) 79468 79468 0 0.0
.bss 67284 67284 0 0.0
.data 2200 2200 0 0.0
.text 608592 608592 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 789448 789448 0 0.0
.bss 80556 80556 0 0.0
.data 2032 2032 0 0.0
.text 667504 667504 0 0.0
lock k32w0+release (read only) 588720 588720 0 0.0
(read/write) 77456 77456 0 0.0
.bss 65324 65324 0 0.0
.data 2148 2148 0 0.0
.text 588184 588184 0 0.0
linux air-purifier-app debug (read only) 2611669 2611669 0 0.0
(read/write) 128832 128832 0 0.0
.bss 46448 46448 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74216 74216 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 184272 184272 0 0.0
.text 2250053 2250053 0 0.0
all-clusters-app debug (read only) 5918105 5918105 0 0.0
(read/write) 480272 480272 0 0.0
.bss 134752 134752 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 333608 333608 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1384 1384 0 0.0
.rodata 349296 349296 0 0.0
.text 5135555 5135555 0 0.0
all-clusters-minimal-app debug (read only) 5198657 5198657 0 0.0
(read/write) 236192 236192 0 0.0
.bss 127552 127552 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 97176 97176 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 288322 288322 0 0.0
.text 4675747 4675747 0 0.0
bridge-app debug (read only) 4593121 4593121 0 0.0
(read/write) 217072 217072 0 0.0
.bss 118080 118080 0 0.0
.data 6176 6176 0 0.0
.data.rel.ro 86112 86112 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228962 228962 0 0.0
.text 4143987 4143987 0 0.0
chip-tool debug (read only) 12029273 12029273 0 0.0
(read/write) 521448 521448 0 0.0
.bss 94392 94392 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 414712 414712 0 0.0
.dynamic 624 624 0 0.0
.got 5768 5768 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 448345 448345 0 0.0
.text 10875251 10875251 0 0.0
chip-tool-ipv6only arm64 (read only) 11353420 11353420 0 0.0
(read/write) 588400 588400 0 0.0
.bss 103464 103464 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 454496 454496 0 0.0
.dynamic 512 512 0 0.0
.got 16984 16984 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 354364 354364 0 0.0
.text 10120840 10120840 0 0.0
lighting-app debug+rpc+ui (read only) 5516497 5516497 0 0.0
(read/write) 225896 225896 0 0.0
.bss 119048 119048 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94512 94512 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 354004 354004 0 0.0
.text 4915939 4915939 0 0.0
lock-app debug (read only) 4660865 4660865 0 0.0
(read/write) 204688 204688 0 0.0
.bss 113504 113504 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80360 80360 0 0.0
.dynamic 624 624 0 0.0
.got 5200 5200 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 254978 254978 0 0.0
.text 4194355 4194355 0 0.0
ota-provider-app debug (read only) 4292697 4292697 0 0.0
(read/write) 193192 193192 0 0.0
.bss 113216 113216 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69744 69744 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207522 207522 0 0.0
.text 3892323 3892323 0 0.0
ota-requestor-app debug (read only) 4422153 4422153 0 0.0
(read/write) 197592 197592 0 0.0
.bss 114112 114112 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72864 72864 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 213666 213666 0 0.0
.text 4011091 4011091 0 0.0
shell debug (read only) 2885913 2885913 0 0.0
(read/write) 156224 156224 0 0.0
.bss 62640 62640 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86432 86432 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185184 185184 0 0.0
.text 2527506 2527506 0 0.0
thermostat-no-ble arm64 (read only) 4412628 4412628 0 0.0
(read/write) 242064 242064 0 0.0
.bss 121768 121768 0 0.0
.data 3360 3360 0 0.0
.data.rel.ro 103576 103576 0 0.0
.dynamic 512 512 0 0.0
.got 8616 8616 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 159116 159116 0 0.0
.text 3919016 3919016 0 0.0
tv-app debug (read only) 5700889 5700889 0 0.0
(read/write) 352424 352424 0 0.0
.bss 244272 244272 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 94392 94392 0 0.0
.dynamic 624 624 0 0.0
.got 5496 5496 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 289698 289698 0 0.0
.text 5169251 5169251 0 0.0
tv-casting-app debug (read only) 9860073 9860073 0 0.0
(read/write) 340168 340168 0 0.0
.bss 156176 156176 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 174168 174168 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5072 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 382672 382672 0 0.0
.text 9011779 9011779 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531592 2531592 0 0.0
.bss 220424 220424 0 0.0
.data 5200 5200 0 0.0
.text 1494276 1494276 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1102036 1102036 0 0.0
bss 130807 130807 0 0.0
rodata 112812 112812 0 0.0
text 810680 810680 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1221588 1221588 0 0.0
bss 122897 122897 0 0.0
rodata 141772 141772 0 0.0
text 806404 806404 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1050440 1050440 0 0.0
bss 129665 129665 0 0.0
rodata 100184 100184 0 0.0
text 772732 772732 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834488 834488 0 0.0
(read/write) 1795300 1795300 0 0.0
.bss 196188 196188 0 0.0
.data 2664 2664 0 0.0
.text 1588060 1588060 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837640 837640 0 0.0
(read/write) 1717396 1717396 0 0.0
.bss 193068 193068 0 0.0
.data 2632 2632 0 0.0
.text 1513308 1513308 0 0.0
light cy8ckit_062s2_43012 (read only) 844368 844368 0 0.0
(read/write) 1636516 1636516 0 0.0
.bss 186532 186532 0 0.0
.data 2440 2440 0 0.0
.text 1439156 1439156 0 0.0
lock cy8ckit_062s2_43012 (read only) 817208 817208 0 0.0
(read/write) 1666428 1666428 0 0.0
.bss 213692 213692 0 0.0
.data 2440 2440 0 0.0
.text 1441908 1441908 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1128992 1128992 0 0.0
.bss 102432 102432 0 0.0
.data 820 820 0 0.0
.text 641376 641376 0 0.0
lock-app qpg6105+debug (read/write) 1089088 1089088 0 0.0
.bss 97176 97176 0 0.0
.data 840 840 0 0.0
.text 601468 601468 0 0.0
stm32 light STM32WB5MM-DK (read/write) 600149 600149 0 0.0
.bss 128296 128296 0 0.0
.data 668 668 0 0.0
.rodata 79596 79596 0 0.0
.text 381864 381864 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822878 822878 0 0.0
bss 49636 49636 0 0.0
text 615784 615784 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1091584 1091584 0 0.0
bss 101756 101756 0 0.0
text 792816 792816 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1049080 1049080 0 0.0
bss 110060 110060 0 0.0
text 764164 764164 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 909768 909768 0 0.0
bss 93092 93092 0 0.0
text 651614 651614 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824558 824558 0 0.0
bss 49684 49684 0 0.0
text 617522 617522 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 930260 930260 0 0.0
bss 77684 77684 0 0.0
text 697660 697660 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1072964 1072964 0 0.0
bss 100172 100172 0 0.0
text 777018 777018 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 902636 902636 0 0.0
bss 69148 69148 0 0.0
text 652904 652904 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 928912 928912 0 0.0
bss 92672 92672 0 0.0
text 670798 670798 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 827118 827118 0 0.0
bss 49792 49792 0 0.0
text 620478 620478 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 790832 790832 0 0.0
bss 55992 55992 0 0.0
text 591230 591230 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 677148 677148 0 0.0
bss 73672 73672 0 0.0
text 462406 462406 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 832094 832094 0 0.0
bss 51316 51316 0 0.0
text 623892 623892 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 850793 850793 0 0.0
bss 59468 59468 0 0.0
text 635940 635940 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 816492 816492 0 0.0
bss 56280 56280 0 0.0
text 610938 610938 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 834596 834596 0 0.0
bss 68056 68056 0 0.0
text 626194 626194 0 0.0

@mergify mergify bot merged commit 5c59934 into project-chip:master Mar 4, 2024
58 checks passed
@andy31415 andy31415 mentioned this pull request Mar 5, 2024
Merged
erwinpan1 pushed a commit to erwinpan1/connectedhomeip that referenced this pull request Mar 7, 2024
@andy31415 @erwinpan1
Move EventLoggingTypes.h and EventHeader.h to be seen by GN (project-…
01f2bf4 
…chip#32416)

* Move EventHeader and EventLoggingTypes into MessageDef because that seems to be the pimary use

* Fix compile and lints

* Restyle
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
@andy31415 @huangxuyong
Move EventLoggingTypes.h and EventHeader.h to be seen by GN (project-…
7a53266 
…chip#32416)

* Move EventHeader and EventLoggingTypes into MessageDef because that seems to be the pimary use

* Fix compile and lints

* Restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller darwin examples github review - approved tests tools workflows
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @tcarmelveilleux @woody-apple