-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of build targets for chip_data_model generated code #32357
Make use of build targets for chip_data_model generated code #32357
Conversation
PR #32357: Size comparison from 355e2b4 to 5862d3b Increases (19 builds for bl602, bl702, bl702l, cc13x4_26x4, k32w, linux)
Decreases (7 builds for bl602, cc13x4_26x4, cc32xx, linux)
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, stm32)
|
…ike for qpg lib and tests seem to maybe also want this
PR #32357: Size comparison from 355e2b4 to 91142f4 Increases (29 builds for bl602, bl702, bl702l, cc13x4_26x4, k32w, linux, qpg)
Decreases (7 builds for bl602, cc13x4_26x4, cc32xx, linux)
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, qpg, stm32)
|
PR #32357: Size comparison from 355e2b4 to c3448f2 Decreases (1 build for cc32xx)
Full report (3 builds for cc32xx, stm32)
|
PR #32357: Size comparison from 355e2b4 to f5bf1d0 Increases (2 builds for qpg)
Decreases (1 build for cc32xx)
Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
PR #32357: Size comparison from 355e2b4 to a6cc369 Increases (29 builds for bl602, bl702, bl702l, cc13x4_26x4, k32w, linux, qpg)
Decreases (7 builds for bl602, cc13x4_26x4, cc32xx, linux)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, qpg, stm32)
|
After changing 100s of files for data model defaults, it looks to me that this has to be done incrementally - a one-change PR will not work. The dependencies are also very mixed:
Closing this large PR for now and will look at incrementally adding support for dependencies. It looks like headers and sources must be split here as:
|
This builds on #32346.
Changes
privilege-storage
(which depends on access.h generated file) be a stand-alone target in CIchip_static_data_model_BACKEND
that specifies what data model gets compiled into src/app models.bootstrap
to work as bootstrap resolves all dependencies and things in app depend on the backend.The intent is to migrate away from implicit
data_model
including everything and instead to have bespoke targets. Started with privilege-storage since it seemed one of the simpler ones. main delta of this is to define chip_static_data_model_BACKEND everywhere.