Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define explicit data_model sub-targets for generated files #32343

Merged
merged 9 commits into from
Feb 29, 2024
Merged

Define explicit data_model sub-targets for generated files #32343

merged 9 commits into from
Feb 29, 2024

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Feb 27, 2024 •
edited
Loading

we currently code-generate across all layers, both config headers (that generally define endpoint composition) and cpp implementations like init callback stubs and data dispatch. As a result we cannot have a "data model target" as a stand-alone since this would imply a full monolith of src/app.

This PR contains two changes:

  • define separate targets for data_model that can be used in the future for GN dependencies
  • split out constants for privileges so that codegen can be independent from privilege-storage

This is what codegen we have for app (orange red bits):

image

Additional this is the constant include move for privilege-storage. Existing code would force me to combine generated code and non-generated:

image

Where as new code breaks that dependency into 2:

image

After the PR, this is what targets could exist (they do not as there is still no GN linkage ... I will need to include some form of data_model_BACKEND that differs across each app):

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

PR #32343: Size comparison from 6d8613d to e5d3e30

Full report (4 builds for cc32xx, mbed, stm32)
platform target config section 6d8613d e5d3e30 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 582010 582010 0 0.0
(read/write) 207968 207968 0 0.0
.bss 201204 201204 0 0.0
.data 1640 1640 0 0.0
.rodata 86530 86530 0 0.0
.text 493356 493356 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627370 627370 0 0.0
(read/write) 208312 208312 0 0.0
.bss 201696 201696 0 0.0
.data 1496 1496 0 0.0
.rodata 106994 106994 0 0.0
.text 518252 518252 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531528 2531528 0 0.0
.bss 220448 220448 0 0.0
.data 5200 5200 0 0.0
.text 1494212 1494212 0 0.0
stm32 light STM32WB5MM-DK (read/write) 599261 599261 0 0.0
.bss 128320 128320 0 0.0
.data 668 668 0 0.0
.rodata 78820 78820 0 0.0
.text 381728 381728 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

PR #32343: Size comparison from 6d8613d to 15da437

Decreases (3 builds for efr32)
platform target config section 6d8613d 15da437 change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 930760 930752 -8 -0.0
.text 731436 731428 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1121540 1121532 -8 -0.0
.text 931964 931956 -8 -0.0
window-app BRD4187C (read/write) 1154904 1154896 -8 -0.0
.text 984172 984164 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 6d8613d 15da437 change % change
bl602 lighting-app bl602 (read/write) 1433786 1433786 0 0.0
.bss 85328 85328 0 0.0
.data 9496 9496 0 0.0
.rodata 157540 157540 0 0.0
.text 1100772 1100772 0 0.0
bl602+mfd (read/write) 1448186 1448186 0 0.0
.bss 85488 85488 0 0.0
.data 9472 9472 0 0.0
.rodata 156500 156500 0 0.0
.text 1116086 1116086 0 0.0
bl602+rpc (read/write) 1481442 1481442 0 0.0
.bss 93360 93360 0 0.0
.data 9880 9880 0 0.0
.rodata 165116 165116 0 0.0
.text 1132418 1132418 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1198795 1198795 0 0.0
.bss 11117 11117 0 0.0
.data 3680 3680 0 0.0
.rodata 106884 106884 0 0.0
.text 970246 970246 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1209591 1209591 0 0.0
.bss 11293 11293 0 0.0
.data 3656 3656 0 0.0
.rodata 105824 105824 0 0.0
.text 982000 982000 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1290523 1290523 0 0.0
.bss 19581 19581 0 0.0
.data 4224 4224 0 0.0
.rodata 122256 122256 0 0.0
.text 1045198 1045198 0 0.0
bl706-eth (read/write) 1016393 1016393 0 0.0
.bss 23692 23692 0 0.0
.data 3256 3256 0 0.0
.rodata 100228 100228 0 0.0
.text 761248 761248 0 0.0
bl706-wifi (read/write) 1250330 1250330 0 0.0
.bss 10561 10561 0 0.0
.data 3696 3696 0 0.0
.rodata 121228 121228 0 0.0
.text 992440 992440 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1168140 1168140 0 0.0
.bss 16312 16312 0 0.0
.data 5040 5040 0 0.0
.rodata 100888 100888 0 0.0
.text 963116 963116 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1179548 1179548 0 0.0
.bss 16488 16488 0 0.0
.data 5024 5024 0 0.0
.rodata 99828 99828 0 0.0
.text 975438 975438 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 772748 772748 0 0.0
(read/write) 168600 168600 0 0.0
.bss 90604 90604 0 0.0
.data 3560 3560 0 0.0
.rodata 81700 81700 0 0.0
.text 690784 690784 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 789284 789284 0 0.0
(read/write) 178848 178848 0 0.0
.bss 100852 100852 0 0.0
.data 3560 3560 0 0.0
.rodata 75948 75948 0 0.0
.text 713072 713072 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 777924 777924 0 0.0
(read/write) 173288 173288 0 0.0
.bss 95292 95292 0 0.0
.data 3560 3560 0 0.0
.rodata 102700 102700 0 0.0
.text 674960 674960 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 730100 730100 0 0.0
(read/write) 167568 167568 0 0.0
.bss 89336 89336 0 0.0
.data 3552 3552 0 0.0
.rodata 77372 77372 0 0.0
.text 652464 652464 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 715724 715724 0 0.0
(read/write) 167776 167776 0 0.0
.bss 89560 89560 0 0.0
.data 3544 3544 0 0.0
.rodata 73212 73212 0 0.0
.text 642248 642248 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 582010 582010 0 0.0
(read/write) 207968 207968 0 0.0
.bss 201204 201204 0 0.0
.data 1640 1640 0 0.0
.rodata 86530 86530 0 0.0
.text 493356 493356 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627370 627370 0 0.0
(read/write) 208312 208312 0 0.0
.bss 201696 201696 0 0.0
.data 1496 1496 0 0.0
.rodata 106994 106994 0 0.0
.text 518252 518252 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 567971 567971 0 0.0
.app_xip_area 457749 457749 0 0.0
.bss 65056 65056 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 550683 550683 0 0.0
.app_xip_area 435701 435701 0 0.0
.bss 69808 69808 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569475 569475 0 0.0
.app_xip_area 460757 460757 0 0.0
.bss 63592 63592 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 564091 564091 0 0.0
.app_xip_area 452093 452093 0 0.0
.bss 66792 66792 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 930760 930752 -8 -0.0
.bss 197912 197912 0 0.0
.data 1388 1388 0 0.0
.text 731436 731428 -8 -0.0
BRD4187C (read/write) 1108568 1108568 0 0.0
.bss 195152 195152 0 0.0
.data 3408 3408 0 0.0
.text 909988 909988 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121540 1121532 -8 -0.0
.bss 186764 186764 0 0.0
.data 2792 2792 0 0.0
.text 931964 931956 -8 -0.0
window-app BRD4187C (read/write) 1154904 1154896 -8 -0.0
.bss 167392 167392 0 0.0
.data 3320 3320 0 0.0
.text 984172 984164 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1210340 1210340 0 0.0
(read/write) 1748704 1748704 0 0.0
.dram0.bss 74296 74296 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 251248 251248 0 0.0
.flash.text 1210340 1210340 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1252487 1252487 0 0.0
(read/write) 534196 534196 0 0.0
.dram0.bss 81208 81208 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 281904 281904 0 0.0
.flash.text 1246323 1246323 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 604960 604960 0 0.0
(read/write) 79608 79608 0 0.0
.bss 67428 67428 0 0.0
.data 2196 2196 0 0.0
.text 604424 604424 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 747484 747484 0 0.0
.bss 79188 79188 0 0.0
.data 2816 2816 0 0.0
.text 626112 626112 0 0.0
light k32w0+release (read only) 608856 608856 0 0.0
(read/write) 79492 79492 0 0.0
.bss 67308 67308 0 0.0
.data 2200 2200 0 0.0
.text 608320 608320 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 789224 789224 0 0.0
.bss 80580 80580 0 0.0
.data 2032 2032 0 0.0
.text 667256 667256 0 0.0
lock k32w0+release (read only) 588864 588864 0 0.0
(read/write) 77480 77480 0 0.0
.bss 65348 65348 0 0.0
.data 2148 2148 0 0.0
.text 588328 588328 0 0.0
linux air-purifier-app debug (read only) 2611317 2611317 0 0.0
(read/write) 128832 128832 0 0.0
.bss 46448 46448 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74216 74216 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 184240 184240 0 0.0
.text 2249733 2249733 0 0.0
all-clusters-app debug (read only) 5915417 5915417 0 0.0
(read/write) 480304 480304 0 0.0
.bss 134784 134784 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 333608 333608 0 0.0
.dynamic 624 624 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 1384 1384 0 0.0
.rodata 349264 349264 0 0.0
.text 5132899 5132899 0 0.0
all-clusters-minimal-app debug (read only) 5195969 5195969 0 0.0
(read/write) 236224 236224 0 0.0
.bss 127584 127584 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 97176 97176 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 288290 288290 0 0.0
.text 4673091 4673091 0 0.0
bridge-app debug (read only) 4592785 4592785 0 0.0
(read/write) 217104 217104 0 0.0
.bss 118112 118112 0 0.0
.data 6176 6176 0 0.0
.data.rel.ro 86112 86112 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228930 228930 0 0.0
.text 4143683 4143683 0 0.0
chip-tool debug (read only) 12011945 12011945 0 0.0
(read/write) 521448 521448 0 0.0
.bss 94392 94392 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 414712 414712 0 0.0
.dynamic 624 624 0 0.0
.got 5768 5768 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 448185 448185 0 0.0
.text 10858083 10858083 0 0.0
chip-tool-ipv6only arm64 (read only) 11339756 11339756 0 0.0
(read/write) 585656 585656 0 0.0
.bss 103464 103464 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 454496 454496 0 0.0
.dynamic 512 512 0 0.0
.got 16816 16816 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 353564 353564 0 0.0
.text 10108472 10108472 0 0.0
lighting-app debug+rpc+ui (read only) 5516161 5516161 0 0.0
(read/write) 225896 225896 0 0.0
.bss 119048 119048 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94512 94512 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 353972 353972 0 0.0
.text 4915635 4915635 0 0.0
lock-app debug (read only) 4660513 4660513 0 0.0
(read/write) 204720 204720 0 0.0
.bss 113536 113536 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80360 80360 0 0.0
.dynamic 624 624 0 0.0
.got 5200 5200 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 254946 254946 0 0.0
.text 4194035 4194035 0 0.0
ota-provider-app debug (read only) 4292361 4292361 0 0.0
(read/write) 193192 193192 0 0.0
.bss 113216 113216 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69744 69744 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207490 207490 0 0.0
.text 3892019 3892019 0 0.0
ota-requestor-app debug (read only) 4418361 4418361 0 0.0
(read/write) 197592 197592 0 0.0
.bss 114112 114112 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72864 72864 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 213634 213634 0 0.0
.text 4007331 4007331 0 0.0
shell debug (read only) 2885577 2885577 0 0.0
(read/write) 156256 156256 0 0.0
.bss 62672 62672 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86432 86432 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 185152 185152 0 0.0
.text 2527202 2527202 0 0.0
thermostat-no-ble arm64 (read only) 4412308 4412308 0 0.0
(read/write) 242384 242384 0 0.0
.bss 121768 121768 0 0.0
.data 3360 3360 0 0.0
.data.rel.ro 103576 103576 0 0.0
.dynamic 512 512 0 0.0
.got 8616 8616 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 159116 159116 0 0.0
.text 3918696 3918696 0 0.0
tv-app debug (read only) 5670081 5670081 0 0.0
(read/write) 351432 351432 0 0.0
.bss 243344 243344 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 94328 94328 0 0.0
.dynamic 624 624 0 0.0
.got 5496 5496 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 287906 287906 0 0.0
.text 5140355 5140355 0 0.0
tv-casting-app debug (read only) 9858193 9858193 0 0.0
(read/write) 340096 340096 0 0.0
.bss 156112 156112 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 174168 174168 0 0.0
.dynamic 624 624 0 0.0
.got 5072 5072 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 382640 382640 0 0.0
.text 9009955 9009955 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531528 2531528 0 0.0
.bss 220448 220448 0 0.0
.data 5200 5200 0 0.0
.text 1494212 1494212 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1101412 1101412 0 0.0
bss 130831 130831 0 0.0
rodata 112076 112076 0 0.0
text 810664 810664 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1221356 1221356 0 0.0
bss 122921 122921 0 0.0
rodata 141772 141772 0 0.0
text 806148 806148 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1049416 1049416 0 0.0
bss 129689 129689 0 0.0
rodata 99448 99448 0 0.0
text 772444 772444 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834464 834464 0 0.0
(read/write) 1795228 1795228 0 0.0
.bss 196212 196212 0 0.0
.data 2664 2664 0 0.0
.text 1587964 1587964 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837616 837616 0 0.0
(read/write) 1717340 1717340 0 0.0
.bss 193092 193092 0 0.0
.data 2632 2632 0 0.0
.text 1513228 1513228 0 0.0
light cy8ckit_062s2_43012 (read only) 844344 844344 0 0.0
(read/write) 1636460 1636460 0 0.0
.bss 186556 186556 0 0.0
.data 2440 2440 0 0.0
.text 1439076 1439076 0 0.0
lock cy8ckit_062s2_43012 (read only) 817184 817184 0 0.0
(read/write) 1666356 1666356 0 0.0
.bss 213716 213716 0 0.0
.data 2440 2440 0 0.0
.text 1441812 1441812 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1127736 1127736 0 0.0
.bss 102456 102456 0 0.0
.data 820 820 0 0.0
.text 640120 640120 0 0.0
lock-app qpg6105+debug (read/write) 1087720 1087720 0 0.0
.bss 97200 97200 0 0.0
.data 840 840 0 0.0
.text 600100 600100 0 0.0
stm32 light STM32WB5MM-DK (read/write) 599261 599261 0 0.0
.bss 128320 128320 0 0.0
.data 668 668 0 0.0
.rodata 78820 78820 0 0.0
.text 381728 381728 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822014 822014 0 0.0
bss 49660 49660 0 0.0
text 615812 615812 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1090912 1090912 0 0.0
bss 101780 101780 0 0.0
text 792964 792964 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1048408 1048408 0 0.0
bss 110084 110084 0 0.0
text 764308 764308 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 909032 909032 0 0.0
bss 93116 93116 0 0.0
text 651696 651696 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 823694 823694 0 0.0
bss 49708 49708 0 0.0
text 617550 617550 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 929436 929436 0 0.0
bss 77708 77708 0 0.0
text 697726 697726 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1071792 1071792 0 0.0
bss 100196 100196 0 0.0
text 776650 776650 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 901772 901772 0 0.0
bss 69172 69172 0 0.0
text 652930 652930 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 927520 927520 0 0.0
bss 92696 92696 0 0.0
text 670218 670218 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 826246 826246 0 0.0
bss 49816 49816 0 0.0
text 620506 620506 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 789960 789960 0 0.0
bss 56016 56016 0 0.0
text 591256 591256 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676828 676828 0 0.0
bss 73672 73672 0 0.0
text 462306 462306 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 830986 830986 0 0.0
bss 51340 51340 0 0.0
text 623878 623878 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 849273 849273 0 0.0
bss 59492 59492 0 0.0
text 635314 635314 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 815620 815620 0 0.0
bss 56304 56304 0 0.0
text 610964 610964 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 833724 833724 0 0.0
bss 68080 68080 0 0.0
text 626220 626220 0 0.0

@andy31415 andy31415 mentioned this pull request Feb 27, 2024
Merged
@mergify mergify bot merged commit bdde9cf into project-chip:master Feb 29, 2024
58 checks passed
Sarthak-Shaha pushed a commit to Sarthak-Shaha/connectedhomeip_silabs that referenced this pull request Mar 5, 2024
@andy31415 @andreilitvin @Sarthak-Shaha
Define explicit data_model sub-targets for generated files (project…
05f5af4 
…-chip#32343)

* Define some source sets for data_model

* Update dependencies, this seems to work for non-gen for now (with odd naming)

* Rename the generate commands and hopefully this makes pregen work

* Start using privilege-constants

* Add missing file

* Fix lint error

* Fix android build ... a bit ugly as this dynamic server business is too coupled

* Restyle

* fix dependency

---------

Co-authored-by: Andrei Litvin <[email protected]>
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
@andy31415 @andreilitvin @huangxuyong
Define explicit data_model sub-targets for generated files (project…
908bdab 
…-chip#32343)

* Define some source sets for data_model

* Update dependencies, this seems to work for non-gen for now (with odd naming)

* Rename the generate commands and hopefully this makes pregen work

* Start using privilege-constants

* Add missing file

* Fix lint error

* Fix android build ... a bit ugly as this dynamic server business is too coupled

* Restyle

* fix dependency

---------

Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@tehampson tehampson tehampson approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app gn review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andy31415 @tcarmelveilleux @tehampson @yunhanw-google @bzbarsky-apple @andreilitvin