-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have PairingSession::EncodeSessionParameters require local MRP values #32324
Merged
tehampson
merged 8 commits into
project-chip:master
from
tehampson:fix-EncodeSessionParameters-to-always-have-mrp-parameters
Feb 29, 2024
Merged
Have PairingSession::EncodeSessionParameters require local MRP values #32324
tehampson
merged 8 commits into
project-chip:master
from
tehampson:fix-EncodeSessionParameters-to-always-have-mrp-parameters
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
February 26, 2024 20:13
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 26, 2024 20:13
53 tasks
PR #32324: Size comparison from 44ca395 to 8c46e51 Increases (18 builds for cc13x4_26x4, cc32xx, k32w, nrfconnect, qpg, stm32)
Full report (19 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
PR #32324: Size comparison from 44ca395 to 1bf8876 Increases (33 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32)
Decreases (13 builds for bl602, bl702, bl702l, esp32, linux)
Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #32324: Size comparison from 44ca395 to d2958fe Increases above 0.2%:
Increases (45 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32)
Decreases (28 builds for bl602, bl702, bl702l, esp32, linux, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Damian-Nordic
approved these changes
Feb 29, 2024
bzbarsky-apple
approved these changes
Feb 29, 2024
pidarped
approved these changes
Feb 29, 2024
Sarthak-Shaha
pushed a commit
to Sarthak-Shaha/connectedhomeip_silabs
that referenced
this pull request
Mar 5, 2024
…project-chip#32324) * Have PairingSession::EncodeSessionParameters require local MRP values
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…project-chip#32324) * Have PairingSession::EncodeSessionParameters require local MRP values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30456
As per
GetLocalMRPConfig()
documentation:In addition to that comment I validated all location where we call
EncodeSessionParameters
. This happens insrc/protocols/secure_channel/CASESession.cpp
andsrc/protocols/secure_channel/PASESession.cpp
with the member variablemLocalMRPConfig
. The following are the four locations where that is set, and where they come fromCASESession::PrepareForSessionEstablishment
GetLocalMRPConfig()
over hereCASESession::EstablishSession
CASEClient::EstablishSession
hereOperationalSessionSetup::EstablishConnection
where MRP values are inmInitParams.mrpLocalConfig
hereGetLocalMRPConfig()
connectedhomeip/src/controller/CHIPDeviceControllerFactory.cpp
Line 273 in 44ca395
PASESession::WaitForPairing
CommissioningWindowManager::AdvertiseAndListenForPASE
hereGetLocalMRPConfig()
PASESession::Pair
DeviceCommissioner::EstablishPASEConnection
hereGetLocalMRPConfig()