-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Matter.framework] Get downloadLogOfType to work over XPC #32319
Merged
mergify
merged 5 commits into
project-chip:master
from
vivien-apple:DiagnosticLogs_OverXPC
Feb 26, 2024
Merged
[Matter.framework] Get downloadLogOfType to work over XPC #32319
mergify
merged 5 commits into
project-chip:master
from
vivien-apple:DiagnosticLogs_OverXPC
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
February 26, 2024 12:02
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 26, 2024 12:02
PR #32319: Size comparison from 8f2a4d2 to f31bfbb Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
vivien-apple
force-pushed
the
DiagnosticLogs_OverXPC
branch
from
February 26, 2024 12:27
f31bfbb
to
71c12d2
Compare
PR #32319: Size comparison from 8f2a4d2 to 71c12d2 Decreases (3 builds for efr32)
Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
…e the downloadLogOfType completion is done
vivien-apple
force-pushed
the
DiagnosticLogs_OverXPC
branch
from
February 26, 2024 13:27
71c12d2
to
5f786b7
Compare
PR #32319: Size comparison from 8f2a4d2 to 5f786b7 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
woody-apple
approved these changes
Feb 26, 2024
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…ip#32319) * [Matter.framework] Move downloadLogOfType from MTRDevice to MTRBaseDevice * [Matter.framework] Get downloadLogOfType to work over XPC * Add a simple test to MTRXPCProtocolTests.m to check that the XPC protocol works * Add a simple test to MTRXPCListenerSampleTests * [Matter.framework] Do not delete the file containing the log data once the downloadLogOfType completion is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MTRDevice.downloadLogOfType
does not work across XPC.