Re-enable clang-tidy check for enum value range validation
#32289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
setup payload
lib
crypto
app
tests
support
core
icd
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #32289: Size comparison from ef8ee32 to 5baea9e Increases (44 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (4 builds for bl702l, efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #32289: Size comparison from ef8ee32 to 400a39b Increases above 0.2%:
Increases (42 builds for bl602, bl702, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (13 builds for bl602, bl702, bl702l, k32w, linux, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #32289: Size comparison from ef8ee32 to 7285802 Increases above 0.2%:
Increases (42 builds for bl602, bl702, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, stm32, telink)
Decreases (13 builds for bl602, bl702, bl702l, k32w, linux, qpg)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #32289: Size comparison from 44ca395 to 69644de Increases (42 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (5 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
| @@ -391,6 +391,8 @@ void ICDManager::SetKeepActiveModeRequirements(KeepActiveFlags flag, bool state) | |||
| { | |||
| assertChipStackLockedByCurrentThread(); | |||
|
|
|||
| // TODO: fix lint: https://github.com/project-chip/connectedhomeip/issues/32249 | |||
There was a problem hiding this comment.
That dos not look like the right link.
| @@ -511,6 +513,9 @@ void ICDManager::OnActiveRequestWithdrawal(KeepActiveFlags request) | |||
| { | |||
| // Only 1 request per type (kCommissioningWindowOpen, kFailSafeArmed) | |||
| // remove requirement directly | |||
|
|
|||
| // TODO: fix lint: https://github.com/project-chip/connectedhomeip/issues/32249 | |||
| @@ -2692,6 +2692,8 @@ static void TestVIDPID_StringExtraction(nlTestSuite * inSuite, void * inContext) | |||
| { DNAttrType::kMatterPID, ByteSpan(reinterpret_cast<const uint8_t *>(sTestMatterAttribute14), strlen(sTestMatterAttribute14)), false, false, chip::VendorId::NotSpecified, 0, CHIP_ERROR_WRONG_CERT_DN }, | |||
| // Common Name (CN) VID/PID encoding examples: | |||
| { DNAttrType::kCommonName, ByteSpan(reinterpret_cast<const uint8_t *>(sTestCNAttribute01), strlen(sTestCNAttribute01)), true, false, chip::VendorId::TestVendor1, 0, CHIP_NO_ERROR }, | |||
| // TODO: fix lint: https://github.com/project-chip/connectedhomeip/issues/32249 | |||
| @@ -122,6 +122,9 @@ TLVType TLVReader::GetType() const | |||
| return kTLVType_FloatingPointNumber; | |||
| if (elemType == TLVElementType::NotSpecified || elemType >= TLVElementType::Null) | |||
| return static_cast<TLVType>(elemType); | |||
|
|
|||
| // TODO: fix lint: https://github.com/project-chip/connectedhomeip/issues/32249 | |||
There was a problem hiding this comment.
All these issue links are wrong....
|
In various places of our code we seem to rely on enums being used as a bitmap (and this results in out of range values). Not fixing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minimal fixes (e.g. adding equality operator for BitFlags) and in many case I just flagged things as nolint so that we can iterate over fixes.
enum checks also somehow made
cast through voiddetection much stricter, so I updated all the instances of that in linux platform (all DBUS casts seem to go through void, and I found no good way to mass-disable without disabling entire platform from all tidy checks)