-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup controller by storage fabric, without providing NOC chain #32194
Merged
mergify
merged 1 commit into
project-chip:master
from
DejinChen:setup_controller_by_storage_fabric
Mar 29, 2024
Merged
Setup controller by storage fabric, without providing NOC chain #32194
mergify
merged 1 commit into
project-chip:master
from
DejinChen:setup_controller_by_storage_fabric
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DejinChen
commented
Feb 18, 2024
- For an NOC installed controller, the operational key pair and NOC chain are still required during device reboot and SetupController. Without these, 'mFabricIndex' can not be updated even if there is a fabric in storage. For this, introduce a parameter to use storage fabric and update fabric index.
- Enable a dedicated way to update NOC independently after controller initialization, eliminating the need for re-initialization.
- Limit the check of 'operationalCredentialsDelegate' to commissioner roles exclusively.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
February 18, 2024 09:40
PR #32194: Size comparison from 8f2a4d2 to f5529c0 Increases (3 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
DejinChen
force-pushed
the
setup_controller_by_storage_fabric
branch
from
March 5, 2024 04:35
f5529c0
to
a34660d
Compare
PR #32194: Size comparison from 8ad1fc3 to a34660d Increases (3 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
DejinChen
force-pushed
the
setup_controller_by_storage_fabric
branch
from
March 5, 2024 06:59
a34660d
to
c64cefb
Compare
PR #32194: Size comparison from 3d47e35 to c64cefb Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
DejinChen
force-pushed
the
setup_controller_by_storage_fabric
branch
from
March 6, 2024 12:32
c64cefb
to
ac5c197
Compare
PR #32194: Size comparison from e52724f to ac5c197 Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
DejinChen
force-pushed
the
setup_controller_by_storage_fabric
branch
from
March 7, 2024 11:25
ac5c197
to
e876e65
Compare
PR #32194: Size comparison from 873e665 to e876e65 Increases (3 builds for linux)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
DejinChen
force-pushed
the
setup_controller_by_storage_fabric
branch
from
March 14, 2024 12:06
e876e65
to
f7bc2ba
Compare
PR #32194: Size comparison from c90481f to f7bc2ba Increases above 0.2%:
Increases (3 builds for linux)
Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
DejinChen
force-pushed
the
setup_controller_by_storage_fabric
branch
from
March 20, 2024 07:16
f7bc2ba
to
be8b650
Compare
…d update NOC after DeviceController::Init
DejinChen
force-pushed
the
setup_controller_by_storage_fabric
branch
from
March 20, 2024 07:24
be8b650
to
55297c0
Compare
PR #32194: Size comparison from 43202d9 to 55297c0 Increases (3 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Mar 26, 2024
arkq
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.