-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Pass write response status from jni to application #32164
[Android] Pass write response status from jni to application #32164
Conversation
15457e3
to
4122563
Compare
321140b
to
5143ef8
Compare
PR #32164: Size comparison from d116c7c to 5143ef8 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
5143ef8
to
541f2a9
Compare
PR #32164: Size comparison from c13b324 to 67b4d29 Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg, stm32)
|
67b4d29
to
9d088f2
Compare
8f8b10b
to
4e0f4c3
Compare
PR #32164: Size comparison from c13b324 to 4e0f4c3 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
4e0f4c3
to
9199622
Compare
PR #32164: Size comparison from 2f2c4f1 to 9199622 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
1197a1a
to
a82c86c
Compare
PR #32164: Size comparison from 2f2c4f1 to a82c86c Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
a82c86c
to
710a618
Compare
PR #32164: Size comparison from 2f2c4f1 to 710a618 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
710a618
to
a6f4776
Compare
PR #32164: Size comparison from 2f2c4f1 to a6f4776 Full report (3 builds for cc32xx, stm32)
|
4ad7ac4
to
2343faa
Compare
PR #32164: Size comparison from 2f2c4f1 to 2343faa Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg, stm32)
|
2343faa
to
925ca4e
Compare
PR #32164: Size comparison from acedec1 to 925ca4e Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
925ca4e
to
ed246a1
Compare
PR #32164: Size comparison from acedec1 to ed246a1 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
ed246a1
to
9615bdb
Compare
PR #32164: Size comparison from acedec1 to 9615bdb Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
-- WriteResposne could have multiple attributePath+Status, in current code, each status has been converted a Error, multiple onError could cause application crash since onError is treated as fatal error path, status in Response should go with normal onResponse path from jni to application.
-- Fix the above issue via reporting error via OnResponse.
-- Update across the android and java/kotlin code.