Remove PoolCommon::ResetObject #32120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #32120: Size comparison from 598356c to 2015058 Increases (2 builds for linux)
Decreases (14 builds for linux)
Full report (14 builds for linux)
|
|
PR #32120: Size comparison from 598356c to c5885a8 Increases (48 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, stm32, telink)
Decreases (30 builds for bl602, bl702, cc32xx, efr32, esp32, linux, nrfconnect, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #32120: Size comparison from 598356c to 34d4707 Increases (29 builds for bl702, bl702l, cc13x4_26x4, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
Decreases (16 builds for bl602, bl702, bl702l, cc32xx, linux, nrfconnect, psoc6)
Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
bzbarsky-apple
approved these changes
Feb 14, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #32120: Size comparison from 598356c to a7135f4 Increases (50 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (32 builds for bl602, bl702, bl702l, cc32xx, efr32, esp32, linux, nrfconnect, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
robszewczyk
approved these changes
Feb 14, 2024
pidarped
approved these changes
Feb 14, 2024
raul-marquez-csa
pushed a commit
to raul-marquez-csa/connectedhomeip
that referenced
this pull request
Feb 16, 2024
* Remove PoolCommon: bad name, non-member method, very very limited usage * Restyle * Added comment about returning null on failure * Fix compile on fixed size pools * Restyle * Switch to not use a cast * Fix types ... use auto because types are messy, unsure why * Rename for smaller diff * Rename for smaller diff * Update src/transport/UnauthenticatedSessionTable.h Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class had a catch-all name (common) and implemented only a single method that should not have been a class method to start with (it does not depend on the class).
Rather than implementing the ResetObject as a global method, I replaced its one single usage with a free + alloc. This is slightly slower, however it should be much more readable.