-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ICD configurations to duration to match the SDK #32109
Merged
mergify
merged 1 commit into
project-chip:master
from
mkardous-silabs:fix/rename_icd_arguments
Feb 13, 2024
Merged
Rename ICD configurations to duration to match the SDK #32109
mergify
merged 1 commit into
project-chip:master
from
mkardous-silabs:fix/rename_icd_arguments
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
February 13, 2024 20:15
pullapprove
bot
requested review from
tehampson,
tobiasgraf,
turon,
tima-q,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 13, 2024 20:15
PR #32109: Size comparison from 06c5769 to 0281731 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Feb 13, 2024
yunhanw-google
approved these changes
Feb 13, 2024
andy31415
approved these changes
Feb 13, 2024
bzbarsky-apple
approved these changes
Feb 13, 2024
tcarmelveilleux
approved these changes
Feb 13, 2024
raul-marquez-csa
pushed a commit
to raul-marquez-csa/connectedhomeip
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR renames remaining ICD configs from Interval to Duration to match SDK and spec.
PR has not functionnal changes. Relying on CI.