Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get some RAM savings by re-ordering some structure members based on pahole feedback #32106

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Get some RAM savings by re-ordering some structure members based on pahole feedback #32106

merged 1 commit into from
Feb 14, 2024

Conversation

andy31415
Copy link
Contributor

Just randomly picked some structures, to see if going this path is even remotely worthwile.

Expectation is that RAM usage should decrease in some platforms.

@github-actions github-actions bot added the lib label Feb 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

PR #32106: Size comparison from ea56e40 to 9a87b7b

Increases (20 builds for bl702l, linux, psoc6, telink)
platform target config section ea56e40 9a87b7b change % change
bl702l lighting-app bl702l+mfd (read/write) 1176416 1176776 360 0.0
linux air-purifier-app debug (read only) 2628629 2628829 200 0.0
.text 2265797 2266117 320 0.0
all-clusters-app debug (read only) 5880545 5880729 184 0.0
.text 5100515 5100819 304 0.0
all-clusters-minimal-app debug (read only) 5193121 5193321 200 0.0
.text 4670147 4670467 320 0.0
bridge-app debug (read only) 4601561 4601761 200 0.0
.text 4151971 4152291 320 0.0
chip-tool debug (read only) 11977505 11977713 208 0.0
.text 10824563 10824899 336 0.0
chip-tool-ipv6only arm64 (read/write) 591232 591456 224 0.0
lighting-app debug+rpc+ui (read only) 5523017 5523209 192 0.0
.text 4922595 4922915 320 0.0
lock-app debug (read only) 4680417 4680601 184 0.0
.text 4212323 4212627 304 0.0
ota-provider-app debug (read only) 4302545 4302729 184 0.0
.text 3901459 3901763 304 0.0
ota-requestor-app debug (read only) 4418529 4418729 200 0.0
.text 4007139 4007459 320 0.0
shell debug (read only) 2866265 2866441 176 0.0
.text 2507378 2507682 304 0.0
thermostat-no-ble arm64 (read/write) 246568 246680 112 0.0
tv-app debug (read only) 5652281 5652513 232 0.0
.text 5123651 5124003 352 0.0
tv-casting-app debug (read only) 9855569 9855713 144 0.0
.text 9007363 9007635 272 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834568 834584 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837624 837640 16 0.0
light cy8ckit_062s2_43012 (read only) 844352 844368 16 0.0
lock cy8ckit_062s2_43012 (read only) 817152 817168 16 0.0
telink shell tlsr9518adk80d text 462228 462234 6 0.0
Decreases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section ea56e40 9a87b7b change % change
bl602 lighting-app bl602 (read/write) 1430866 1430678 -188 -0.0
.bss 85320 85304 -16 -0.0
.rodata 157436 157376 -60 -0.0
.text 1097972 1097862 -110 -0.0
bl602+mfd (read/write) 1445274 1445086 -188 -0.0
.bss 85480 85464 -16 -0.0
.rodata 156396 156336 -60 -0.0
.text 1113274 1113164 -110 -0.0
bl602+rpc (read/write) 1478250 1478062 -188 -0.0
.bss 93352 93336 -16 -0.0
.rodata 165004 164944 -60 -0.0
.text 1129358 1129248 -110 -0.0
bl702 lighting-app bl702 (read/write) 1195431 1195279 -152 -0.0
.rodata 106820 106700 -120 -0.1
.text 966976 966944 -32 -0.0
bl702+mfd (read/write) 1206487 1206335 -152 -0.0
.rodata 105760 105640 -120 -0.1
.text 978986 978954 -32 -0.0
bl702+rpc (read/write) 1287155 1287003 -152 -0.0
.rodata 122192 122072 -120 -0.1
.text 1041920 1041888 -32 -0.0
bl706-eth (read/write) 1014073 1013889 -184 -0.0
.rodata 100140 100080 -60 -0.1
.text 759052 758942 -110 -0.0
bl706-wifi (read/write) 1247266 1247094 -172 -0.0
.rodata 121120 121060 -60 -0.0
.text 989488 989390 -98 -0.0
bl702l lighting-app bl702l (read/write) 1165012 1164860 -152 -0.0
.rodata 100824 100704 -120 -0.1
.text 960078 960046 -32 -0.0
bl702l+mfd .rodata 99764 99644 -120 -0.1
.text 972400 972368 -32 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 781324 781204 -120 -0.0
.rodata 90372 90252 -120 -0.1
lock-ftd LP_EM_CC1354P10_6 (read only) 800228 800108 -120 -0.0
.rodata 84780 84660 -120 -0.1
lock-mtd LP_EM_CC1354P10_6 (read only) 788804 788676 -128 -0.0
.rodata 111516 111396 -120 -0.1
.text 677024 677016 -8 -0.0
pump-app LP_EM_CC1354P10_6 (read only) 739116 738988 -128 -0.0
.rodata 86092 85972 -120 -0.1
.text 652760 652752 -8 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724732 724612 -120 -0.0
.rodata 81932 81812 -120 -0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581242 581170 -72 -0.0
(read/write) 207976 207960 -16 -0.0
.bss 201212 201196 -16 -0.0
.rodata 86538 86474 -64 -0.1
.text 492580 492576 -4 -0.0
lock CC3235SF_LAUNCHXL (read only) 628698 628618 -80 -0.0
(read/write) 208360 208344 -16 -0.0
.bss 201744 201728 -16 -0.0
.rodata 107146 107082 -64 -0.1
.text 519428 519416 -12 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 564779 564675 -104 -0.0
.app_xip_area 454637 454533 -104 -0.0
lock cyw930739m2evb_01 (read/write) 549883 549779 -104 -0.0
.app_xip_area 434941 434837 -104 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 566427 566307 -120 -0.0
.app_xip_area 457789 457669 -120 -0.0
switch cyw930739m2evb_01 (read/write) 563243 563123 -120 -0.0
.app_xip_area 451285 451165 -120 -0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 928632 928528 -104 -0.0
.bss 197904 197888 -16 -0.0
.text 729320 729228 -92 -0.0
BRD4187C (read/write) 1105424 1105308 -116 -0.0
.text 906900 906784 -116 -0.0
lock-app BRD4161A+wf200 (read/write) 1123108 1123024 -84 -0.0
.bss 188288 188272 -16 -0.0
.text 932008 931940 -68 -0.0
window-app BRD4187C (read/write) 1159528 1159404 -124 -0.0
.text 987308 987184 -124 -0.0
esp32 all-clusters-app c3devkit (read only) 1203510 1203498 -12 -0.0
(read/write) 1747896 1747824 -72 -0.0
.dram0.bss 74200 74184 -16 -0.0
.flash.rodata 250536 250480 -56 -0.0
.flash.text 1203510 1203498 -12 -0.0
m5stack (read only) 1245019 1244995 -24 -0.0
(read/write) 532804 532732 -72 -0.0
.dram0.bss 81048 81032 -16 -0.0
.flash.rodata 280672 280616 -56 -0.0
.flash.text 1238855 1238831 -24 -0.0
k32w contact k32w0+release (read only) 611144 611024 -120 -0.0
.text 610608 610488 -120 -0.0
k32w1+release (read/write) 696568 696440 -128 -0.0
.text 582544 582416 -128 -0.0
light k32w0+release (read only) 599336 599216 -120 -0.0
.text 598800 598680 -120 -0.0
k32w1+release (read/write) 787512 787384 -128 -0.0
.text 664616 664488 -128 -0.0
lock k32w0+release (read only) 581792 581672 -120 -0.0
.text 581256 581136 -120 -0.0
linux air-purifier-app debug (read/write) 129376 129360 -16 -0.0
.bss 46944 46928 -16 -0.0
.rodata 184968 184848 -120 -0.1
all-clusters-app debug (read/write) 479344 479328 -16 -0.0
.bss 134704 134688 -16 -0.0
.rodata 347720 347600 -120 -0.0
all-clusters-minimal-app debug (read/write) 236608 236592 -16 -0.0
.bss 128080 128064 -16 -0.0
.rodata 288154 288034 -120 -0.0
bridge-app debug .rodata 228922 228802 -120 -0.1
chip-tool debug .rodata 447705 447577 -128 -0.0
chip-tool-ipv6only arm64 (read only) 11473296 11473064 -232 -0.0
.bss 103320 103304 -16 -0.0
.rodata 353004 352884 -120 -0.0
.text 10232908 10232796 -112 -0.0
lighting-app debug+rpc+ui (read/write) 226376 226360 -16 -0.0
.bss 119512 119496 -16 -0.0
.rodata 353652 353524 -128 -0.0
lock-app debug (read/write) 205552 205536 -16 -0.0
.bss 114064 114048 -16 -0.0
.rodata 255418 255298 -120 -0.0
ota-provider-app debug (read/write) 193808 193776 -32 -0.0
.bss 113824 113792 -32 -0.0
.rodata 207770 207650 -120 -0.1
ota-requestor-app debug (read/write) 198056 198024 -32 -0.0
.bss 114720 114688 -32 -0.0
.rodata 213786 213666 -120 -0.1
shell debug .rodata 186080 185952 -128 -0.1
thermostat-no-ble arm64 (read only) 4482408 4482288 -120 -0.0
.bss 122344 122328 -16 -0.0
.rodata 159420 159300 -120 -0.1
tv-app debug (read/write) 351944 351864 -80 -0.0
.bss 243872 243792 -80 -0.0
.rodata 286682 286562 -120 -0.0
tv-casting-app debug (read/write) 340496 340464 -32 -0.0
.bss 156624 156592 -32 -0.0
.rodata 382480 382352 -128 -0.0
mbed lock-app-release cy8cproto_062_4343w (read/write) 2532024 2531968 -56 -0.0
.bss 220480 220464 -16 -0.0
.text 1494708 1494652 -56 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1096972 1096852 -120 -0.0
rodata 111732 111612 -120 -0.1
text 806692 806688 -4 -0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1217320 1217228 -92 -0.0
bss 122827 122811 -16 -0.0
rodata 141592 141532 -60 -0.0
text 802388 802376 -12 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1046748 1046628 -120 -0.0
rodata 99388 99268 -120 -0.1
text 769960 769956 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1791156 1791060 -96 -0.0
.bss 196116 196100 -16 -0.0
.text 1583996 1583916 -80 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1715452 1715356 -96 -0.0
.bss 193084 193068 -16 -0.0
.text 1511348 1511268 -80 -0.0
light cy8ckit_062s2_43012 (read/write) 1634764 1634684 -80 -0.0
.bss 186548 186532 -16 -0.0
.text 1437388 1437324 -64 -0.0
lock cy8ckit_062s2_43012 (read/write) 1667076 1666980 -96 -0.0
.bss 213748 213732 -16 -0.0
.text 1442500 1442420 -80 -0.0
qpg lighting-app qpg6105+debug (read/write) 1124832 1124704 -128 -0.0
.text 637216 637088 -128 -0.0
lock-app qpg6105+debug (read/write) 1089624 1089504 -120 -0.0
.text 602004 601884 -120 -0.0
stm32 light STM32WB5MM-DK (read/write) 597197 597077 -120 -0.0
.rodata 78828 78708 -120 -0.2
telink air-quality-sensor-app tlsr9528a_retention (read/write) 825790 825662 -128 -0.0
text 617518 617508 -10 -0.0
all-clusters-app tlsr9518adk80d (read/write) 1085788 1085660 -128 -0.0
text 788336 788326 -10 -0.0
all-clusters-minimal-app tlsr9528a (read/write) 1045016 1044888 -128 -0.0
text 761032 761022 -10 -0.0
bridge-app tlsr9518adk80d (read/write) 907028 906900 -128 -0.0
text 649692 649682 -10 -0.0
contact-sensor-app tlsr9528a_retention (read/write) 827390 827262 -128 -0.0
text 619180 619170 -10 -0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 933656 933528 -128 -0.0
text 699864 699854 -10 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1068512 1068376 -136 -0.0
text 773490 773480 -10 -0.0
lock-app-dfu tlsr9528a (read/write) 906684 906548 -136 -0.0
text 655674 655664 -10 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 924808 924680 -128 -0.0
text 667584 667574 -10 -0.0
pump-app tlsr9258a_retention (read/write) 829998 829862 -136 -0.0
text 622182 622172 -10 -0.0
pump-controller-app tlsr9518adk80d (read/write) 793720 793592 -128 -0.0
text 592948 592938 -10 -0.0
shell tlsr9518adk80d (read/write) 676828 676716 -112 -0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 828654 828526 -128 -0.0
text 621534 621524 -10 -0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 852333 852205 -128 -0.0
text 636380 636370 -10 -0.0
thermostat tlsr9518adk80d (read/write) 819308 819180 -128 -0.0
text 612580 612570 -10 -0.0
window-covering tlsr9258a (read/write) 838764 838636 -128 -0.0
text 629088 629078 -10 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section ea56e40 9a87b7b change % change
bl602 lighting-app bl602 (read/write) 1430866 1430678 -188 -0.0
.bss 85320 85304 -16 -0.0
.data 9496 9496 0 0.0
.rodata 157436 157376 -60 -0.0
.text 1097972 1097862 -110 -0.0
bl602+mfd (read/write) 1445274 1445086 -188 -0.0
.bss 85480 85464 -16 -0.0
.data 9472 9472 0 0.0
.rodata 156396 156336 -60 -0.0
.text 1113274 1113164 -110 -0.0
bl602+rpc (read/write) 1478250 1478062 -188 -0.0
.bss 93352 93336 -16 -0.0
.data 9872 9872 0 0.0
.rodata 165004 164944 -60 -0.0
.text 1129358 1129248 -110 -0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1195431 1195279 -152 -0.0
.bss 11121 11121 0 0.0
.data 3680 3680 0 0.0
.rodata 106820 106700 -120 -0.1
.text 966976 966944 -32 -0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1206487 1206335 -152 -0.0
.bss 11297 11297 0 0.0
.data 3656 3656 0 0.0
.rodata 105760 105640 -120 -0.1
.text 978986 978954 -32 -0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1287155 1287003 -152 -0.0
.bss 19589 19589 0 0.0
.data 4224 4224 0 0.0
.rodata 122192 122072 -120 -0.1
.text 1041920 1041888 -32 -0.0
bl706-eth (read/write) 1014073 1013889 -184 -0.0
.bss 23680 23680 0 0.0
.data 3248 3248 0 0.0
.rodata 100140 100080 -60 -0.1
.text 759052 758942 -110 -0.0
bl706-wifi (read/write) 1247266 1247094 -172 -0.0
.bss 10565 10565 0 0.0
.data 3688 3688 0 0.0
.rodata 121120 121060 -60 -0.0
.text 989488 989390 -98 -0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1165012 1164860 -152 -0.0
.bss 16316 16316 0 0.0
.data 5040 5040 0 0.0
.rodata 100824 100704 -120 -0.1
.text 960078 960046 -32 -0.0
bl702l+mfd (read/write) 1176416 1176776 360 0.0
.bss 16492 16492 0 0.0
.data 5024 5024 0 0.0
.rodata 99764 99644 -120 -0.1
.text 972400 972368 -32 -0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 781324 781204 -120 -0.0
(read/write) 168904 168904 0 0.0
.bss 90908 90908 0 0.0
.data 3560 3560 0 0.0
.rodata 90372 90252 -120 -0.1
.text 690688 690688 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 800228 800108 -120 -0.0
(read/write) 179184 179184 0 0.0
.bss 101188 101188 0 0.0
.data 3560 3560 0 0.0
.rodata 84780 84660 -120 -0.1
.text 715184 715184 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788804 788676 -128 -0.0
(read/write) 173632 173632 0 0.0
.bss 95636 95636 0 0.0
.data 3560 3560 0 0.0
.rodata 111516 111396 -120 -0.1
.text 677024 677016 -8 -0.0
pump-app LP_EM_CC1354P10_6 (read only) 739116 738988 -128 -0.0
(read/write) 167880 167880 0 0.0
.bss 89648 89648 0 0.0
.data 3552 3552 0 0.0
.rodata 86092 85972 -120 -0.1
.text 652760 652752 -8 -0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724732 724612 -120 -0.0
(read/write) 168080 168080 0 0.0
.bss 89864 89864 0 0.0
.data 3544 3544 0 0.0
.rodata 81932 81812 -120 -0.1
.text 642536 642536 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581242 581170 -72 -0.0
(read/write) 207976 207960 -16 -0.0
.bss 201212 201196 -16 -0.0
.data 1640 1640 0 0.0
.rodata 86538 86474 -64 -0.1
.text 492580 492576 -4 -0.0
lock CC3235SF_LAUNCHXL (read only) 628698 628618 -80 -0.0
(read/write) 208360 208344 -16 -0.0
.bss 201744 201728 -16 -0.0
.data 1496 1496 0 0.0
.rodata 107146 107082 -64 -0.1
.text 519428 519416 -12 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 564779 564675 -104 -0.0
.app_xip_area 454637 454533 -104 -0.0
.bss 64976 64976 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 549883 549779 -104 -0.0
.app_xip_area 434941 434837 -104 -0.0
.bss 69768 69768 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566427 566307 -120 -0.0
.app_xip_area 457789 457669 -120 -0.0
.bss 63512 63512 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 563243 563123 -120 -0.0
.app_xip_area 451285 451165 -120 -0.0
.bss 66752 66752 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 928632 928528 -104 -0.0
.bss 197904 197888 -16 -0.0
.data 1388 1388 0 0.0
.text 729320 729228 -92 -0.0
BRD4187C (read/write) 1105424 1105308 -116 -0.0
.bss 195100 195100 0 0.0
.data 3404 3404 0 0.0
.text 906900 906784 -116 -0.0
lock-app BRD4161A+wf200 (read/write) 1123108 1123024 -84 -0.0
.bss 188288 188272 -16 -0.0
.data 2792 2792 0 0.0
.text 932008 931940 -68 -0.0
window-app BRD4187C (read/write) 1159528 1159404 -124 -0.0
.bss 168884 168884 0 0.0
.data 3316 3316 0 0.0
.text 987308 987184 -124 -0.0
esp32 all-clusters-app c3devkit (read only) 1203510 1203498 -12 -0.0
(read/write) 1747896 1747824 -72 -0.0
.dram0.bss 74200 74184 -16 -0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 250536 250480 -56 -0.0
.flash.text 1203510 1203498 -12 -0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1245019 1244995 -24 -0.0
(read/write) 532804 532732 -72 -0.0
.dram0.bss 81048 81032 -16 -0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 280672 280616 -56 -0.0
.flash.text 1238855 1238831 -24 -0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 611144 611024 -120 -0.0
(read/write) 81392 81392 0 0.0
.bss 69184 69184 0 0.0
.data 2224 2224 0 0.0
.text 610608 610488 -120 -0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 696568 696440 -128 -0.0
.bss 67752 67752 0 0.0
.data 2800 2800 0 0.0
.text 582544 582416 -128 -0.0
light k32w0+release (read only) 599336 599216 -120 -0.0
(read/write) 79344 79344 0 0.0
.bss 67160 67160 0 0.0
.data 2200 2200 0 0.0
.text 598800 598680 -120 -0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787512 787384 -128 -0.0
.bss 77428 77428 0 0.0
.data 2016 2016 0 0.0
.text 664616 664488 -128 -0.0
lock k32w0+release (read only) 581792 581672 -120 -0.0
(read/write) 78836 78836 0 0.0
.bss 66704 66704 0 0.0
.data 2148 2148 0 0.0
.text 581256 581136 -120 -0.0
linux air-purifier-app debug (read only) 2628629 2628829 200 0.0
(read/write) 129376 129360 -16 -0.0
.bss 46944 46928 -16 -0.0
.data 2240 2240 0 0.0
.data.rel.ro 74248 74248 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 184968 184848 -120 -0.1
.text 2265797 2266117 320 0.0
all-clusters-app debug (read only) 5880545 5880729 184 0.0
(read/write) 479344 479328 -16 -0.0
.bss 134704 134688 -16 -0.0
.data 4432 4432 0 0.0
.data.rel.ro 332808 332808 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1368 1368 0 0.0
.rodata 347720 347600 -120 -0.0
.text 5100515 5100819 304 0.0
all-clusters-minimal-app debug (read only) 5193121 5193321 200 0.0
(read/write) 236608 236592 -16 -0.0
.bss 128080 128064 -16 -0.0
.data 4336 4336 0 0.0
.data.rel.ro 97096 97096 0 0.0
.dynamic 624 624 0 0.0
.got 5304 5304 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 288154 288034 -120 -0.0
.text 4670147 4670467 320 0.0
bridge-app debug (read only) 4601561 4601761 200 0.0
(read/write) 217592 217592 0 0.0
.bss 118560 118560 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 86160 86160 0 0.0
.dynamic 624 624 0 0.0
.got 5272 5272 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 228922 228802 -120 -0.1
.text 4151971 4152291 320 0.0
chip-tool debug (read only) 11977505 11977713 208 0.0
(read/write) 521016 521016 0 0.0
.bss 94296 94296 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 414384 414384 0 0.0
.dynamic 624 624 0 0.0
.got 5776 5776 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 447705 447577 -128 -0.0
.text 10824563 10824899 336 0.0
chip-tool-ipv6only arm64 (read only) 11473296 11473064 -232 -0.0
(read/write) 591232 591456 224 0.0
.bss 103320 103304 -16 -0.0
.data 4480 4480 0 0.0
.data.rel.ro 454144 454144 0 0.0
.dynamic 512 512 0 0.0
.got 20360 20360 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 353004 352884 -120 -0.0
.text 10232908 10232796 -112 -0.0
lighting-app debug+rpc+ui (read only) 5523017 5523209 192 0.0
(read/write) 226376 226360 -16 -0.0
.bss 119512 119496 -16 -0.0
.data 4800 4800 0 0.0
.data.rel.ro 94560 94560 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 353652 353524 -128 -0.0
.text 4922595 4922915 320 0.0
lock-app debug (read only) 4680417 4680601 184 0.0
(read/write) 205552 205536 -16 -0.0
.bss 114064 114048 -16 -0.0
.data 4096 4096 0 0.0
.data.rel.ro 80664 80664 0 0.0
.dynamic 624 624 0 0.0
.got 5224 5224 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 255418 255298 -120 -0.0
.text 4212323 4212627 304 0.0
ota-provider-app debug (read only) 4302545 4302729 184 0.0
(read/write) 193808 193776 -32 -0.0
.bss 113824 113792 -32 -0.0
.data 4304 4304 0 0.0
.data.rel.ro 69760 69760 0 0.0
.dynamic 624 624 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 207770 207650 -120 -0.1
.text 3901459 3901763 304 0.0
ota-requestor-app debug (read only) 4418529 4418729 200 0.0
(read/write) 198056 198024 -32 -0.0
.bss 114720 114688 -32 -0.0
.data 4704 4704 0 0.0
.data.rel.ro 72720 72720 0 0.0
.dynamic 624 624 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 213786 213666 -120 -0.1
.text 4007139 4007459 320 0.0
shell debug (read only) 2866265 2866441 176 0.0
(read/write) 155784 155784 0 0.0
.bss 62576 62576 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86040 86040 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 186080 185952 -128 -0.1
.text 2507378 2507682 304 0.0
thermostat-no-ble arm64 (read only) 4482408 4482288 -120 -0.0
(read/write) 246568 246680 112 0.0
.bss 122344 122328 -16 -0.0
.data 3352 3352 0 0.0
.data.rel.ro 103712 103712 0 0.0
.dynamic 512 512 0 0.0
.got 12216 12216 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 159420 159300 -120 -0.1
.text 3977596 3977596 0 0.0
tv-app debug (read only) 5652281 5652513 232 0.0
(read/write) 351944 351864 -80 -0.0
.bss 243872 243792 -80 -0.0
.data 6496 6496 0 0.0
.data.rel.ro 94264 94264 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 286682 286562 -120 -0.0
.text 5123651 5124003 352 0.0
tv-casting-app debug (read only) 9855569 9855713 144 0.0
(read/write) 340496 340464 -32 -0.0
.bss 156624 156592 -32 -0.0
.data 2912 2912 0 0.0
.data.rel.ro 174040 174040 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 382480 382352 -128 -0.0
.text 9007363 9007635 272 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2532024 2531968 -56 -0.0
.bss 220480 220464 -16 -0.0
.data 5200 5200 0 0.0
.text 1494708 1494652 -56 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1096972 1096852 -120 -0.0
bss 130689 130689 0 0.0
rodata 111732 111612 -120 -0.1
text 806692 806688 -4 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1217320 1217228 -92 -0.0
bss 122827 122811 -16 -0.0
rodata 141592 141532 -60 -0.0
text 802388 802376 -12 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1046748 1046628 -120 -0.0
bss 129633 129633 0 0.0
rodata 99388 99268 -120 -0.1
text 769960 769956 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834568 834584 16 0.0
(read/write) 1791156 1791060 -96 -0.0
.bss 196116 196100 -16 -0.0
.data 2656 2656 0 0.0
.text 1583996 1583916 -80 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837624 837640 16 0.0
(read/write) 1715452 1715356 -96 -0.0
.bss 193084 193068 -16 -0.0
.data 2632 2632 0 0.0
.text 1511348 1511268 -80 -0.0
light cy8ckit_062s2_43012 (read only) 844352 844368 16 0.0
(read/write) 1634764 1634684 -80 -0.0
.bss 186548 186532 -16 -0.0
.data 2440 2440 0 0.0
.text 1437388 1437324 -64 -0.0
lock cy8ckit_062s2_43012 (read only) 817152 817168 16 0.0
(read/write) 1667076 1666980 -96 -0.0
.bss 213748 213732 -16 -0.0
.data 2440 2440 0 0.0
.text 1442500 1442420 -80 -0.0
qpg lighting-app qpg6105+debug (read/write) 1124832 1124704 -128 -0.0
.bss 102376 102376 0 0.0
.data 820 820 0 0.0
.text 637216 637088 -128 -0.0
lock-app qpg6105+debug (read/write) 1089624 1089504 -120 -0.0
.bss 98672 98672 0 0.0
.data 840 840 0 0.0
.text 602004 601884 -120 -0.0
stm32 light STM32WB5MM-DK (read/write) 597197 597077 -120 -0.0
.bss 128288 128288 0 0.0
.data 668 668 0 0.0
.rodata 78828 78708 -120 -0.2
.text 379688 379688 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825790 825662 -128 -0.0
bss 51116 51116 0 0.0
text 617518 617508 -10 -0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1085788 1085660 -128 -0.0
bss 101640 101640 0 0.0
text 788336 788326 -10 -0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1045016 1044888 -128 -0.0
bss 110028 110028 0 0.0
text 761032 761022 -10 -0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 907028 906900 -128 -0.0
bss 93060 93060 0 0.0
text 649692 649682 -10 -0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 827390 827262 -128 -0.0
bss 51164 51164 0 0.0
text 619180 619170 -10 -0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 933656 933528 -128 -0.0
bss 79204 79204 0 0.0
text 699864 699854 -10 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1068512 1068376 -136 -0.0
bss 100140 100140 0 0.0
text 773490 773480 -10 -0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 906684 906548 -136 -0.0
bss 70668 70668 0 0.0
text 655674 655664 -10 -0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 924808 924680 -128 -0.0
bss 92640 92640 0 0.0
text 667584 667574 -10 -0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 829998 829862 -136 -0.0
bss 51272 51272 0 0.0
text 622182 622172 -10 -0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 793720 793592 -128 -0.0
bss 57472 57472 0 0.0
text 592948 592938 -10 -0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676828 676716 -112 -0.0
bss 73640 73640 0 0.0
text 462228 462234 6 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 828654 828526 -128 -0.0
bss 51292 51292 0 0.0
text 621534 621524 -10 -0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 852333 852205 -128 -0.0
bss 60948 60948 0 0.0
text 636380 636370 -10 -0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 819308 819180 -128 -0.0
bss 57760 57760 0 0.0
text 612580 612570 -10 -0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 838764 838636 -128 -0.0
bss 69576 69576 0 0.0
text 629088 629078 -10 -0.0

@andy31415
Copy link
Contributor Author

This seems to give some savings across the board. Moving it out of draft.

@andy31415 andy31415 marked this pull request as ready for review February 13, 2024 20:04
@andy31415 andy31415 changed the title Test RAM savings if we re-order some structure members based on pahole feedback Get some RAM savings by re-ordering some structure members based on pahole feedback Feb 13, 2024
@mergify mergify bot merged commit b6f13d2 into project-chip:master Feb 14, 2024
57 checks passed
raul-marquez-csa pushed a commit to raul-marquez-csa/connectedhomeip that referenced this pull request Feb 16, 2024
@andy31415 @andreilitvin @raul-marquez-csa
Update some structure memory layour based on pahole feedback, see if …
09895d0 
…we gain RAM (project-chip#32106)

Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @woody-apple @jmartinez-silabs @andreilitvin