-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logging to Matter to aid in debuggability #32053
Adding logging to Matter to aid in debuggability #32053
Conversation
d60177b
to
f87e100
Compare
PR #32053: Size comparison from dbf3dad to 96cb167 Increases (3 builds for cc32xx, stm32)
Full report (3 builds for cc32xx, stm32)
|
PR #32053: Size comparison from dbf3dad to c6e111c Increases (4 builds for cc32xx, mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
462605e
to
6ab5abe
Compare
PR #32053: Size comparison from a95af94 to 6ab5abe Increases (11 builds for cc13x4_26x4, cc32xx, mbed, qpg, stm32)
Full report (11 builds for cc13x4_26x4, cc32xx, mbed, qpg, stm32)
|
PR #32053: Size comparison from a95af94 to 33ba339 Increases (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
Decreases (2 builds for linux)
Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #32053: Size comparison from a95af94 to 5012c37 Increases (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, mbed, qpg, stm32, telink)
Decreases (2 builds for linux)
Full report (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, mbed, qpg, stm32, telink)
|
PR #32053: Size comparison from a95af94 to b735edb Increases (23 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, qpg, stm32)
Decreases (2 builds for linux)
Full report (23 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, qpg, stm32)
|
PR #32053: Size comparison from a95af94 to eaf63a3 Increases (4 builds for cc32xx, mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
PR #32053: Size comparison from a95af94 to f166419 Increases (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #32053: Size comparison from a95af94 to efdbb1c Increases (55 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
Decreases (3 builds for efr32, linux)
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #32053: Size comparison from a95af94 to c3ad6f3 Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (3 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
src/darwin/Framework/Matter.xcodeproj/xcshareddata/xcschemes/Matter Framework Tests.xcscheme
Show resolved
Hide resolved
@bzbarsky-apple FYI:
That's not declared everywhere, I'll find the import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested due to layering concern: messaging and secure_channel including from app
is concerning.
e99cca7
to
9ef46a4
Compare
Fast tracking darwin only PR |
No longer touches any core code
9ef46a4
to
c03a597
Compare
PR #32053: Size comparison from b6f13d2 to c03a597 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Resolves #31804
Trying to make matter logs a little easier to debug :)
Made this PR Darwin only, since we need to urgently debug things.